{"messages":[{"content":"You are a constitutional council ranking individual git commits for ownership allocation.\n\nCompare these two commits. Decide which contributed more lasting value to the project.\n\nJudge substance, not spectacle:\n- Prefer correct, lasting design and real bugfixes over churn, formatting, renames, or generated noise.\n- Prefer clarity and necessity over sheer line count. A small precise change can beat a large diffuse one.\n- Do not favor a side merely because its patch is longer or noisier.\n- Weight what the change does for the project, not the contributor's name.\n\nReturn ONLY a JSON object: {\"winner\": \"A\" or \"B\", \"ratio\": \"N:M\", \"explanation\": \"...\"}\nThe explanation must cite concrete differences in the patches (1-3 sentences).\n\nSide A — contributor: tommy-mor\nSide A — commit message:\n[1c914c6e] stage set\n\nSide A — unified diff (full patch):\ndiff --git a/plan.md b/plan.md\nnew file mode 100644\nindex 0000000000000000000000000000000000000000..00d6867a1e0ed144a16a020ea037f685ce646c73\n--- /dev/null\n+++ b/plan.md\n@@ -0,0 +1,155 @@\n+# Plan: `ItemId` + `RouteContext` (identity vs hrefs)\n+\n+This document is for **the next agent** to continue the refactor without re-deriving context from chat. It supersedes ad-hoc notes: treat it as the checklist of record until the work lands and this file is deleted or trimmed.\n+\n+## Goal\n+\n+- **Identity** (what lives in the reducer graph, votes, indexes) becomes a **structural `ItemId` enum** in `slug-types`, not a canonical `String` / `CanonicalItemUrl` newtype.\n+- **Presentation** (tilde / dash display, breadcrumbs) derives from `ItemId` via explicit methods, not string stripping.\n+- **Routing** (browser `href`s for public vs room) goes through **`RouteContext`** (started in `server/src/html/routing.rs`) so Maud/handlers do not stitch `/r/…` vs `/~` ad hoc.\n+\n+**Non-goals for v1 of the migration:** backward-compatible JSONL or dual-read of old canonical strings in the event log (project has accepted breaking changes). If you reintroduce compat, document it here.\n+\n+## Current state (as of this plan)\n+\n+- **`CanonicalItemUrl`** (`types/src/paths.rs`): newtype around `String`; `parse` / `parent` / `display_path` / `tilde_tail` / etc. Reducer `ContentState`, `VoteData`, ranking, RPC, search, garden, breadcrumbs all use it or `String` keys derived from it.\n+- **`ThreadNav`** (`server/src/html/forum/nav.rs`): encodes scope prefixes for threads and garden URLs; **`RouteContext`** now wraps `ThreadNav` (`server/src/html/routing.rs`, re-exported from `server/src/html/mod.rs`) but **most HTML still takes `&ThreadNav` directly** — migration incomplete.\n+- **URL normalization** lives in `types/src/url_normalize.rs` + `canonicalize_item` / `finalize_external_identity_url` in `paths.rs` (YouTube, sorted query params, room path `room_route_segment` in `paths.rs`).\n+- **Room HTTP paths** are `/r/{short}{slug}` (fused segment); wire **`room_id`** remains `short/slug` for RPC/events.\n+\n+## Target architecture\n+\n+### `ItemId` (types)\n+\n+Suggested shape (adjust after profiling `Ord` / `Hash` / serde size):\n+\n+```text\n+ItemId::Root — tilde ontology root (today `SLUG_TILDE_ONTOLOGY_ROOT`)\n+ItemId::Local { segments } — slug.social ~/… path as Vec (lowercase segments, non-empty for non-root)\n+ItemId::External { url: Url } — normalized `url::Url` (crate `url` already in `slug-types`)\n+```\n+\n+**API surface (minimum):**\n+\n+- `ItemId::parse(&str) -> Option` — single entry from DSL / user input / legacy wire (internally may call `canonicalize_item` + structured split).\n+- `ItemId::to_wire_url(&self) -> String` — only for **external** boundaries if needed (HTTP fetch, rare assertions); avoid using as the primary key once maps use `ItemId`.\n+- `parent`, `display_path`, `tilde_tail` / `tilde_http_tail`, `tilde_segments`, `last_segment`, `normalized_storage` — port from `CanonicalItemUrl`.\n+- **`Ord` + `Hash` + `Eq`** stable for `BTreeSet` / `HashMap` (see `write_actor` scope-rank snapshots).\n+- **`Serialize` / `Deserialize`** — decide **tagged JSON** for any persisted or API-carried structs (e.g. `VoteData` in tests). If RPC must stay stringy for clients, use a **DTO layer** that converts `ItemId` ↔ wire at the boundary only.\n+\n+**Remove:** `CanonicalItemUrl` type and all `path_types::CanonicalItemUrl` / `slug_types::paths::CanonicalItemUrl` exports once call sites are migrated. **`Borrow`** on the old newtype goes away; update `nav!` / any code that assumed map keys borrowed as `str`.\n+\n+### `RouteContext` (server HTML)\n+\n+- **File:** `server/src/html/routing.rs` — **`RouteContext(ThreadNav)`** with `item_href`, `item_href_raw`, `thread_url`, `garden_root_url`, `room_url`, `From`/`Into` `ThreadNav`.\n+- **Direction:** new code and refactored Maud should take **`&RouteContext`** (or owned where appropriate) instead of `&ThreadNav` when building links. Long term, **`item_href(&ItemId)`** should not parse strings — it should pattern-match `ItemId` and append tilde tail or `/-/…` external tail using the same rules as today’s `ThreadNav::garden_item_url`.\n+\n+### Axum / garden routes\n+\n+- **No** single catch-all route (explicit decision): keep the existing router layout in `server/src/lib.rs`.\n+- Room routes stay **`/r/:room_key/...`** with `room_key` fused; parsing via `slug_types::room_id_from_route_segment` / `room_route_segment` in `paths.rs`.\n+\n+## Phased execution (recommended order)\n+\n+### Phase 0 — Preconditions (quick)\n+\n+1. Read **`AGENTS.md`** (UI contract, durability matrix, `RpcCommand` vs `HtmlUiAction`).\n+2. Run **`cargo test --workspace`** and **`./scripts/clj-test.sh`** on clean `main` before large diffs; repeat after each phase.\n+\n+### Phase 1 — `ItemId` in `slug-types` (no server yet)\n+\n+1. Add **`ItemId`** (new file e.g. `types/src/item_id.rs` **or** inline at bottom of `paths.rs` — see **Module cycle** below).\n+2. Implement **`ItemId::parse`** using existing **`canonicalize_item`** + normalization; port **`CanonicalItemUrl`** methods to **`ItemId`** with tests ported from `paths.rs` `#[cfg(test)] mod tests`.\n+3. **`GardenItemUrl::from_stored(&ItemId, room_wire)`** (and thread helpers) — build absolute hrefs from structure, not from re-parsing a canonical string.\n+4. **`TildeHttpPathTail::to_item_id`** (rename from `to_canonical`) / **`tilde_http_path_to_item_id`**.\n+5. **`TildeOntologyPath::from_stored(&ItemId)`**.\n+6. Export **`ItemId`** from **`types/src/lib.rs`**; update **`server/src/path_types.rs`** re-exports.\n+7. **Delete `CanonicalItemUrl`** and fix all **in-crate** references in `types` only until `cargo test` passes for `slug-types`.\n+\n+**Module cycle trap:** `item_id.rs` must not `use crate::paths::{...}` if `paths.rs` also imports `ItemId` for `GardenItemUrl` in the same module. **Fix one of:**\n+\n+- **A)** Put `ItemId` **inside `paths.rs`** below `canonicalize_item` / helpers (simplest, large file), or \n+- **B)** Split **`canonicalize_item`** (+ dash host helpers + `finalize_external_identity_url`) into **`types/src/item_wire.rs`**, then `paths.rs` + `item_id.rs` both depend on `item_wire` only (cleaner, more files).\n+\n+### Phase 2 — Reducer + ranking (server core)\n+\n+1. **`server/src/reducer.rs`**: `ContentState` / `GroupState` / **`VoteData`** — replace **`CanonicalItemUrl`** with **`ItemId`** on all maps, sets, deques, vectors.\n+2. **`apply_vote`**: normalize `a`/`b` via **`ItemId::parse`** or **`ItemId`**-aware logic (remove string round-trip).\n+3. **`apply_ingest_to_content`**: **`dsl`** still yields strings for item titles in statements; normalize to **`ItemId`** at ingest boundary via **`ItemId::parse`** once per item.\n+4. **`server/src/ranking.rs`**, **`server/src/scope_rank.rs`**, **`server/src/api/write_actor.rs`** (including **`BTreeSet`** ordering), **`server/src/api/validate.rs`**, **`server/src/api/helpers.rs`** — propagate **`ItemId`**.\n+5. **`server/tests/basic.rs`** and any reducer tests constructing **`VoteData`** — use **`ItemId::parse(...).unwrap()`** or helpers.\n+\n+### Phase 3 — RPC + search + external resolver\n+\n+1. **`server/src/api/rpc.rs`**: rank/pair/matchup/search payloads; today many paths use **`GardenItemUrl::from_storage_str(item.as_str(), …)`** — switch to **`ItemId`** + **`GardenItemUrl::from_stored(&item_id, …)`** (or equivalent).\n+2. **`server/src/html/search.rs`**: scoring uses item path strings — derive from **`ItemId::display_path`** / **`to_wire_url`** only at the scoring boundary if needed.\n+3. **`server/src/external_resolver.rs`**: take **`&ItemId`** or **`ItemId::external_url()`** instead of **`&CanonicalItemUrl`**.\n+\n+### Phase 4 — HTML / Maud\n+\n+1. **`ThreadNav::garden_item_url`**: overload or replace with **`garden_item_href(&self, item: &ItemId)`** (no `CanonicalItemUrl::parse` inside).\n+2. **`RouteContext`**: extend **`item_href(&ItemId)`**; migrate call sites from **`ThreadNav`** to **`RouteContext`** where only link-building is needed (keep **`ThreadNav`** where scope / auth helpers need the full struct).\n+3. **`server/src/html/garden.rs`**, **`breadcrumb_path.rs`**, **`forum/*`**, **`editor.rs`**: replace **`CanonicalItemUrl`** with **`ItemId`**; breadcrumbs should walk **`ItemId::parent`** without string `rsplit`.\n+4. **`types` JSON types** (`RankRow`, etc.): decide whether **`GardenItemUrl`** stays string for JSON or becomes a structured field; keep **one** wire format for the public API.\n+\n+### Phase 5 — Cleanup + docs\n+\n+1. Remove dead **`canonical_path`** / **`breadcrumb_path`** string logic if fully superseded.\n+2. Update **`AGENTS.md`** if durability, `POST /ui`, or command surfaces change.\n+3. Delete or shrink **`plan.md`** when done.\n+\n+## File / symbol checklist (non-exhaustive — grep-driven)\n+\n+Run periodically:\n+\n+```bash\n+rg \"CanonicalItemUrl\" -g'*.rs'\n+rg \"path_types::CanonicalItemUrl\" -g'*.rs'\n+rg \"tilde_http_path_to_canonical\" -g'*.rs'\n+```\n+\n+**High-touch files (from prior exploration):**\n+\n+| Area | Files |\n+|------|--------|\n+| Types | `types/src/paths.rs`, `types/src/lib.rs`, `types/src/url_normalize.rs`, (optional) `types/src/item_id.rs`, `types/src/item_wire.rs` |\n+| Server re-exports | `server/src/path_types.rs`, `server/src/canonical_path.rs` |\n+| Reducer / ingest | `server/src/reducer.rs`, `server/src/dsl.rs` (parse output types if changed) |\n+| Ranking | `server/src/ranking.rs`, `server/src/scope_rank.rs` |\n+| Writer / RPC | `server/src/api/write_actor.rs`, `server/src/api/rpc.rs`, `server/src/api/helpers.rs`, `server/src/api/validate.rs` |\n+| HTML | `server/src/html/garden.rs`, `server/src/html/breadcrumb_path.rs`, `server/src/html/forum/nav.rs`, `server/src/html/routing.rs`, `server/src/html/search.rs`, `server/src/html/editor.rs`, `server/src/html/forum/ingest.rs`, … |\n+| Tests | `server/tests/basic.rs`, `server/tests/integration.rs`, `types/src/paths.rs` tests, Clojure under `test/` if URLs/assertions mention canonical shapes |\n+\n+## Events / JSONL\n+\n+- **`Ingest`** events store **`raw` DSL** only — no change required for item identity inside the event.\n+- If any future event type stores item ids as strings, migrate to **structured `ItemId` serde** or accept string only at the event boundary with immediate parse into **`ItemId`** on `apply_event`.\n+\n+## `nav!` macro (`server/src/paths.rs`)\n+\n+- Macros use **`keypath($key)`** with **`.clone()`** — **`ItemId`** must be **`Clone`** (already for enums). Remove any reliance on **`Borrow`** for map keys.\n+\n+## Testing gate\n+\n+After each phase:\n+\n+```bash\n+cargo test --workspace\n+./scripts/clj-test.sh\n+```\n+\n+## Risks / gotchas\n+\n+1. **`Ord` on `ItemId`**: must match prior **`CanonicalItemUrl`** / `String` ordering wherever **`BTreeSet`** is used (e.g. deterministic scope-rank snapshots in **`write_actor`**).\n+2. **External `ItemId`**: **`Url`** equality / hashing — normalization is already centralized in **`url_normalize`**; ensure **`ItemId::parse`** always inserts normalized **`Url`** into **`External`**.\n+3. **Fake parent URLs** in garden (e.g. **`https://.`** for external root ranking): find all **`parse(\"https://.\")`** style hacks and express as **`ItemId`** or a dedicated sentinel.\n+4. **Serde**: tests and any RPC clients that snapshot JSON may need expectation updates if **`VoteData`** shape changes.\n+\n+## Optional follow-ups (not blocking `ItemId`)\n+\n+- More **domain normalizers** in **`url_normalize.rs`** (e.g. `music.youtube.com`, Spotify, etc.).\n+- **Room wire** vs **HTTP segment** helpers already in **`paths.rs`** (`ROOM_SHORT_ID_LEN`, `room_route_segment`, `room_id_from_route_segment`).\n+\n+---\n+\n+**End state criteria:** `rg CanonicalItemUrl` returns nothing; reducer maps use **`ItemId`**; HTML link generation for items goes through **`RouteContext` + `ItemId`**; tests and Kaocha green.\ndiff --git a/server/src/html/mod.rs b/server/src/html/mod.rs\nindex c3dccd03dc6da2a2f6f6fa828657e33a951884b1..668403a35c415e6f091362b28c63ac294057fb6d 100644\n--- a/server/src/html/mod.rs\n+++ b/server/src/html/mod.rs\n@@ -15,6 +15,7 @@ mod breadcrumb_path;\n mod editor;\n mod forum;\n mod garden;\n+pub mod routing;\n mod search;\n pub mod ui_action;\n use breadcrumb_path::{ExternalOntologyPath, OntologyPath};\n@@ -35,6 +36,7 @@ pub use garden::{\n external_garden_index, external_ontology_path, garden_index, ontology_path, room_external_garden_index,\n room_external_ontology_path, room_garden_index, room_ontology_path,\n };\n+pub use routing::RouteContext;\n pub use search::{search_page, search_results_fragment};\n pub use forum::user_profile_page;\n pub use ui_action::{parse_html_ui_from_form, HtmlUiAction, HtmlUiParseError, UI_RPC_FIELD};\ndiff --git a/server/src/html/routing.rs b/server/src/html/routing.rs\nnew file mode 100644\nindex 0000000000000000000000000000000000000000..13e9ae0cbe32d454e34a7737edf8234d2a558502\n--- /dev/null\n+++ b/server/src/html/routing.rs\n@@ -0,0 +1,71 @@\n+//! Scoped browser paths for HTML. **RouteContext** is the intended single place to build `href`s\n+//! given public vs room scope (the original blueprint name); today it wraps [`ThreadNav`].\n+//!\n+//! Prefer `RouteContext::item_href` / [`RouteContext::thread_url`] in new Maud over stitching\n+//! `/r/…` vs `/~` manually. Call sites can migrate incrementally from passing `&ThreadNav`.\n+\n+use crate::path_types::CanonicalItemUrl;\n+\n+use super::forum::ThreadNav;\n+\n+#[derive(Clone)]\n+pub struct RouteContext(ThreadNav);\n+\n+impl RouteContext {\n+ #[inline]\n+ pub fn public() -> Self {\n+ Self(ThreadNav::public())\n+ }\n+\n+ #[inline]\n+ pub fn from_room_id(room_id: &str) -> Option {\n+ ThreadNav::from_room_id(room_id).map(Self)\n+ }\n+\n+ #[inline]\n+ pub fn thread_nav(&self) -> &ThreadNav {\n+ &self.0\n+ }\n+\n+ #[inline]\n+ pub fn into_thread_nav(self) -> ThreadNav {\n+ self.0\n+ }\n+\n+ /// Relative path for a stored canonical item in this scope’s garden.\n+ pub fn item_href(&self, item: &CanonicalItemUrl) -> String {\n+ self.0.garden_item_url(item.as_str())\n+ }\n+\n+ /// Same as [`Self::item_href`] but parses `item` first (raw DSL / user paste).\n+ pub fn item_href_raw(&self, item: &str) -> String {\n+ self.0.garden_item_url(item)\n+ }\n+\n+ #[inline]\n+ pub fn thread_url(&self, tag: &str) -> String {\n+ self.0.thread_url(tag)\n+ }\n+\n+ #[inline]\n+ pub fn garden_root_url(&self) -> &str {\n+ self.0.garden_root_url()\n+ }\n+\n+ #[inline]\n+ pub fn room_url(&self) -> &str {\n+ self.0.room_url()\n+ }\n+}\n+\n+impl From for RouteContext {\n+ fn from(nav: ThreadNav) -> Self {\n+ Self(nav)\n+ }\n+}\n+\n+impl From for ThreadNav {\n+ fn from(ctx: RouteContext) -> Self {\n+ ctx.0\n+ }\n+}\n\n\nSide B — contributor: tommy-mor\nSide B — commit message:\n[aa0b175c] Enforce vote ratio constraints: both sides ≥ 1, max 100.\n\nZero on either side produces no valid graph edge; ratios above 100\nadd no meaningful signal. Enforce in the DSL parser, browser POST\nhandler, and reducer guard. Update browser pool test to use 99:1\ninstead of 100:0. Add unit and integration regression tests.\n\nCo-Authored-By: Claude Sonnet 4.6 \n\nSide B — unified diff (full patch):\ndiff --git a/server/src/api/ui_html.rs b/server/src/api/ui_html.rs\nindex b79efdb4d52bd445a67f38cbfd61d3507d2b3014..bc8a0130b434cc7880a4bf16eb9237080c4aa383 100644\n--- a/server/src/api/ui_html.rs\n+++ b/server/src/api/ui_html.rs\n@@ -243,11 +243,23 @@ async fn dispatch_ui_action(\n let pool_id = pool.as_deref().and_then(|p| {\n crate::path_types::ItemId::parse(p.trim()).map(|i| i.normalized_storage())\n });\n- let mut rl = ratio_left.trim().parse::().unwrap_or(0).max(0);\n- let mut rr = ratio_right.trim().parse::().unwrap_or(0).max(0);\n- if rl == 0 && rr == 0 {\n- rl = 1;\n- rr = 1;\n+ let rl = ratio_left.trim().parse::().unwrap_or(0).max(0);\n+ let rr = ratio_right.trim().parse::().unwrap_or(0).max(0);\n+ if rl == 0 || rr == 0 {\n+ return form_js_error(\n+ err_tgt.as_ref(),\n+ \"invalid ratio\",\n+ \"Both ratio sides must be ≥ 1.\",\n+ )\n+ .into_response();\n+ }\n+ if rl > 100 || rr > 100 {\n+ return form_js_error(\n+ err_tgt.as_ref(),\n+ \"invalid ratio\",\n+ \"Ratio sides must be ≤ 100.\",\n+ )\n+ .into_response();\n }\n \n let text = format!(\ndiff --git a/server/src/dsl.rs b/server/src/dsl.rs\nindex faa8aac6616bc6ea2b102d08ae999c01a716ef6e..338feacc579a92bed291867cc0f2f62462737462 100644\n--- a/server/src/dsl.rs\n+++ b/server/src/dsl.rs\n@@ -545,9 +545,14 @@ fn parse_block_prefixed_statement(\n \n let ((ratio_left, ratio_right), k) = parse_comparison_at(s, i)\n .ok_or_else(|| DslError::Parse(format!(\"invalid comparison near: {}\", &s[i..])))?;\n- if ratio_left == 0 && ratio_right == 0 {\n+ if ratio_left == 0 || ratio_right == 0 {\n return Err(DslError::Parse(\n- \"vote ratio 0:0 is invalid; use 1:1 for a tie or omit the vote\".to_string(),\n+ \"vote ratio sides must be ≥ 1; use 1:1 for a tie or omit the vote\".to_string(),\n+ ));\n+ }\n+ if ratio_left > 100 || ratio_right > 100 {\n+ return Err(DslError::Parse(\n+ \"vote ratio sides must be ≤ 100\".to_string(),\n ));\n }\n i = skip_ws(s, k);\n@@ -929,11 +934,50 @@ mod tests {\n let err = parse_full(\"{tie placeholder}\\n~/a 0:0 ~/b\").unwrap_err();\n let DslError::Parse(msg) = err;\n assert!(\n- msg.contains(\"0:0\"),\n- \"expected 0:0 rejection message, got: {msg}\"\n+ msg.contains(\"≥ 1\"),\n+ \"expected zero-side rejection message, got: {msg}\"\n );\n }\n \n+ #[test]\n+ fn parse_vote_rejects_left_zero_ratio() {\n+ let err = parse_full(\"{prefer b}\\n~/a 0:5 ~/b\").unwrap_err();\n+ let DslError::Parse(msg) = err;\n+ assert!(\n+ msg.contains(\"≥ 1\"),\n+ \"expected zero-side rejection message, got: {msg}\"\n+ );\n+ }\n+\n+ #[test]\n+ fn parse_vote_rejects_right_zero_ratio() {\n+ let err = parse_full(\"{prefer a}\\n~/a 5:0 ~/b\").unwrap_err();\n+ let DslError::Parse(msg) = err;\n+ assert!(\n+ msg.contains(\"≥ 1\"),\n+ \"expected zero-side rejection message, got: {msg}\"\n+ );\n+ }\n+\n+ #[test]\n+ fn parse_vote_rejects_over_max_ratio() {\n+ let err = parse_full(\"{prefer a strongly}\\n~/a 101:1 ~/b\").unwrap_err();\n+ let DslError::Parse(msg) = err;\n+ assert!(\n+ msg.contains(\"≤ 100\"),\n+ \"expected max ratio rejection message, got: {msg}\"\n+ );\n+ }\n+\n+ #[test]\n+ fn parse_vote_accepts_max_ratio() {\n+ let doc = parse_full(\"{prefer a}\\n~/a 100:1 ~/b\").unwrap();\n+ assert!(matches!(\n+ doc.statements.last(),\n+ Some(Stmt::Vote { ratio_left: 100, ratio_right: 1, .. })\n+ ));\n+ }\n+\n #[test]\n fn parse_full_interleaves_prose() {\n let input = \"hello\\n#tag\\nworld\";\ndiff --git a/server/src/reducer.rs b/server/src/reducer.rs\nindex e949e8e092297eedd5c20c131f16ef0121f329b3..6841d35cfc9de2389f340a22b8a45acb335e36c3 100644\n--- a/server/src/reducer.rs\n+++ b/server/src/reducer.rs\n@@ -119,11 +119,11 @@ impl GroupState {\n let (i, j) = if a_idx < b_idx { (a_idx, b_idx) } else { (b_idx, a_idx) };\n self.voted_pairs.insert((i, j));\n \n- let mut w_a = vote.ratio_left.max(0) as f64;\n- let mut w_b = vote.ratio_right.max(0) as f64;\n- if w_a == 0.0 && w_b == 0.0 {\n- w_a = 1.0;\n- w_b = 1.0;\n+ let w_a = vote.ratio_left as f64;\n+ let w_b = vote.ratio_right as f64;\n+ if w_a == 0.0 || w_b == 0.0 {\n+ // Zero on either side produces no valid edge; drop the vote.\n+ return;\n }\n \n self.add_edge_weight(b_idx, a_idx, w_a);\ndiff --git a/server/tests/basic.rs b/server/tests/basic.rs\nindex 9d83e7a97e2c7494790db17c4b5b30c181705026..cc8c1a0d139f3722ba6ecd13dd001c65be835b67 100644\n--- a/server/tests/basic.rs\n+++ b/server/tests/basic.rs\n@@ -175,14 +175,14 @@ fn reducer_clamps_score_bounds() {\n let mut state = ReducerState::default();\n state.apply_event(ingest_event(\n 1,\n- \"@00000000-0000-0000-0000-000000000000:test:local/test\\n~/t/a {a}\\n~/t/b {b}\\n{huge}\\n~/t/a 1000:1 ~/t/b\\n\",\n+ \"@00000000-0000-0000-0000-000000000000:test:local/test\\n~/t/a {a}\\n~/t/b {b}\\n{huge}\\n~/t/a 100:1 ~/t/b\\n\",\n ));\n state.apply_event(ingest_event(\n 2,\n- \"@00000000-0000-0000-0000-000000000000:test:local/test\\n{huge}\\n~/t/a 1:1000 ~/t/b\\n\",\n+ \"@00000000-0000-0000-0000-000000000000:test:local/test\\n{huge}\\n~/t/a 1:100 ~/t/b\\n\",\n ));\n \n- assert_eq!(state.public().ranking_group.idx_to_item.len(), 2); // Should still work, scores clamped internally\n+ assert_eq!(state.public().ranking_group.idx_to_item.len(), 2); // Should still work, scores handled internally\n }\n \n // ============================================================================\n@@ -513,8 +513,8 @@ fn dsl_parse_rejects_zero_zero_vote_ratio() {\n .expect_err(\"0:0 vote must be rejected by the parser\");\n let slugsocial_server::dsl::DslError::Parse(msg) = err;\n assert!(\n- msg.contains(\"0:0\"),\n- \"expected message about invalid 0:0 ratio, got: {msg}\"\n+ msg.contains(\"≥ 1\"),\n+ \"expected message about invalid zero ratio, got: {msg}\"\n );\n \n let mut state = ReducerState::default();\n@@ -533,7 +533,7 @@ fn dsl_parse_rejects_zero_zero_vote_ratio() {\n #[test]\n fn reducer_negative_ratio_clamped_to_zero() {\n let _state = ReducerState::default();\n- // GroupState::apply_vote clamps negatives to 0, then 0:0 -> 1:1\n+ // GroupState::apply_vote clamps negatives to 0; when either side is 0 the vote is dropped.\n let mut group = GroupState::new();\n group.apply_vote(slugsocial_server::reducer::VoteData {\n ts: 1,\n@@ -546,12 +546,12 @@ fn reducer_negative_ratio_clamped_to_zero() {\n delegate: Some(\"00000000-0000-0000-0000-000000000000:test:local/test\".to_string()),\n thread_tag: \"t\".to_string(),\n });\n+ // Items are registered, but the zero-clamped vote produces no edges.\n assert_eq!(group.idx_to_item.len(), 2);\n- // Both edges should exist (negatives clamped to 0, then 0:0 -> 1:1)\n let a_idx = group.item_to_idx[&item_id(\"https://slug.social/~/t/a\")];\n let b_idx = group.item_to_idx[&item_id(\"https://slug.social/~/t/b\")];\n- assert!(group.edges.contains_key(&(a_idx, b_idx)));\n- assert!(group.edges.contains_key(&(b_idx, a_idx)));\n+ assert!(!group.edges.contains_key(&(a_idx, b_idx)));\n+ assert!(!group.edges.contains_key(&(b_idx, a_idx)));\n }\n \n \ndiff --git a/server/tests/integration_ui.rs b/server/tests/integration_ui.rs\nindex 23db7b5672418d5bb0ab7529e05ef1f89e59062a..09c5481f039d59efb617a82bafcc432a186e2d30 100644\n--- a/server/tests/integration_ui.rs\n+++ b/server/tests/integration_ui.rs\n@@ -256,3 +256,96 @@ async fn test_sse_public_thread_morph_includes_post_body_not_thread_not_found()\n );\n }\n \n+fn ui_vote_compare_post_rpc(\n+ room: &str,\n+ thread_tag: &str,\n+ left: &str,\n+ right: &str,\n+ ratio_left: &str,\n+ ratio_right: &str,\n+ explanation: &str,\n+) -> String {\n+ serde_json::json!({\n+ \"action\": \"vote_compare_post\",\n+ \"room\": room,\n+ \"thread_tag\": thread_tag,\n+ \"left_item\": left,\n+ \"right_item\": right,\n+ \"ratio_left\": ratio_left,\n+ \"ratio_right\": ratio_right,\n+ \"explanation\": explanation,\n+ \"next\": \"/vote\",\n+ })\n+ .to_string()\n+}\n+\n+#[tokio::test]\n+async fn test_vote_compare_post_rejects_zero_left_ratio() {\n+ let (addr, _tmp, _log, _handle) = create_test_server().await;\n+ let client = reqwest::Client::new();\n+ let bearer = test_bearer();\n+\n+ let rpc = ui_vote_compare_post_rpc(\"public\", \"test-vote\", \"~/a\", \"~/b\", \"0\", \"5\", \"prefer b\");\n+ let resp = client\n+ .post(format!(\"http://{addr}/ui\"))\n+ .header(\"Authorization\", format!(\"Bearer {bearer}\"))\n+ .form(&[(\"__rpc__\", rpc.as_str())])\n+ .send()\n+ .await\n+ .unwrap();\n+\n+ assert_eq!(resp.status(), reqwest::StatusCode::OK);\n+ let js = resp.text().await.unwrap();\n+ assert!(\n+ js.contains(\"invalid ratio\") || js.contains(\"≥ 1\"),\n+ \"expected zero-ratio rejection, got: {js}\"\n+ );\n+}\n+\n+#[tokio::test]\n+async fn test_vote_compare_post_rejects_zero_right_ratio() {\n+ let (addr, _tmp, _log, _handle) = create_test_server().await;\n+ let client = reqwest::Client::new();\n+ let bearer = test_bearer();\n+\n+ let rpc = ui_vote_compare_post_rpc(\"public\", \"test-vote\", \"~/a\", \"~/b\", \"5\", \"0\", \"prefer a\");\n+ let resp = client\n+ .post(format!(\"http://{addr}/ui\"))\n+ .header(\"Authorization\", format!(\"Bearer {bearer}\"))\n+ .form(&[(\"__rpc__\", rpc.as_str())])\n+ .send()\n+ .await\n+ .unwrap();\n+\n+ assert_eq!(resp.status(), reqwest::StatusCode::OK);\n+ let js = resp.text().await.unwrap();\n+ assert!(\n+ js.contains(\"invalid ratio\") || js.contains(\"≥ 1\"),\n+ \"expected zero-ratio rejection, got: {js}\"\n+ );\n+}\n+\n+#[tokio::test]\n+async fn test_vote_compare_post_rejects_over_max_ratio() {\n+ let (addr, _tmp, _log, _handle) = create_test_server().await;\n+ let client = reqwest::Client::new();\n+ let bearer = test_bearer();\n+\n+ let rpc =\n+ ui_vote_compare_post_rpc(\"public\", \"test-vote\", \"~/a\", \"~/b\", \"101\", \"1\", \"prefer a\");\n+ let resp = client\n+ .post(format!(\"http://{addr}/ui\"))\n+ .header(\"Authorization\", format!(\"Bearer {bearer}\"))\n+ .form(&[(\"__rpc__\", rpc.as_str())])\n+ .send()\n+ .await\n+ .unwrap();\n+\n+ assert_eq!(resp.status(), reqwest::StatusCode::OK);\n+ let js = resp.text().await.unwrap();\n+ assert!(\n+ js.contains(\"invalid ratio\") || js.contains(\"≤ 100\"),\n+ \"expected over-max ratio rejection, got: {js}\"\n+ );\n+}\n+\ndiff --git a/test/browser_vote_pool.clj b/test/browser_vote_pool.clj\nindex 23d0bd80b02bd8b1b48853454bed02793296550e..738608801027d1e662660b5d6c830b4ccd07c434 100644\n--- a/test/browser_vote_pool.clj\n+++ b/test/browser_vote_pool.clj\n@@ -38,8 +38,8 @@\n ;; Set the hidden ratio inputs so the alphabetically-earlier item wins.\n (defn- set-ratio! [pg left-text right-text]\n (let [[rl rr] (if (neg? (compare (leaf left-text) (leaf right-text)))\n- [100 0] ; left is earlier → prefer left\n- [0 100])] ; right is earlier → prefer right\n+ [99 1] ; left is earlier → prefer left\n+ [1 99])] ; right is earlier → prefer right\n (page/evaluate pg (str \"document.getElementById('vote-ratio-left').value='\" rl \"'\"))\n (page/evaluate pg (str \"document.getElementById('vote-ratio-right').value='\" rr \"'\"))))\n \n","role":"user"}],"model":"~anthropic/claude-sonnet-latest"}