{"messages":[{"content":"You are a constitutional council ranking individual git commits for ownership allocation.\n\nCompare these two commits. Decide which contributed more lasting value to the project.\n\nJudge substance, not spectacle:\n- Prefer correct, lasting design and real bugfixes over churn, formatting, renames, or generated noise.\n- Prefer clarity and necessity over sheer line count. A small precise change can beat a large diffuse one.\n- Do not favor a side merely because its patch is longer or noisier.\n- Weight what the change does for the project, not the contributor's name.\n\nReturn ONLY a JSON object: {\"winner\": \"A\" or \"B\", \"ratio\": \"N:M\", \"explanation\": \"...\"}\nThe explanation must cite concrete differences in the patches (1-3 sentences).\n\nSide A — contributor: tommy-mor\nSide A — commit message:\n[5350388a] Add pool-scoped voting: /vote?pool= picks pairs from children.\n\n- /vote now accepts an optional `pool` param (parent item path). When\n provided without left/right, it picks the first unvoted pair from the\n pool's children. When provided alongside left/right, it constrains\n \"next pair\" navigation to siblings within the pool.\n- \"vote on children\" button appears on item pages with ≥2 children,\n linking to /vote?pool=.\n- Pool is threaded through VoteComparePost → success JS so in-page\n morph after voting keeps the pool context for next-pair navigation.\n\nCo-Authored-By: Claude Sonnet 4.6 \n\nSide A — unified diff (full patch):\ndiff --git a/server/src/api/ui_html.rs b/server/src/api/ui_html.rs\nindex 5faa642451d69555cb391974beb0ad22c9355c8c..b79efdb4d52bd445a67f38cbfd61d3507d2b3014 100644\n--- a/server/src/api/ui_html.rs\n+++ b/server/src/api/ui_html.rs\n@@ -193,6 +193,7 @@ async fn dispatch_ui_action(\n ratio_right,\n explanation,\n next,\n+ pool,\n form_action,\n } => {\n if form_action != \"/ui\" {\n@@ -239,6 +240,9 @@ async fn dispatch_ui_action(\n .into_response();\n }\n };\n+ let pool_id = pool.as_deref().and_then(|p| {\n+ crate::path_types::ItemId::parse(p.trim()).map(|i| i.normalized_storage())\n+ });\n let mut rl = ratio_left.trim().parse::().unwrap_or(0).max(0);\n let mut rr = ratio_right.trim().parse::().unwrap_or(0).max(0);\n if rl == 0 && rr == 0 {\n@@ -294,6 +298,7 @@ async fn dispatch_ui_action(\n &thread_tag,\n &left_id,\n &right_id,\n+ pool_id.as_ref(),\n pid.as_str(),\n post_index,\n )\ndiff --git a/server/src/html/garden/pin.rs b/server/src/html/garden/pin.rs\nindex 5865cfdbc06aeb6555c97380e25591fae6b3d125..1820d7fe7ee167ecbf5ad5124f23b2ab92ffb01f 100644\n--- a/server/src/html/garden/pin.rs\n+++ b/server/src/html/garden/pin.rs\n@@ -79,7 +79,7 @@ pub(super) fn ont_pin_vote_controls(\n }\n }\n } @else {\n- a class=\"ont-vote-compare-btn\" href=(vote_compare_href(nav, pi, ¤t, None)) title=\"Compare and vote\" {\n+ a class=\"ont-vote-compare-btn\" href=(vote_compare_href(nav, pi, ¤t, None, None)) title=\"Compare and vote\" {\n span class=\"ont-vote-glyph\" aria-hidden=\"true\" { \"⚖\" }\n span { \"vote\" }\n }\n@@ -121,7 +121,7 @@ pub(super) fn child_row_pin_or_vote(\n if nv == 1 { \"\" } else { \"s\" },\n );\n @let aria = format!(\"Vote; {} pairwise {}\", nv, if nv == 1 { \"vote\" } else { \"votes\" });\n- a class=\"ont-garden-vote-ico\" href=(vote_compare_href(nav, pi, row_item, None)) title=(tip) aria-label=(aria) {\n+ a class=\"ont-garden-vote-ico\" href=(vote_compare_href(nav, pi, row_item, None, None)) title=(tip) aria-label=(aria) {\n span class=\"ont-garden-vote-glyph\" aria-hidden=\"true\" { \"⚖\" }\n span class=\"ont-garden-vote-count\" { (format!(\"{}\", nv)) }\n }\ndiff --git a/server/src/html/garden/render.rs b/server/src/html/garden/render.rs\nindex 5c3986ca36902f6c9019a4b5590f0b3b9d2cb4ff..bd8cbce059ee789de6e8dc9b6f69f54beee2f994 100644\n--- a/server/src/html/garden/render.rs\n+++ b/server/src/html/garden/render.rs\n@@ -29,6 +29,7 @@ use super::{\n item::{child_depth_from_uri, item_code_label, item_display_path, item_href},\n item_page::{build_item_page_view_model, sibling_nav_markup},\n pin::{child_row_pin_or_vote, ont_pin_vote_controls, pinned_item_from_jar},\n+ vote::vote_pool_href,\n };\n \n pub(super) async fn render_scope_view(\n@@ -186,12 +187,21 @@ pub(super) async fn render_scope_view(\n }\n \n section class=\"ont-tab-panel ont-tab-panel-children\" {\n+ @let total_children = model.child_rankings.component_rankings\n+ .iter().map(|c| c.ranked.len()).sum::()\n+ + model.child_rankings.unranked_items.len();\n h3 {\n \"ranked child groups\"\n @if model.child_depth > 1 {\n \" \"\n span class=\"muted\" { (format!(\"(depth {})\", model.child_depth)) }\n }\n+ @if total_children >= 2 {\n+ \" \"\n+ a class=\"ont-vote-children-btn\" href=(vote_pool_href(&nav, &model.item)) {\n+ \"vote on children\"\n+ }\n+ }\n }\n @if model.child_rankings.component_rankings.is_empty() {\n p class=\"muted\" { \"no voted pairs yet in this scope\" }\ndiff --git a/server/src/html/garden/tests.rs b/server/src/html/garden/tests.rs\nindex 6900a6795bcde866a176722149d6378e5127b4c3..c2036fca7752aef63d260e36cfe9649f63b5c550 100644\n--- a/server/src/html/garden/tests.rs\n+++ b/server/src/html/garden/tests.rs\n@@ -105,7 +105,7 @@ fn suggest_next_vote_pair_prefers_unvoted_sibling_pair() {\n let content = content_for_garden_view(&reduced, &ScopeId::Public);\n let a = ItemId::parse(\"~/topic/a\").unwrap().normalized_storage();\n let b = ItemId::parse(\"~/topic/b\").unwrap().normalized_storage();\n- let next = suggest_next_vote_pair(content, &a, &b).expect(\"next sibling pair\");\n+ let next = suggest_next_vote_pair(content, &a, &b, None).expect(\"next sibling pair\");\n assert_ne!(\n canonical_edge_items(&next.0, &next.1),\n canonical_edge_items(&a, &b)\ndiff --git a/server/src/html/garden/vote.rs b/server/src/html/garden/vote.rs\nindex 1d7fc8aa7436bfa9c1186dfd940a8d751ab7e088..2682cfcbd2f834b56459a02831aa225cffe67c58 100644\n--- a/server/src/html/garden/vote.rs\n+++ b/server/src/html/garden/vote.rs\n@@ -211,14 +211,15 @@ pub(crate) async fn vote_compare_post_success_js(\n _thread_tag: &str,\n left: &ItemId,\n right: &ItemId,\n+ pool: Option<&ItemId>,\n _post_id: &str,\n _post_idx: Option,\n ) -> String {\n let reduced = state.reduced.read().await;\n let content = content_for_garden_view(&reduced, &nav.scope());\n let edge_history = vote_edge_history_markup(content, left, right);\n- let next_pair = suggest_next_vote_pair(content, left, right);\n- let nav_markup = vote_compare_nav_markup(nav, next_pair.as_ref());\n+ let next_pair = suggest_next_vote_pair(content, left, right, pool);\n+ let nav_markup = vote_compare_nav_markup(nav, next_pair.as_ref(), pool);\n drop(reduced);\n JsBuilder::new()\n .morph_inner_selector(\"#vote-edge-history-region\", edge_history)\n@@ -231,27 +232,39 @@ pub(super) fn vote_compare_href(\n left: &ItemId,\n right: &ItemId,\n thread_override: Option<&str>,\n+ pool: Option<&ItemId>,\n ) -> String {\n let left_q = urlencoding::encode(left.as_str());\n let right_q = urlencoding::encode(right.as_str());\n- let base = format!(\n+ let mut base = format!(\n \"{}/vote?left={}&right={}\",\n nav.room_path_prefix_for_vote_compare(),\n left_q,\n right_q\n );\n if let Some(t) = thread_override.filter(|s| !s.is_empty()) {\n- format!(\"{}&thread={}\", base, urlencoding::encode(t))\n- } else {\n- base\n+ base = format!(\"{}&thread={}\", base, urlencoding::encode(t));\n+ }\n+ if let Some(p) = pool {\n+ base = format!(\"{}&pool={}\", base, urlencoding::encode(p.as_str()));\n }\n+ base\n+}\n+\n+pub(super) fn vote_pool_href(nav: &ThreadNav, pool_item_str: &str) -> String {\n+ format!(\n+ \"{}/vote?pool={}\",\n+ nav.room_path_prefix_for_vote_compare(),\n+ urlencoding::encode(pool_item_str)\n+ )\n }\n \n fn vote_compare_nav_markup(\n nav: &ThreadNav,\n next_pair: Option<&(ItemId, ItemId)>,\n+ pool: Option<&ItemId>,\n ) -> maud::Markup {\n- let next_pair_href = next_pair.map(|(nl, nr)| vote_compare_href(nav, nl, nr, None));\n+ let next_pair_href = next_pair.map(|(nl, nr)| vote_compare_href(nav, nl, nr, None, pool));\n html! {\n div class=\"vote-compare-nav\" {\n @if let Some(href) = &next_pair_href {\n@@ -267,8 +280,15 @@ pub(super) fn suggest_next_vote_pair(\n content: &ContentState,\n current_left: &ItemId,\n current_right: &ItemId,\n+ pool_parent: Option<&ItemId>,\n ) -> Option<(ItemId, ItemId)> {\n- let pool: Vec = if current_left.parent().as_ref().map(|p| p.as_str())\n+ let pool: Vec = if let Some(parent) = pool_parent {\n+ content\n+ .item_children\n+ .get(parent)\n+ .map(|s| s.iter().cloned().collect())\n+ .unwrap_or_default()\n+ } else if current_left.parent().as_ref().map(|p| p.as_str())\n == current_right.parent().as_ref().map(|p| p.as_str())\n {\n current_left\n@@ -322,10 +342,14 @@ pub(super) fn vote_compare_item_card(\n }\n #[derive(Debug, Deserialize)]\n pub struct VoteCompareQuery {\n- pub left: String,\n- pub right: String,\n+ #[serde(default)]\n+ pub left: Option,\n+ #[serde(default)]\n+ pub right: Option,\n #[serde(default)]\n pub thread: Option,\n+ #[serde(default)]\n+ pub pool: Option,\n }\n \n /// Public pairwise vote UI — `/vote?left=&right=&thread=`.\n@@ -376,17 +400,53 @@ async fn vote_compare_inner(\n jar: CookieJar,\n uri: Uri,\n ) -> axum::response::Response {\n- let left = match ItemId::parse(q.left.trim()) {\n- Some(i) => i.normalized_storage(),\n- None => return (StatusCode::NOT_FOUND, \"bad left item\").into_response(),\n+ let pool_id: Option = match q.pool.as_deref() {\n+ Some(p) => match ItemId::parse(p.trim()) {\n+ Some(i) => Some(i.normalized_storage()),\n+ None => return (StatusCode::BAD_REQUEST, \"bad pool item\").into_response(),\n+ },\n+ None => None,\n };\n- let right = match ItemId::parse(q.right.trim()) {\n- Some(i) => i.normalized_storage(),\n- None => return (StatusCode::NOT_FOUND, \"bad right item\").into_response(),\n+\n+ let (left, right) = match (q.left.as_deref(), q.right.as_deref()) {\n+ (Some(l), Some(r)) => {\n+ let left = match ItemId::parse(l.trim()) {\n+ Some(i) => i.normalized_storage(),\n+ None => return (StatusCode::NOT_FOUND, \"bad left item\").into_response(),\n+ };\n+ let right = match ItemId::parse(r.trim()) {\n+ Some(i) => i.normalized_storage(),\n+ None => return (StatusCode::NOT_FOUND, \"bad right item\").into_response(),\n+ };\n+ if left == right {\n+ return (StatusCode::BAD_REQUEST, \"items must differ\").into_response();\n+ }\n+ (left, right)\n+ }\n+ (None, None) => {\n+ let Some(pool) = pool_id.as_ref() else {\n+ return (StatusCode::BAD_REQUEST, \"provide left+right or pool\").into_response();\n+ };\n+ let reduced = state.reduced.read().await;\n+ let content = content_for_garden_view(&reduced, &nav.scope());\n+ let children: Vec = content\n+ .item_children\n+ .get(pool)\n+ .map(|s| s.iter().cloned().collect())\n+ .unwrap_or_default();\n+ if children.len() < 2 {\n+ drop(reduced);\n+ return (StatusCode::BAD_REQUEST, \"pool has fewer than 2 children to compare\").into_response();\n+ }\n+ let pair = suggest_next_pair_in_pool(&content.ranking_group, &children, None);\n+ drop(reduced);\n+ match pair {\n+ Some(p) => p,\n+ None => return (StatusCode::BAD_REQUEST, \"no pairs available in pool\").into_response(),\n+ }\n+ }\n+ _ => return (StatusCode::BAD_REQUEST, \"provide both left and right, or just pool\").into_response(),\n };\n- if left == right {\n- return (StatusCode::BAD_REQUEST, \"items must differ\").into_response();\n- }\n \n let reduced = state.reduced.read().await;\n let content = content_for_garden_view(&reduced, &nav.scope());\n@@ -409,7 +469,7 @@ async fn vote_compare_inner(\n let left_body = content.item_bodies.get(&left).cloned();\n let right_body = content.item_bodies.get(&right).cloned();\n let item_bodies_for_cards = content.item_bodies.clone();\n- let next_pair = suggest_next_vote_pair(content, &left, &right);\n+ let next_pair = suggest_next_vote_pair(content, &left, &right, pool_id.as_ref());\n drop(reduced);\n \n let title = format!(\n@@ -432,6 +492,7 @@ async fn vote_compare_inner(\n \"ratio_right\": {\"$form\": \"ratio_right\"},\n \"explanation\": {\"$form\": \"explanation\"},\n \"next\": next_path,\n+ \"pool\": pool_id.as_ref().map(|p| p.as_str()),\n \"form_action\": \"/ui\",\n }))\n .expect(\"vote compare rpc json\");\n@@ -456,7 +517,7 @@ async fn vote_compare_inner(\n Some(&item_bodies_for_cards),\n ))\n }\n- (vote_compare_nav_markup(&nav, next_pair.as_ref()))\n+ (vote_compare_nav_markup(&nav, next_pair.as_ref(), pool_id.as_ref()))\n div id=\"vote-edge-history-region\" {\n (edge_history)\n }\ndiff --git a/server/src/html/ui_action.rs b/server/src/html/ui_action.rs\nindex dd5294202569454acf9f41b458718700bbf96f39..2589a2cc00bb7b18cd19ebcbb938083122d6921d 100644\n--- a/server/src/html/ui_action.rs\n+++ b/server/src/html/ui_action.rs\n@@ -50,6 +50,9 @@ pub enum HtmlUiAction {\n explanation: String,\n /// Same-origin path after successful post (JS redirect).\n next: String,\n+ /// Pool parent item path, if the vote was initiated from a pool URL.\n+ #[serde(default)]\n+ pool: Option,\n #[serde(default = \"default_ui_form_action\")]\n form_action: String,\n },\n\n\nSide B — contributor: tommy-mor\nSide B — commit message:\n[aa0b175c] Enforce vote ratio constraints: both sides ≥ 1, max 100.\n\nZero on either side produces no valid graph edge; ratios above 100\nadd no meaningful signal. Enforce in the DSL parser, browser POST\nhandler, and reducer guard. Update browser pool test to use 99:1\ninstead of 100:0. Add unit and integration regression tests.\n\nCo-Authored-By: Claude Sonnet 4.6 \n\nSide B — unified diff (full patch):\ndiff --git a/server/src/api/ui_html.rs b/server/src/api/ui_html.rs\nindex b79efdb4d52bd445a67f38cbfd61d3507d2b3014..bc8a0130b434cc7880a4bf16eb9237080c4aa383 100644\n--- a/server/src/api/ui_html.rs\n+++ b/server/src/api/ui_html.rs\n@@ -243,11 +243,23 @@ async fn dispatch_ui_action(\n let pool_id = pool.as_deref().and_then(|p| {\n crate::path_types::ItemId::parse(p.trim()).map(|i| i.normalized_storage())\n });\n- let mut rl = ratio_left.trim().parse::().unwrap_or(0).max(0);\n- let mut rr = ratio_right.trim().parse::().unwrap_or(0).max(0);\n- if rl == 0 && rr == 0 {\n- rl = 1;\n- rr = 1;\n+ let rl = ratio_left.trim().parse::().unwrap_or(0).max(0);\n+ let rr = ratio_right.trim().parse::().unwrap_or(0).max(0);\n+ if rl == 0 || rr == 0 {\n+ return form_js_error(\n+ err_tgt.as_ref(),\n+ \"invalid ratio\",\n+ \"Both ratio sides must be ≥ 1.\",\n+ )\n+ .into_response();\n+ }\n+ if rl > 100 || rr > 100 {\n+ return form_js_error(\n+ err_tgt.as_ref(),\n+ \"invalid ratio\",\n+ \"Ratio sides must be ≤ 100.\",\n+ )\n+ .into_response();\n }\n \n let text = format!(\ndiff --git a/server/src/dsl.rs b/server/src/dsl.rs\nindex faa8aac6616bc6ea2b102d08ae999c01a716ef6e..338feacc579a92bed291867cc0f2f62462737462 100644\n--- a/server/src/dsl.rs\n+++ b/server/src/dsl.rs\n@@ -545,9 +545,14 @@ fn parse_block_prefixed_statement(\n \n let ((ratio_left, ratio_right), k) = parse_comparison_at(s, i)\n .ok_or_else(|| DslError::Parse(format!(\"invalid comparison near: {}\", &s[i..])))?;\n- if ratio_left == 0 && ratio_right == 0 {\n+ if ratio_left == 0 || ratio_right == 0 {\n return Err(DslError::Parse(\n- \"vote ratio 0:0 is invalid; use 1:1 for a tie or omit the vote\".to_string(),\n+ \"vote ratio sides must be ≥ 1; use 1:1 for a tie or omit the vote\".to_string(),\n+ ));\n+ }\n+ if ratio_left > 100 || ratio_right > 100 {\n+ return Err(DslError::Parse(\n+ \"vote ratio sides must be ≤ 100\".to_string(),\n ));\n }\n i = skip_ws(s, k);\n@@ -929,11 +934,50 @@ mod tests {\n let err = parse_full(\"{tie placeholder}\\n~/a 0:0 ~/b\").unwrap_err();\n let DslError::Parse(msg) = err;\n assert!(\n- msg.contains(\"0:0\"),\n- \"expected 0:0 rejection message, got: {msg}\"\n+ msg.contains(\"≥ 1\"),\n+ \"expected zero-side rejection message, got: {msg}\"\n );\n }\n \n+ #[test]\n+ fn parse_vote_rejects_left_zero_ratio() {\n+ let err = parse_full(\"{prefer b}\\n~/a 0:5 ~/b\").unwrap_err();\n+ let DslError::Parse(msg) = err;\n+ assert!(\n+ msg.contains(\"≥ 1\"),\n+ \"expected zero-side rejection message, got: {msg}\"\n+ );\n+ }\n+\n+ #[test]\n+ fn parse_vote_rejects_right_zero_ratio() {\n+ let err = parse_full(\"{prefer a}\\n~/a 5:0 ~/b\").unwrap_err();\n+ let DslError::Parse(msg) = err;\n+ assert!(\n+ msg.contains(\"≥ 1\"),\n+ \"expected zero-side rejection message, got: {msg}\"\n+ );\n+ }\n+\n+ #[test]\n+ fn parse_vote_rejects_over_max_ratio() {\n+ let err = parse_full(\"{prefer a strongly}\\n~/a 101:1 ~/b\").unwrap_err();\n+ let DslError::Parse(msg) = err;\n+ assert!(\n+ msg.contains(\"≤ 100\"),\n+ \"expected max ratio rejection message, got: {msg}\"\n+ );\n+ }\n+\n+ #[test]\n+ fn parse_vote_accepts_max_ratio() {\n+ let doc = parse_full(\"{prefer a}\\n~/a 100:1 ~/b\").unwrap();\n+ assert!(matches!(\n+ doc.statements.last(),\n+ Some(Stmt::Vote { ratio_left: 100, ratio_right: 1, .. })\n+ ));\n+ }\n+\n #[test]\n fn parse_full_interleaves_prose() {\n let input = \"hello\\n#tag\\nworld\";\ndiff --git a/server/src/reducer.rs b/server/src/reducer.rs\nindex e949e8e092297eedd5c20c131f16ef0121f329b3..6841d35cfc9de2389f340a22b8a45acb335e36c3 100644\n--- a/server/src/reducer.rs\n+++ b/server/src/reducer.rs\n@@ -119,11 +119,11 @@ impl GroupState {\n let (i, j) = if a_idx < b_idx { (a_idx, b_idx) } else { (b_idx, a_idx) };\n self.voted_pairs.insert((i, j));\n \n- let mut w_a = vote.ratio_left.max(0) as f64;\n- let mut w_b = vote.ratio_right.max(0) as f64;\n- if w_a == 0.0 && w_b == 0.0 {\n- w_a = 1.0;\n- w_b = 1.0;\n+ let w_a = vote.ratio_left as f64;\n+ let w_b = vote.ratio_right as f64;\n+ if w_a == 0.0 || w_b == 0.0 {\n+ // Zero on either side produces no valid edge; drop the vote.\n+ return;\n }\n \n self.add_edge_weight(b_idx, a_idx, w_a);\ndiff --git a/server/tests/basic.rs b/server/tests/basic.rs\nindex 9d83e7a97e2c7494790db17c4b5b30c181705026..cc8c1a0d139f3722ba6ecd13dd001c65be835b67 100644\n--- a/server/tests/basic.rs\n+++ b/server/tests/basic.rs\n@@ -175,14 +175,14 @@ fn reducer_clamps_score_bounds() {\n let mut state = ReducerState::default();\n state.apply_event(ingest_event(\n 1,\n- \"@00000000-0000-0000-0000-000000000000:test:local/test\\n~/t/a {a}\\n~/t/b {b}\\n{huge}\\n~/t/a 1000:1 ~/t/b\\n\",\n+ \"@00000000-0000-0000-0000-000000000000:test:local/test\\n~/t/a {a}\\n~/t/b {b}\\n{huge}\\n~/t/a 100:1 ~/t/b\\n\",\n ));\n state.apply_event(ingest_event(\n 2,\n- \"@00000000-0000-0000-0000-000000000000:test:local/test\\n{huge}\\n~/t/a 1:1000 ~/t/b\\n\",\n+ \"@00000000-0000-0000-0000-000000000000:test:local/test\\n{huge}\\n~/t/a 1:100 ~/t/b\\n\",\n ));\n \n- assert_eq!(state.public().ranking_group.idx_to_item.len(), 2); // Should still work, scores clamped internally\n+ assert_eq!(state.public().ranking_group.idx_to_item.len(), 2); // Should still work, scores handled internally\n }\n \n // ============================================================================\n@@ -513,8 +513,8 @@ fn dsl_parse_rejects_zero_zero_vote_ratio() {\n .expect_err(\"0:0 vote must be rejected by the parser\");\n let slugsocial_server::dsl::DslError::Parse(msg) = err;\n assert!(\n- msg.contains(\"0:0\"),\n- \"expected message about invalid 0:0 ratio, got: {msg}\"\n+ msg.contains(\"≥ 1\"),\n+ \"expected message about invalid zero ratio, got: {msg}\"\n );\n \n let mut state = ReducerState::default();\n@@ -533,7 +533,7 @@ fn dsl_parse_rejects_zero_zero_vote_ratio() {\n #[test]\n fn reducer_negative_ratio_clamped_to_zero() {\n let _state = ReducerState::default();\n- // GroupState::apply_vote clamps negatives to 0, then 0:0 -> 1:1\n+ // GroupState::apply_vote clamps negatives to 0; when either side is 0 the vote is dropped.\n let mut group = GroupState::new();\n group.apply_vote(slugsocial_server::reducer::VoteData {\n ts: 1,\n@@ -546,12 +546,12 @@ fn reducer_negative_ratio_clamped_to_zero() {\n delegate: Some(\"00000000-0000-0000-0000-000000000000:test:local/test\".to_string()),\n thread_tag: \"t\".to_string(),\n });\n+ // Items are registered, but the zero-clamped vote produces no edges.\n assert_eq!(group.idx_to_item.len(), 2);\n- // Both edges should exist (negatives clamped to 0, then 0:0 -> 1:1)\n let a_idx = group.item_to_idx[&item_id(\"https://slug.social/~/t/a\")];\n let b_idx = group.item_to_idx[&item_id(\"https://slug.social/~/t/b\")];\n- assert!(group.edges.contains_key(&(a_idx, b_idx)));\n- assert!(group.edges.contains_key(&(b_idx, a_idx)));\n+ assert!(!group.edges.contains_key(&(a_idx, b_idx)));\n+ assert!(!group.edges.contains_key(&(b_idx, a_idx)));\n }\n \n \ndiff --git a/server/tests/integration_ui.rs b/server/tests/integration_ui.rs\nindex 23db7b5672418d5bb0ab7529e05ef1f89e59062a..09c5481f039d59efb617a82bafcc432a186e2d30 100644\n--- a/server/tests/integration_ui.rs\n+++ b/server/tests/integration_ui.rs\n@@ -256,3 +256,96 @@ async fn test_sse_public_thread_morph_includes_post_body_not_thread_not_found()\n );\n }\n \n+fn ui_vote_compare_post_rpc(\n+ room: &str,\n+ thread_tag: &str,\n+ left: &str,\n+ right: &str,\n+ ratio_left: &str,\n+ ratio_right: &str,\n+ explanation: &str,\n+) -> String {\n+ serde_json::json!({\n+ \"action\": \"vote_compare_post\",\n+ \"room\": room,\n+ \"thread_tag\": thread_tag,\n+ \"left_item\": left,\n+ \"right_item\": right,\n+ \"ratio_left\": ratio_left,\n+ \"ratio_right\": ratio_right,\n+ \"explanation\": explanation,\n+ \"next\": \"/vote\",\n+ })\n+ .to_string()\n+}\n+\n+#[tokio::test]\n+async fn test_vote_compare_post_rejects_zero_left_ratio() {\n+ let (addr, _tmp, _log, _handle) = create_test_server().await;\n+ let client = reqwest::Client::new();\n+ let bearer = test_bearer();\n+\n+ let rpc = ui_vote_compare_post_rpc(\"public\", \"test-vote\", \"~/a\", \"~/b\", \"0\", \"5\", \"prefer b\");\n+ let resp = client\n+ .post(format!(\"http://{addr}/ui\"))\n+ .header(\"Authorization\", format!(\"Bearer {bearer}\"))\n+ .form(&[(\"__rpc__\", rpc.as_str())])\n+ .send()\n+ .await\n+ .unwrap();\n+\n+ assert_eq!(resp.status(), reqwest::StatusCode::OK);\n+ let js = resp.text().await.unwrap();\n+ assert!(\n+ js.contains(\"invalid ratio\") || js.contains(\"≥ 1\"),\n+ \"expected zero-ratio rejection, got: {js}\"\n+ );\n+}\n+\n+#[tokio::test]\n+async fn test_vote_compare_post_rejects_zero_right_ratio() {\n+ let (addr, _tmp, _log, _handle) = create_test_server().await;\n+ let client = reqwest::Client::new();\n+ let bearer = test_bearer();\n+\n+ let rpc = ui_vote_compare_post_rpc(\"public\", \"test-vote\", \"~/a\", \"~/b\", \"5\", \"0\", \"prefer a\");\n+ let resp = client\n+ .post(format!(\"http://{addr}/ui\"))\n+ .header(\"Authorization\", format!(\"Bearer {bearer}\"))\n+ .form(&[(\"__rpc__\", rpc.as_str())])\n+ .send()\n+ .await\n+ .unwrap();\n+\n+ assert_eq!(resp.status(), reqwest::StatusCode::OK);\n+ let js = resp.text().await.unwrap();\n+ assert!(\n+ js.contains(\"invalid ratio\") || js.contains(\"≥ 1\"),\n+ \"expected zero-ratio rejection, got: {js}\"\n+ );\n+}\n+\n+#[tokio::test]\n+async fn test_vote_compare_post_rejects_over_max_ratio() {\n+ let (addr, _tmp, _log, _handle) = create_test_server().await;\n+ let client = reqwest::Client::new();\n+ let bearer = test_bearer();\n+\n+ let rpc =\n+ ui_vote_compare_post_rpc(\"public\", \"test-vote\", \"~/a\", \"~/b\", \"101\", \"1\", \"prefer a\");\n+ let resp = client\n+ .post(format!(\"http://{addr}/ui\"))\n+ .header(\"Authorization\", format!(\"Bearer {bearer}\"))\n+ .form(&[(\"__rpc__\", rpc.as_str())])\n+ .send()\n+ .await\n+ .unwrap();\n+\n+ assert_eq!(resp.status(), reqwest::StatusCode::OK);\n+ let js = resp.text().await.unwrap();\n+ assert!(\n+ js.contains(\"invalid ratio\") || js.contains(\"≤ 100\"),\n+ \"expected over-max ratio rejection, got: {js}\"\n+ );\n+}\n+\ndiff --git a/test/browser_vote_pool.clj b/test/browser_vote_pool.clj\nindex 23d0bd80b02bd8b1b48853454bed02793296550e..738608801027d1e662660b5d6c830b4ccd07c434 100644\n--- a/test/browser_vote_pool.clj\n+++ b/test/browser_vote_pool.clj\n@@ -38,8 +38,8 @@\n ;; Set the hidden ratio inputs so the alphabetically-earlier item wins.\n (defn- set-ratio! [pg left-text right-text]\n (let [[rl rr] (if (neg? (compare (leaf left-text) (leaf right-text)))\n- [100 0] ; left is earlier → prefer left\n- [0 100])] ; right is earlier → prefer right\n+ [99 1] ; left is earlier → prefer left\n+ [1 99])] ; right is earlier → prefer right\n (page/evaluate pg (str \"document.getElementById('vote-ratio-left').value='\" rl \"'\"))\n (page/evaluate pg (str \"document.getElementById('vote-ratio-right').value='\" rr \"'\"))))\n \n","role":"user"}],"model":"~x-ai/grok-latest"}