{"messages":[{"content":"You are a constitutional council ranking individual git commits for ownership allocation.\n\nCompare these two commits. Decide which contributed more lasting value to the project.\n\nJudge substance, not spectacle:\n- Prefer correct, lasting design and real bugfixes over churn, formatting, renames, or generated noise.\n- Prefer clarity and necessity over sheer line count. A small precise change can beat a large diffuse one.\n- Do not favor a side merely because its patch is longer or noisier.\n- Weight what the change does for the project, not the contributor's name.\n\nReturn ONLY a JSON object: {\"winner\": \"A\" or \"B\", \"ratio\": \"N:M\", \"explanation\": \"...\"}\nThe explanation must cite concrete differences in the patches (1-3 sentences).\n\nSide A — contributor: tommy-mor\nSide A — commit message:\n[0366806e] Color rank rows by vote mass within each group, not list position.\n\nMin–max normalization keeps similar scores visually close while still\nusing the full gradient as groups grow and absolute mass dilutes.\n\nCo-authored-by: Cursor \n\nSide A — unified diff (full patch):\ndiff --git a/server/src/html/mod.rs b/server/src/html/mod.rs\nindex a58cbbee3490a08a625cb06df06848c59a615d65..4eff2e19ed4d303ff8e80c1eabd8a15b4990e643 100644\n--- a/server/src/html/mod.rs\n+++ b/server/src/html/mod.rs\n@@ -264,12 +264,19 @@ pub fn scope_theme_style(parent: &ItemId) -> String {\n )\n }\n \n-fn rank_row_style(parent: &ItemId, ordinal: usize, total: usize) -> String {\n- let t = if total <= 1 {\n- 0.0\n- } else {\n- ordinal as f64 / (total - 1) as f64\n- };\n+/// Map vote mass to gradient position using the group's score range, not raw mass or\n+/// list position. Vote mass sums to 1 across the component, so absolute values dilute\n+/// as N grows; min–max within the visible list preserves similar scores → similar colors.\n+fn score_gradient_t(score: f64, min_score: f64, max_score: f64) -> f64 {\n+ let spread = max_score - min_score;\n+ if spread < 1e-9 {\n+ return 0.5;\n+ }\n+ ((max_score - score) / spread).clamp(0.0, 1.0)\n+}\n+\n+fn rank_row_style(parent: &ItemId, score: f64, min_score: f64, max_score: f64) -> String {\n+ let t = score_gradient_t(score, min_score, max_score);\n let base_hue = scope_base_hue(parent);\n let hue = (base_hue + 118.0 * t) % 360.0;\n let lightness = 0.74 - 0.34 * t;\n@@ -295,14 +302,15 @@ fn rank_list(\n highlighted: &HashSet,\n tree: &GlobalTree,\n ) -> Markup {\n- let group_len = items.len();\n+ let min_score = items.iter().map(|r| r.score).fold(f64::INFINITY, f64::min);\n+ let max_score = items.iter().map(|r| r.score).fold(f64::NEG_INFINITY, f64::max);\n html! {\n @if !items.is_empty() {\n h3 class=\"rank-heading muted small\" { (label) }\n ol class=\"rank-list\" {\n @for (i, r) in items.iter().enumerate() {\n @let href = item_href(&r.item);\n- @let style = rank_row_style(parent, i, group_len);\n+ @let style = rank_row_style(parent, r.score, min_score, max_score);\n @let class = rank_row_class(&r.item, highlighted);\n li class=(class)\n data-rank-item=(r.item.as_str())\n@@ -517,19 +525,37 @@ pub async fn browse(State(state): State, uri: Uri) -> impl IntoRespons\n \n #[cfg(test)]\n mod tests {\n- use super::{rank_row_style, SORTER_UI_JS};\n+ use super::{rank_row_style, score_gradient_t, SORTER_UI_JS};\n use crate::path_types::ItemId;\n \n #[test]\n- fn rank_row_style_gradients_per_group_not_globally() {\n+ fn score_gradient_t_uses_group_range_not_absolute_mass() {\n+ assert!((score_gradient_t(0.12, 0.08, 0.12) - 0.0).abs() < 1e-9);\n+ assert!((score_gradient_t(0.08, 0.08, 0.12) - 1.0).abs() < 1e-9);\n+ // Raw 12% mass would map near the dark end globally; within this group it's the top.\n+ assert!(score_gradient_t(0.12, 0.08, 0.12) < score_gradient_t(0.12, 0.0, 1.0));\n+ }\n+\n+ #[test]\n+ fn score_gradient_t_similar_scores_similar_t() {\n+ let a = score_gradient_t(0.41, 0.20, 0.60);\n+ let b = score_gradient_t(0.40, 0.20, 0.60);\n+ assert!((a - b).abs() < 0.05);\n+ assert!((a - score_gradient_t(0.60, 0.20, 0.60)).abs() > 0.3);\n+ }\n+\n+ #[test]\n+ fn score_gradient_t_tied_scores_neutral() {\n+ assert!((score_gradient_t(0.25, 0.25, 0.25) - 0.5).abs() < 1e-9);\n+ }\n+\n+ #[test]\n+ fn rank_row_style_same_inputs_same_color() {\n let parent = ItemId::opaque(\"test-scope\");\n- let first_in_four = rank_row_style(&parent, 0, 4);\n- let last_in_four = rank_row_style(&parent, 3, 4);\n- let first_in_two = rank_row_style(&parent, 0, 2);\n- let last_in_two = rank_row_style(&parent, 1, 2);\n- assert_eq!(first_in_four, first_in_two);\n- assert_eq!(last_in_four, last_in_two);\n- assert_ne!(first_in_four, last_in_four);\n+ assert_eq!(\n+ rank_row_style(&parent, 0.33, 0.20, 0.60),\n+ rank_row_style(&parent, 0.33, 0.20, 0.60),\n+ );\n }\n \n #[test]\n\n\nSide B — contributor: tommy-mor\nSide B — commit message:\n[993d359c] Fix Reddit children import wiring and unranked child labels.\n\nListing imports attach posts directly under the subreddit without ensure_path\npulling comment-path segments in, and the ranking panel shows imported titles.\nUpdate integration tests for JS SSE morphs and children fetch.\n\nCo-authored-by: Cursor \n\nSide B — unified diff (full patch):\ndiff --git a/server/src/api/ui_html.rs b/server/src/api/ui_html.rs\nindex d1defd28242fd2ca3b886adc91a7070bef75e653..e649a7d192feade465e19ce6187a829f6ec74372 100644\n--- a/server/src/api/ui_html.rs\n+++ b/server/src/api/ui_html.rs\n@@ -58,7 +58,7 @@ pub async fn post_ui_html(\n let tree = state.tree.read().await;\n let empty = crate::reducer::NodeState::default();\n let node = tree.get(&parent).unwrap_or(&empty);\n- let panel = ranking_panel(&parent, node);\n+ let panel = ranking_panel(&parent, node, &tree);\n JsBuilder::new()\n .morph_selector(\"#ranking-panel\", panel)\n .into_response()\ndiff --git a/server/src/fetch/mod.rs b/server/src/fetch/mod.rs\nindex 0177bb161cea1b72a100b52efdfc5e710271c9eb..35f968c21c69ca557bab7951413e3cfbbccfebfd 100644\n--- a/server/src/fetch/mod.rs\n+++ b/server/src/fetch/mod.rs\n@@ -107,7 +107,7 @@ pub fn fetch_entity_stream(\n let mut b = JsBuilder::new()\n .morph_selector(\"#entity-section\", html::entity_section(&id, node, false));\n if kind == FetchKind::Children {\n- b = b.morph_selector(\"#ranking-panel\", ranking_panel(&id, node));\n+ b = b.morph_selector(\"#ranking-panel\", ranking_panel(&id, node, &tree));\n }\n yield Ok(js_event(b.build()));\n }\ndiff --git a/server/src/html/mod.rs b/server/src/html/mod.rs\nindex 27ce9118c73ec5643e04363ab1a36cf5da6101bf..e88cc43ddc9d8100f7994be6f5960ec4d8f22c55 100644\n--- a/server/src/html/mod.rs\n+++ b/server/src/html/mod.rs\n@@ -15,7 +15,7 @@ use crate::{\n ranking::{\n connected_components_from_voted_pairs, ranked_items_subset, RankedItem, MAX_ITERS, TOL,\n },\n- reducer::NodeState,\n+ reducer::{GlobalTree, NodeState},\n state::AppState,\n ui_action::UI_RPC_FIELD,\n };\n@@ -182,8 +182,15 @@ fn display_label(id: &ItemId) -> String {\n .to_string()\n }\n \n+fn child_label(tree: &GlobalTree, id: &ItemId) -> String {\n+ tree.get(id)\n+ .and_then(|n| n.data.as_ref())\n+ .map(|d| d.title.clone())\n+ .unwrap_or_else(|| display_label(id))\n+}\n+\n /// Plain (unscored) list of children that have no votes yet.\n-fn unranked_list(label: &str, items: &[ItemId]) -> Markup {\n+fn unranked_list(label: &str, items: &[ItemId], tree: &GlobalTree) -> Markup {\n html! {\n @if !items.is_empty() {\n h3 class=\"rank-heading muted small\" { (label) }\n@@ -191,7 +198,7 @@ fn unranked_list(label: &str, items: &[ItemId]) -> Markup {\n @for it in items {\n li {\n a href=(item_href(it)) {\n- strong { (display_label(it)) }\n+ strong { (child_label(tree, it)) }\n }\n }\n }\n@@ -200,7 +207,7 @@ fn unranked_list(label: &str, items: &[ItemId]) -> Markup {\n }\n }\n \n-pub fn ranking_panel(item: &ItemId, node: &NodeState) -> Markup {\n+pub fn ranking_panel(item: &ItemId, node: &NodeState, tree: &GlobalTree) -> Markup {\n let group = &node.local_ranking;\n let n = group.idx_to_item.len();\n let (comps, _isolates) =\n@@ -248,7 +255,7 @@ pub fn ranking_panel(item: &ItemId, node: &NodeState) -> Markup {\n @let label = if multi { format!(\"Ranking group {}\", gi + 1) } else { \"Ranking\".to_string() };\n (rank_list(&label, ranked, 1))\n }\n- (unranked_list(\"Unranked\", &unranked))\n+ (unranked_list(\"Unranked\", &unranked, tree))\n }\n }\n }\n@@ -297,7 +304,7 @@ async fn item_page(state: AppState, uri: Uri, item: ItemId) -> Markup {\n (input_panel(\"\", None))\n (breadcrumb_path(&item))\n (entity_section(&item, node, false))\n- (ranking_panel(&item, node))\n+ (ranking_panel(&item, node, &tree))\n };\n layout(\"sorter2\", body, views)\n }\ndiff --git a/server/src/reddit.rs b/server/src/reddit.rs\nindex a0eb688709478ee0185b953b41a5d26cc354764d..69d979bc7e4a1cb078f70114dc539bdc1986b574 100644\n--- a/server/src/reddit.rs\n+++ b/server/src/reddit.rs\n@@ -300,9 +300,16 @@ async fn reddit_worker(\n }\n {\n let mut tree = tree.write().await;\n- apply_entity_import(&mut tree, &child_id, child_payload);\n if kind == FetchKind::Children {\n- tree.link_child(&fetch_id, &child_id);\n+ let view = entity_view_from_payload(&child_id, &child_payload);\n+ tree.apply_entity_under_parent(\n+ &fetch_id,\n+ &child_id,\n+ child_payload,\n+ view,\n+ );\n+ } else {\n+ apply_entity_import(&mut tree, &child_id, child_payload);\n }\n }\n written += 1;\ndiff --git a/server/src/reducer.rs b/server/src/reducer.rs\nindex a36cd5c9287d61536f9f4a3f6b0df2342388857a..4e42d0369dab50bb2f8ca664aa69b628292f6c07 100644\n--- a/server/src/reducer.rs\n+++ b/server/src/reducer.rs\n@@ -209,14 +209,24 @@ impl GlobalTree {\n }\n }\n \n- /// Directly attach `child` under `parent`, bypassing path-based nesting.\n- /// Used for imported listings (e.g. a subreddit's posts) so they show up\n- /// as children of the subreddit rather than a deep `…/comments/` path.\n- pub fn link_child(&mut self, parent: &ItemId, child: &ItemId) {\n+ /// Import entity data for `id` and attach it as a direct child of `parent`\n+ /// without running [`Self::ensure_path`] on `id` (avoids Reddit `/comments/`\n+ /// parent rules pulling intermediate path segments into the subreddit).\n+ pub fn apply_entity_under_parent(\n+ &mut self,\n+ parent: &ItemId,\n+ id: &ItemId,\n+ payload: Value,\n+ view: Option,\n+ ) {\n self.ensure_path(parent);\n- self.ensure_path(child);\n+ self.ensure_node(id);\n+ if let Some(node) = self.nodes.get_mut(id) {\n+ node.entity_raw = Some(payload);\n+ node.data = view;\n+ }\n if let Some(p) = self.nodes.get_mut(parent) {\n- p.children.insert(child.clone());\n+ p.children.insert(id.clone());\n }\n }\n }\ndiff --git a/test/reddit_import.clj b/test/reddit_import.clj\nindex 84cbdcf7965e50290313cbce2243a16b583d2097..45a2a19f20799d77e84d8aa64735ab5e7e45f97c 100644\n--- a/test/reddit_import.clj\n+++ b/test/reddit_import.clj\n@@ -67,6 +67,36 @@\n (do (Thread/sleep 200) (recur))\n false)))))\n \n+(defn- run-reddit-fetch-assertions [app-base data-dir]\n+ (let [browse-url (str app-base \"/~/https://reddit.com/r/rust\")\n+ log-path (str data-dir \"/events.jsonl\")\n+ before (:out (process/shell {:out :string :err :string}\n+ \"curl\" \"-sf\" browse-url))]\n+ (is (str/includes? before \"Fetch from Reddit\"))\n+ (is (not (str/includes? before \"The Rust Programming Language\")))\n+ (let [sse (curl-fetch-ui-sse app-base \"reddit.com/r/rust\" \"self\")]\n+ (is (zero? (:exit sse)) \"POST /ui fetch_entity (self) SSE succeeds\")\n+ (is (str/includes? (:out sse) \"Idiomorph.morph\"))\n+ (is (str/includes? (:out sse) \"The Rust Programming Language\"))\n+ (is (wait-event-log log-path 2000) \"event log written\"))\n+ (let [after (:out (process/shell {:out :string :err :string}\n+ \"curl\" \"-sf\" browse-url))\n+ log (slurp (io/file log-path))]\n+ (is (str/includes? after \"The Rust Programming Language\"))\n+ (is (str/includes? log \"\\\"type\\\":\\\"entity_imported\\\"\"))\n+ (is (str/includes? log \"\\\"subscribers\\\":350000\"))\n+ (is (str/includes? log \"\\\"display_name\\\":\\\"rust\\\"\")))\n+ (let [children-sse (curl-fetch-ui-sse app-base \"reddit.com/r/rust\" \"children\")]\n+ (is (zero? (:exit children-sse)) \"POST /ui fetch_entity (children) SSE succeeds\")\n+ (is (str/includes? (:out children-sse) \"Idiomorph.morph\"))\n+ (is (str/includes? (:out children-sse) \"Announcing Rust 1.99\")))\n+ (let [after-children (:out (process/shell {:out :string :err :string}\n+ \"curl\" \"-sf\" browse-url))\n+ log2 (slurp (io/file log-path))]\n+ (is (str/includes? after-children \"Announcing Rust 1.99\"))\n+ (is (str/includes? after-children \"Unranked\"))\n+ (is (str/includes? log2 \"announcing_rust_199\")))))\n+\n (deftest reddit-fetch-via-mock-api\n (testing \"Fetch more queues import; event log stores full payload; page shows title\"\n (let [root (repo-root)\n@@ -102,24 +132,7 @@\n bin)]\n (try\n (is (wait-health app-base 20000) \"app healthz\")\n- (let [browse-url (str app-base \"/~/https://reddit.com/r/rust\")\n- before (:out (process/shell {:out :string :err :string}\n- \"curl\" \"-sf\" browse-url))]\n- (is (str/includes? before \"Fetch from Reddit\"))\n- (is (not (str/includes? before \"The Rust Programming Language\")))\n- (let [log-path (str data-dir \"/events.jsonl\")\n- sse (curl-fetch-ui-sse app-base \"reddit.com/r/rust\")]\n- (is (zero? (:exit sse)) \"POST /ui fetch_entity SSE succeeds\")\n- (is (str/includes? (:out sse) \"event: complete\"))\n- (is (str/includes? (:out sse) \"The Rust Programming Language\"))\n- (is (wait-event-log log-path 2000) \"event log written\")\n- (let [after (:out (process/shell {:out :string :err :string}\n- \"curl\" \"-sf\" browse-url))\n- log (slurp (io/file log-path))]\n- (is (str/includes? after \"The Rust Programming Language\"))\n- (is (str/includes? log \"\\\"type\\\":\\\"entity_imported\\\"\"))\n- (is (str/includes? log \"\\\"subscribers\\\":350000\"))\n- (is (str/includes? log \"\\\"display_name\\\":\\\"rust\\\"\")))))\n+ (run-reddit-fetch-assertions app-base data-dir)\n (finally\n (process/destroy proc))))\n (finally\ndiff --git a/test/smoke.clj b/test/smoke.clj\nindex 11887c48282088e140d823a88ba616f6325835b3..ce9f958c84b9a89ae55e215ab519f1df6435e24b 100644\n--- a/test/smoke.clj\n+++ b/test/smoke.clj\n@@ -49,7 +49,7 @@\n (is (wait-health base 15000) \"server responds to /healthz\")\n (let [home (:out (process/shell {:out :string :err :string}\n \"curl\" \"-sf\" (str base \"/\")))]\n- (is (str/includes? home \"vote-panel\"))\n+ (is (str/includes? home \"entity-section\"))\n (is (str/includes? home \"ranking-panel\"))\n (is (str/includes? home \"parser-panel\"))\n (is (str/includes? home \"__rpc__\")))\n","role":"user"}],"model":"~x-ai/grok-latest"}