{"messages":[{"content":"You are a constitutional council ranking individual git commits for ownership allocation.\n\nCompare these two commits. Decide which contributed more lasting value to the project.\n\nJudge substance, not spectacle:\n- Prefer correct, lasting design and real bugfixes over churn, formatting, renames, or generated noise.\n- Prefer clarity and necessity over sheer line count. A small precise change can beat a large diffuse one.\n- Do not favor a side merely because its patch is longer or noisier.\n- Weight what the change does for the project, not the contributor's name.\n\nReturn ONLY a JSON object: {\"winner\": \"A\" or \"B\", \"ratio\": \"N:M\", \"explanation\": \"...\"}\nThe explanation must cite concrete differences in the patches (1-3 sentences).\n\nSide A — contributor: tommy-mor\nSide A — commit message:\n[10c9caac] Fix all workspace clippy warnings.\n\nWire up a missing ui_action test, allow dead code in shared integration helpers, and apply small clippy cleanups across server and types.\n\nCo-authored-by: Cursor \n\nSide A — unified diff (full patch):\ndiff --git a/server/src/dsl.rs b/server/src/dsl.rs\nindex a45c5b33e10d0d2ea48c7313061cfa1e6430bcfc..faa8aac6616bc6ea2b102d08ae999c01a716ef6e 100644\n--- a/server/src/dsl.rs\n+++ b/server/src/dsl.rs\n@@ -927,9 +927,7 @@ mod tests {\n #[test]\n fn parse_vote_rejects_zero_zero_ratio() {\n let err = parse_full(\"{tie placeholder}\\n~/a 0:0 ~/b\").unwrap_err();\n- let msg = match err {\n- DslError::Parse(m) => m,\n- };\n+ let DslError::Parse(msg) = err;\n assert!(\n msg.contains(\"0:0\"),\n \"expected 0:0 rejection message, got: {msg}\"\ndiff --git a/server/src/html/garden/tests.rs b/server/src/html/garden/tests.rs\nindex c2036fca7752aef63d260e36cfe9649f63b5c550..0a1be1290fdc93197ca191197a473840bb4decbc 100644\n--- a/server/src/html/garden/tests.rs\n+++ b/server/src/html/garden/tests.rs\n@@ -346,7 +346,7 @@ fn vote_compare_item_card_renders_github_import_markup() {\n \"headline\": \"#1 Compare card\",\n \"sublines\": [\"State: open\"],\n });\n- let body = format!(\"```slug-github-card\\n{}\\n```\", json.to_string());\n+ let body = format!(\"```slug-github-card\\n{json}\\n```\");\n let html = vote_compare_item_card(\n &nav,\n &item,\ndiff --git a/server/src/html/ui_action.rs b/server/src/html/ui_action.rs\nindex 2589a2cc00bb7b18cd19ebcbb938083122d6921d..5e4131dd346a6f80bfe091a9b0cf7902721bc47f 100644\n--- a/server/src/html/ui_action.rs\n+++ b/server/src/html/ui_action.rs\n@@ -246,6 +246,7 @@ mod tests {\n );\n }\n \n+ #[test]\n fn set_new_thread_compose_expanded_true() {\n let template = serde_json::json!({\n \"action\": \"set_new_thread_compose_expanded\",\ndiff --git a/server/src/offline.rs b/server/src/offline.rs\nindex 2db6f67e22e00a24ce673d13095644dd9fa9342d..93d4d5ee55449da644f732bc0ba007ee4c2c7079 100644\n--- a/server/src/offline.rs\n+++ b/server/src/offline.rs\n@@ -167,7 +167,7 @@ fn rankings_for_simulated(\n .iter()\n .map(|parent| {\n let scoped_content = simulated\n- .content_for_scope(&scope)\n+ .content_for_scope(scope)\n .unwrap_or_else(|| simulated.public());\n let scoped = build_children_rankings(scoped_content, parent);\n let components: Vec = scoped\n@@ -254,7 +254,9 @@ fn ingest_parse_error(raw: &str) -> Option {\n dsl::parse_full(raw).err().map(|e| e.to_string())\n }\n \n-fn load_events_from_jsonl(path: &Path) -> Result<(usize, Vec<(usize, Event)>, Vec), std::io::Error> {\n+type JsonlEventsLoad = Result<(usize, Vec<(usize, Event)>, Vec), std::io::Error>;\n+\n+fn load_events_from_jsonl(path: &Path) -> JsonlEventsLoad {\n let text = std::fs::read_to_string(path)?;\n let total_lines = text.lines().count();\n let mut events = Vec::new();\ndiff --git a/server/src/resolvers/github.rs b/server/src/resolvers/github.rs\nindex 30dd4cdac96de0e3da4fa03fdf82f91bed73bfe0..3cec5e8b7249a4597c378890cc9e6125104e76c3 100644\n--- a/server/src/resolvers/github.rs\n+++ b/server/src/resolvers/github.rs\n@@ -749,6 +749,6 @@ mod tests {\n GithubImportKind::Issue,\n );\n assert!(card.sublines.iter().any(|l| l.contains(\"@octo\")));\n- assert_eq!(card.excerpt.as_deref(), Some(\"The issue body.\").as_deref());\n+ assert_eq!(card.excerpt.as_deref(), Some(\"The issue body.\"));\n }\n }\ndiff --git a/server/tests/basic.rs b/server/tests/basic.rs\nindex 31a35251a8abd6f4a48c1d7782b6985f621375e1..9d83e7a97e2c7494790db17c4b5b30c181705026 100644\n--- a/server/tests/basic.rs\n+++ b/server/tests/basic.rs\n@@ -337,7 +337,7 @@ async fn event_log_handles_corrupt_lines() {\n .unwrap();\n \n // Add empty line.\n- writeln!(f, \"\").unwrap();\n+ writeln!(f).unwrap();\n \n let (loaded, bad) = log.load_all().await.unwrap();\n assert_eq!(loaded.len(), 2);\n@@ -511,9 +511,7 @@ fn dsl_parse_rejects_zero_zero_vote_ratio() {\n \"~/t/a {a}\\n~/t/b {b}\\n{zero}\\n~/t/a 0:0 ~/t/b\\n\",\n )\n .expect_err(\"0:0 vote must be rejected by the parser\");\n- let msg = match err {\n- slugsocial_server::dsl::DslError::Parse(m) => m,\n- };\n+ let slugsocial_server::dsl::DslError::Parse(msg) = err;\n assert!(\n msg.contains(\"0:0\"),\n \"expected message about invalid 0:0 ratio, got: {msg}\"\n@@ -904,7 +902,7 @@ fn posts_by_actor_indexes_and_profile_visibility() {\n fn feed_query(state: &ReducerState, cutoff: i64, limit: usize) -> (usize, Vec) {\n let matching: Vec<&str> = state.ingests_ordered.iter().rev()\n .map(|id| id.as_str())\n- .take_while(|id| state.ingests_by_id.get(*id).map_or(false, |ing| ing.ts > cutoff))\n+ .take_while(|id| state.ingests_by_id.get(*id).is_some_and(|ing| ing.ts > cutoff))\n .filter(|id| {\n state.ingests_by_id.get(*id).is_some_and(|ing| {\n let scope = slugsocial_server::reducer::scope_from_room_wire(&ing.room_id);\ndiff --git a/server/tests/integration_health.rs b/server/tests/integration_health.rs\nindex 481222d8c48c44fcfb7e9ba26cf7644b5c26d5f4..351aae6b0e9738021886a076ee08fab5cf5a0001 100644\n--- a/server/tests/integration_health.rs\n+++ b/server/tests/integration_health.rs\n@@ -7,7 +7,7 @@ async fn test_healthz() {\n let (addr, _tmp, _log, _handle) = create_test_server().await;\n let client = reqwest::Client::new();\n let response = client\n- .get(&format!(\"http://{}/healthz\", addr))\n+ .get(format!(\"http://{}/healthz\", addr))\n .send()\n .await\n .unwrap();\ndiff --git a/server/tests/integration_rpc.rs b/server/tests/integration_rpc.rs\nindex ccd89a02594bd2a8e7047edafca04b0e54384139..ec446d94a38c8d6961d2135dd031da7ab2a39b48 100644\n--- a/server/tests/integration_rpc.rs\n+++ b/server/tests/integration_rpc.rs\n@@ -440,7 +440,6 @@ async fn test_rank_history() {\n let bearer = test_bearer();\n let ingest = |delegate: &str, text: &str| {\n let client = client.clone();\n- let addr = addr;\n let bearer = bearer.clone();\n let text = text.to_string();\n let delegate = delegate.to_string();\ndiff --git a/server/tests/support/mod.rs b/server/tests/support/mod.rs\nindex 84dc1d68b6c1e1fdfdbd0757139c06c3daf1e9a6..4a620eaa875e7a1145f2a4e82cc4ff2be21d5345 100644\n--- a/server/tests/support/mod.rs\n+++ b/server/tests/support/mod.rs\n@@ -1,3 +1,6 @@\n+//! Shared helpers for integration tests; each test binary uses a different subset.\n+#![allow(dead_code)]\n+\n use sha2::{Digest, Sha256};\n use slugsocial_server::{\n event_log::EventLog,\ndiff --git a/types/src/paths.rs b/types/src/paths.rs\nindex ebc299c5e1af456c3e4b7fa45ed9fb23313e88c4..d2e799942b98dd7342764475deb17903fb60c600 100644\n--- a/types/src/paths.rs\n+++ b/types/src/paths.rs\n@@ -411,7 +411,7 @@ mod tests {\n #[test]\n fn garden_item_url_deref_to_str() {\n let g = GardenItemUrl::from_storage_str(\"https://slug.social/~/x\", \"public\");\n- let s: &str = &*g;\n+ let s: &str = &g;\n assert_eq!(s, \"https://slug.social/~/x\");\n }\n \n\n\nSide B — contributor: tommy-mor\nSide B — commit message:\n[432e1450] nice\n\nSide B — unified diff (full patch):\ndiff --git a/reddit.rs b/reddit.rs\nnew file mode 100644\nindex 0000000000000000000000000000000000000000..da27f6f76482dd27d44cad9d7b844972bf042e64\n--- /dev/null\n+++ b/reddit.rs\n@@ -0,0 +1,420 @@\n+use governor::{Quota, RateLimiter, Jitter};\n+use nonzero_ext::nonzero;\n+use reqwest::{Client, StatusCode};\n+use serde::{Deserialize, Serialize};\n+use std::sync::Arc;\n+use std::time::Duration;\n+use anyhow::{Result, Context, anyhow};\n+\n+/// Reddit API client with built-in rate limiting\n+pub struct RedditClient {\n+ client: Client,\n+ limiter: Arc,\n+ user_agent: String,\n+}\n+\n+impl RedditClient {\n+ /// Create a new Reddit client with rate limiting\n+ /// Reddit API allows 60 requests per minute for OAuth2 authenticated apps\n+ /// We'll be conservative and use 50 requests per minute\n+ pub fn new() -> Self {\n+ // Create rate limiter: 50 requests per minute\n+ let quota = Quota::per_minute(nonzero!(50u32));\n+ let limiter = Arc::new(RateLimiter::direct(quota));\n+ \n+ // Create HTTP client with timeout\n+ let client = Client::builder()\n+ .timeout(Duration::from_secs(30))\n+ .build()\n+ .expect(\"Failed to create HTTP client\");\n+ \n+ // Reddit requires a unique user agent\n+ let user_agent = format!(\n+ \"rust:sorter:v{} (by /u/hourLong_arnould)\",\n+ env!(\"CARGO_PKG_VERSION\")\n+ );\n+ \n+ Self {\n+ client,\n+ limiter,\n+ user_agent,\n+ }\n+ }\n+ \n+ /// Fetch hot posts from a subreddit\n+ pub async fn get_subreddit_hot(&self, subreddit: &str, limit: usize) -> Result {\n+ // Wait for rate limiter\n+ self.limiter.until_ready_with_jitter(Jitter::up_to(Duration::from_millis(100))).await;\n+ \n+ let url = format!(\"https://www.reddit.com/r/{}/hot.json?limit={}\", subreddit, limit);\n+ \n+ let response = self.client\n+ .get(&url)\n+ .header(\"User-Agent\", &self.user_agent)\n+ .send()\n+ .await\n+ .context(\"Failed to send request to Reddit\")?;\n+ \n+ self.handle_response(response).await\n+ }\n+ \n+ /// Fetch top posts from a subreddit\n+ pub async fn get_subreddit_top(&self, subreddit: &str, limit: usize, time_period: &str) -> Result {\n+ self.limiter.until_ready_with_jitter(Jitter::up_to(Duration::from_millis(100))).await;\n+ \n+ let url = format!(\n+ \"https://www.reddit.com/r/{}/top.json?limit={}&t={}\",\n+ subreddit, limit, time_period\n+ );\n+ \n+ let response = self.client\n+ .get(&url)\n+ .header(\"User-Agent\", &self.user_agent)\n+ .send()\n+ .await\n+ .context(\"Failed to send request to Reddit\")?;\n+ \n+ self.handle_response(response).await\n+ }\n+ \n+ /// Fetch new posts from a subreddit\n+ pub async fn get_subreddit_new(&self, subreddit: &str, limit: usize) -> Result {\n+ self.limiter.until_ready_with_jitter(Jitter::up_to(Duration::from_millis(100))).await;\n+ \n+ let url = format!(\"https://www.reddit.com/r/{}/new.json?limit={}\", subreddit, limit);\n+ \n+ let response = self.client\n+ .get(&url)\n+ .header(\"User-Agent\", &self.user_agent)\n+ .send()\n+ .await\n+ .context(\"Failed to send request to Reddit\")?;\n+ \n+ self.handle_response(response).await\n+ }\n+ \n+ /// Fetch a specific post and its comments\n+ pub async fn get_post(&self, subreddit: &str, post_id: &str) -> Result> {\n+ self.limiter.until_ready_with_jitter(Jitter::up_to(Duration::from_millis(100))).await;\n+ \n+ let url = format!(\n+ \"https://www.reddit.com/r/{}/comments/{}.json\",\n+ subreddit, post_id\n+ );\n+ \n+ let response = self.client\n+ .get(&url)\n+ .header(\"User-Agent\", &self.user_agent)\n+ .send()\n+ .await\n+ .context(\"Failed to send request to Reddit\")?;\n+ \n+ match response.status() {\n+ StatusCode::OK => {\n+ let listings: Vec = response\n+ .json()\n+ .await\n+ .context(\"Failed to parse Reddit response\")?;\n+ Ok(listings)\n+ }\n+ StatusCode::TOO_MANY_REQUESTS => {\n+ Err(anyhow!(\"Reddit rate limit exceeded. Please try again later.\"))\n+ }\n+ StatusCode::NOT_FOUND => {\n+ Err(anyhow!(\"Post not found: r/{}/comments/{}\", subreddit, post_id))\n+ }\n+ status => {\n+ Err(anyhow!(\"Reddit API error: {}\", status))\n+ }\n+ }\n+ }\n+ \n+ /// Fetch user profile (posts and comments)\n+ pub async fn get_user_profile(&self, username: &str, content_type: &str, limit: usize) -> Result {\n+ self.limiter.until_ready_with_jitter(Jitter::up_to(Duration::from_millis(100))).await;\n+ \n+ let url = format!(\n+ \"https://www.reddit.com/user/{}/{}.json?limit={}\",\n+ username, content_type, limit\n+ );\n+ \n+ let response = self.client\n+ .get(&url)\n+ .header(\"User-Agent\", &self.user_agent)\n+ .send()\n+ .await\n+ .context(\"Failed to send request to Reddit\")?;\n+ \n+ self.handle_response(response).await\n+ }\n+ \n+ /// Handle Reddit API response with proper error checking\n+ async fn handle_response(&self, response: reqwest::Response) -> Result {\n+ match response.status() {\n+ StatusCode::OK => {\n+ let listing: RedditListingResponse = response\n+ .json()\n+ .await\n+ .context(\"Failed to parse Reddit response\")?;\n+ Ok(listing)\n+ }\n+ StatusCode::TOO_MANY_REQUESTS => {\n+ Err(anyhow!(\"Reddit rate limit exceeded. Please try again later.\"))\n+ }\n+ StatusCode::NOT_FOUND => {\n+ Err(anyhow!(\"Reddit resource not found\"))\n+ }\n+ StatusCode::FORBIDDEN => {\n+ Err(anyhow!(\"Access forbidden. The subreddit may be private.\"))\n+ }\n+ status => {\n+ Err(anyhow!(\"Reddit API error: {}\", status))\n+ }\n+ }\n+ }\n+}\n+\n+// Reddit API response types\n+#[derive(Debug, Clone, Serialize, Deserialize)]\n+pub struct RedditListingResponse {\n+ pub kind: String,\n+ pub data: RedditListingData,\n+}\n+\n+#[derive(Debug, Clone, Serialize, Deserialize)]\n+pub struct RedditListingData {\n+ #[serde(skip_serializing_if = \"Option::is_none\")]\n+ pub after: Option,\n+ #[serde(skip_serializing_if = \"Option::is_none\")]\n+ pub before: Option,\n+ pub children: Vec,\n+ #[serde(skip_serializing_if = \"Option::is_none\")]\n+ pub modhash: Option,\n+}\n+\n+#[derive(Debug, Clone, Serialize, Deserialize)]\n+pub struct RedditThing {\n+ pub kind: String,\n+ pub data: RedditThingData,\n+}\n+\n+/// Reddit's \"Thing\" data can be either a post, comment, or other types\n+/// We use untagged enum to handle different data structures\n+#[derive(Debug, Clone, Serialize, Deserialize)]\n+#[serde(untagged)]\n+pub enum RedditThingData {\n+ Post(RedditPost),\n+ Comment(RedditComment),\n+ // For things we don't care about yet (like \"more\" comments)\n+ Other(serde_json::Value),\n+}\n+\n+/// Reddit post data with serde handling all the parsing\n+#[derive(Debug, Clone, Serialize, Deserialize)]\n+pub struct RedditPost {\n+ pub id: String,\n+ pub name: String, // Full name (t3_xxx)\n+ #[serde(default = \"default_untitled\")]\n+ pub title: String,\n+ #[serde(default = \"default_deleted_user\")]\n+ pub author: String,\n+ pub subreddit: String,\n+ #[serde(default)]\n+ pub url: String,\n+ #[serde(default)]\n+ pub permalink: String,\n+ #[serde(default, deserialize_with = \"deserialize_selftext\")]\n+ pub selftext: Option,\n+ #[serde(default)]\n+ pub score: i64,\n+ #[serde(default)]\n+ pub num_comments: i64,\n+ #[serde(default)]\n+ pub created_utc: f64,\n+ #[serde(default, deserialize_with = \"deserialize_thumbnail\")]\n+ pub thumbnail: Option,\n+ #[serde(default)]\n+ pub is_video: bool,\n+ #[serde(default)]\n+ pub is_self: bool,\n+ // Additional useful fields\n+ #[serde(default)]\n+ pub ups: i64,\n+ #[serde(default)]\n+ pub downs: i64,\n+ #[serde(default)]\n+ pub upvote_ratio: f64,\n+ #[serde(default)]\n+ pub over_18: bool,\n+ #[serde(default)]\n+ pub spoiler: bool,\n+ #[serde(default)]\n+ pub stickied: bool,\n+ #[serde(default)]\n+ pub locked: bool,\n+ #[serde(default)]\n+ pub distinguished: Option,\n+}\n+\n+/// Reddit comment data\n+#[derive(Debug, Clone, Serialize, Deserialize)]\n+pub struct RedditComment {\n+ pub id: String,\n+ pub name: String, // Full name (t1_xxx)\n+ #[serde(default = \"default_deleted_user\")]\n+ pub author: String,\n+ #[serde(default)]\n+ pub body: String,\n+ #[serde(default)]\n+ pub score: i64,\n+ #[serde(default)]\n+ pub created_utc: f64,\n+ #[serde(default)]\n+ pub parent_id: String,\n+ #[serde(default)]\n+ pub permalink: String,\n+ #[serde(default)]\n+ pub depth: i32,\n+ // Additional useful fields\n+ #[serde(default)]\n+ pub ups: i64,\n+ #[serde(default)]\n+ pub downs: i64,\n+ #[serde(default)]\n+ pub edited: RedditEditStatus,\n+ #[serde(default)]\n+ pub stickied: bool,\n+ #[serde(default)]\n+ pub distinguished: Option,\n+ #[serde(default)]\n+ pub is_submitter: bool,\n+ #[serde(default)]\n+ pub collapsed: bool,\n+ #[serde(default)]\n+ pub controversiality: i32,\n+}\n+\n+/// Reddit's edit status - can be false or a timestamp\n+#[derive(Debug, Clone, Serialize, Deserialize)]\n+#[serde(untagged)]\n+pub enum RedditEditStatus {\n+ NotEdited(bool),\n+ EditedAt(f64),\n+}\n+\n+impl Default for RedditEditStatus {\n+ fn default() -> Self {\n+ RedditEditStatus::NotEdited(false)\n+ }\n+}\n+\n+// Helper functions for serde defaults\n+fn default_untitled() -> String {\n+ \"Untitled\".to_string()\n+}\n+\n+fn default_deleted_user() -> String {\n+ \"[deleted]\".to_string()\n+}\n+\n+// Custom deserializer for selftext (empty strings should be None)\n+fn deserialize_selftext<'de, D>(deserializer: D) -> Result, D::Error>\n+where\n+ D: serde::Deserializer<'de>,\n+{\n+ let s: Option = Option::deserialize(deserializer)?;\n+ Ok(s.filter(|text| !text.is_empty()))\n+}\n+\n+// Custom deserializer for thumbnail (filter out \"self\", \"default\", empty)\n+fn deserialize_thumbnail<'de, D>(deserializer: D) -> Result, D::Error>\n+where\n+ D: serde::Deserializer<'de>,\n+{\n+ let s: Option = Option::deserialize(deserializer)?;\n+ Ok(s.filter(|thumb| {\n+ !thumb.is_empty() && thumb != \"self\" && thumb != \"default\" && thumb != \"nsfw\" && thumb != \"spoiler\"\n+ }))\n+}\n+\n+// Helper methods for extracting typed data from Things\n+impl RedditThing {\n+ /// Try to get this Thing as a Post\n+ pub fn as_post(&self) -> Option<&RedditPost> {\n+ if self.kind != \"t3\" {\n+ return None;\n+ }\n+ match &self.data {\n+ RedditThingData::Post(post) => Some(post),\n+ _ => None,\n+ }\n+ }\n+ \n+ /// Try to get this Thing as a Comment\n+ pub fn as_comment(&self) -> Option<&RedditComment> {\n+ if self.kind != \"t1\" {\n+ return None;\n+ }\n+ match &self.data {\n+ RedditThingData::Comment(comment) => Some(comment),\n+ _ => None,\n+ }\n+ }\n+ \n+ /// Check if this is a \"more comments\" indicator\n+ pub fn is_more_comments(&self) -> bool {\n+ self.kind == \"more\"\n+ }\n+}\n+\n+// Helper methods for working with listing responses\n+impl RedditListingResponse {\n+ /// Extract all posts from this listing\n+ pub fn get_posts(&self) -> Vec<&RedditPost> {\n+ self.data.children.iter()\n+ .filter_map(|thing| thing.as_post())\n+ .collect()\n+ }\n+ \n+ /// Extract all comments from this listing\n+ pub fn get_comments(&self) -> Vec<&RedditComment> {\n+ self.data.children.iter()\n+ .filter_map(|thing| thing.as_comment())\n+ .collect()\n+ }\n+ \n+ /// Extract posts as owned values\n+ pub fn into_posts(self) -> Vec {\n+ self.data.children.into_iter()\n+ .filter_map(|thing| {\n+ if thing.kind == \"t3\" {\n+ match thing.data {\n+ RedditThingData::Post(post) => Some(post),\n+ _ => None,\n+ }\n+ } else {\n+ None\n+ }\n+ })\n+ .collect()\n+ }\n+ \n+ /// Extract comments as owned values\n+ pub fn into_comments(self) -> Vec {\n+ self.data.children.into_iter()\n+ .filter_map(|thing| {\n+ if thing.kind == \"t1\" {\n+ match thing.data {\n+ RedditThingData::Comment(comment) => Some(comment),\n+ _ => None,\n+ }\n+ } else {\n+ None\n+ }\n+ })\n+ .collect()\n+ }\n+}\n+\n+\n+\n","role":"user"}],"model":"openai/gpt-chat-latest"}