{"messages":[{"content":"You are a constitutional council ranking individual git commits for ownership allocation.\n\nCompare these two commits. Decide which contributed more lasting value to the project.\n\nJudge substance, not spectacle:\n- Prefer correct, lasting design and real bugfixes over churn, formatting, renames, or generated noise.\n- Prefer clarity and necessity over sheer line count. A small precise change can beat a large diffuse one.\n- Do not favor a side merely because its patch is longer or noisier.\n- Weight what the change does for the project, not the contributor's name.\n\nReturn ONLY a JSON object: {\"winner\": \"A\" or \"B\", \"ratio\": \"N:M\", \"explanation\": \"...\"}\nThe explanation must cite concrete differences in the patches (1-3 sentences).\n\nSide A — contributor: tommy-mor\nSide A — commit message:\n[047b82bd] Remove redundant zero-ratio guard from reducer.\n\nZeros are already rejected at the DSL parser and browser handler;\nthe guard in apply_vote was dead code. The negative clamping stays\nsince add_edge_weight already skips weight-0 edges correctly.\n\nCo-Authored-By: Claude Sonnet 4.6 \n\nSide A — unified diff (full patch):\ndiff --git a/server/src/reducer.rs b/server/src/reducer.rs\nindex 0e36979abe0f051493038ff7e652efc7f7a0ac80..efbf7f67ff24c7a2989102fe62879b2794a27c5f 100644\n--- a/server/src/reducer.rs\n+++ b/server/src/reducer.rs\n@@ -112,11 +112,6 @@ impl GroupState {\n if vote.ratio_right < 0 {\n vote.ratio_right = 0;\n }\n- if vote.ratio_left == 0 || vote.ratio_right == 0 {\n- // Zero on either side produces no valid edge; drop before registering items or pair.\n- return;\n- }\n-\n let a_idx = self.ensure_item(&vote.a);\n let b_idx = self.ensure_item(&vote.b);\n \ndiff --git a/server/tests/basic.rs b/server/tests/basic.rs\nindex 08159f4a7f0850fd165817a4a1af4f31ced2ad76..1748769ccf7196b2d81cf556d5368c7e723f6a4e 100644\n--- a/server/tests/basic.rs\n+++ b/server/tests/basic.rs\n@@ -533,7 +533,7 @@ fn dsl_parse_rejects_zero_zero_vote_ratio() {\n #[test]\n fn reducer_negative_ratio_clamped_to_zero() {\n let _state = ReducerState::default();\n- // GroupState::apply_vote clamps negatives to 0; when either side is 0 the vote is dropped.\n+ // apply_vote clamps negatives to 0; add_edge_weight skips zero-weight edges.\n let mut group = GroupState::new();\n group.apply_vote(slugsocial_server::reducer::VoteData {\n ts: 1,\n@@ -546,10 +546,9 @@ fn reducer_negative_ratio_clamped_to_zero() {\n delegate: Some(\"00000000-0000-0000-0000-000000000000:test:local/test\".to_string()),\n thread_tag: \"t\".to_string(),\n });\n- // Nothing registered: zero-clamped vote is dropped before ensure_item.\n- assert!(group.idx_to_item.is_empty());\n+ // Items and pair are registered; edges are absent because weight 0 is skipped.\n+ assert_eq!(group.idx_to_item.len(), 2);\n assert!(group.edges.is_empty());\n- assert!(group.voted_pairs.is_empty());\n }\n \n \n\n\nSide B — contributor: tommy-mor\nSide B — commit message:\n[04b81f91] Fix vote compare highlighting\n\nCo-authored-by: Cursor \n\nSide B — unified diff (full patch):\ndiff --git a/server/src/html/mod.rs b/server/src/html/mod.rs\nindex 588cf62bcea608ed4ede363810f022a67b43b960..e180a0ca542a33e2300c0a4809e6b9cfee07ecfe 100644\n--- a/server/src/html/mod.rs\n+++ b/server/src/html/mod.rs\n@@ -291,18 +291,17 @@ fn rank_list(\n label: &str,\n items: &[RankedItem],\n start_rank: usize,\n- total_ranked: usize,\n- ordinal_offset: usize,\n highlighted: &HashSet,\n tree: &GlobalTree,\n ) -> Markup {\n+ let group_len = items.len();\n html! {\n @if !items.is_empty() {\n h3 class=\"rank-heading muted small\" { (label) }\n ol class=\"rank-list\" {\n @for (i, r) in items.iter().enumerate() {\n @let href = item_href(&r.item);\n- @let style = rank_row_style(parent, ordinal_offset + i, total_ranked);\n+ @let style = rank_row_style(parent, i, group_len);\n @let class = rank_row_class(&r.item, highlighted);\n li class=(class)\n data-rank-item=(r.item.as_str())\n@@ -420,8 +419,6 @@ pub fn ranking_panel_with_highlights(\n \n let has_ranked = !ranked_groups.is_empty();\n let multi = ranked_groups.len() > 1;\n- let total_ranked: usize = ranked_groups.iter().map(|g| g.len()).sum();\n- let mut ordinal_offset = 0usize;\n \n html! {\n section id=\"ranking-panel\" class=\"demo-panel\" {\n@@ -436,8 +433,7 @@ pub fn ranking_panel_with_highlights(\n } @else {\n @for (gi, ranked) in ranked_groups.iter().enumerate() {\n @let label = if multi { format!(\"Ranking group {}\", gi + 1) } else { \"Ranking\".to_string() };\n- (rank_list(item, &label, ranked, 1, total_ranked, ordinal_offset, highlighted, tree))\n- @let _ = { ordinal_offset += ranked.len(); };\n+ (rank_list(item, &label, ranked, 1, highlighted, tree))\n }\n (unranked_list(\"Unranked\", &unranked, highlighted, tree))\n }\n@@ -520,7 +516,20 @@ pub async fn browse(State(state): State, uri: Uri) -> impl IntoRespons\n \n #[cfg(test)]\n mod tests {\n- use super::SORTER_UI_JS;\n+ use super::{rank_row_style, SORTER_UI_JS};\n+ use crate::path_types::ItemId;\n+\n+ #[test]\n+ fn rank_row_style_gradients_per_group_not_globally() {\n+ let parent = ItemId::opaque(\"test-scope\");\n+ let first_in_four = rank_row_style(&parent, 0, 4);\n+ let last_in_four = rank_row_style(&parent, 3, 4);\n+ let first_in_two = rank_row_style(&parent, 0, 2);\n+ let last_in_two = rank_row_style(&parent, 1, 2);\n+ assert_eq!(first_in_four, first_in_two);\n+ assert_eq!(last_in_four, last_in_two);\n+ assert_ne!(first_in_four, last_in_four);\n+ }\n \n #[test]\n fn vote_slider_left_position_favors_left_item() {\ndiff --git a/server/src/html/vote.rs b/server/src/html/vote.rs\nindex 483c7ff8cd35266744957cf0087f2b5f76f1a237..30dab303b9d1e763a5b9261dffff13a778e3e4e3 100644\n--- a/server/src/html/vote.rs\n+++ b/server/src/html/vote.rs\n@@ -19,7 +19,7 @@ use crate::{\n ui_action::UI_RPC_FIELD,\n };\n \n-use super::{breadcrumb_path, item_href, layout};\n+use super::{breadcrumb_path, layout};\n \n #[derive(Debug, Deserialize)]\n pub struct VoteQuery {\n@@ -59,17 +59,6 @@ fn child_title(tree: &GlobalTree, id: &ItemId) -> String {\n .unwrap_or_else(|| display_label(id))\n }\n \n-fn ratio_pct(ratio_left: i32, ratio_right: i32) -> f64 {\n- let l = ratio_left.max(0) as f64;\n- let r = ratio_right.max(0) as f64;\n- let sum = l + r;\n- if sum <= 0.0 {\n- 50.0\n- } else {\n- (l / sum) * 100.0\n- }\n-}\n-\n fn ratios_for_page(v: &VoteData, page_left: &ItemId, page_right: &ItemId) -> (i32, i32) {\n match (v.a.as_str(), v.b.as_str()) {\n (a, b) if a == page_left.as_str() && b == page_right.as_str() => {\n@@ -94,6 +83,37 @@ fn edge_votes(group: &GroupState, left: &ItemId, right: &ItemId) -> Vec &'static str {\n+ if r_left > r_right {\n+ \"left\"\n+ } else if r_right > r_left {\n+ \"right\"\n+ } else {\n+ \"even\"\n+ }\n+}\n+\n+fn winner_text(r_left: i32, r_right: i32) -> &'static str {\n+ match winner_side(r_left, r_right) {\n+ \"left\" => \"left wins\",\n+ \"right\" => \"right wins\",\n+ _ => \"tie\",\n+ }\n+}\n+\n+/// Map stored ratios to the live slider position (0 = full left, 100 = full right).\n+/// Matches `sorter_ui.js`: `left = 100 - v`, `right = v`.\n+fn slider_value_from_ratios(r_left: i32, r_right: i32) -> i32 {\n+ let l = r_left.max(0) as f64;\n+ let r = r_right.max(0) as f64;\n+ let sum = l + r;\n+ if sum <= 0.0 {\n+ return 50;\n+ }\n+ ((r / sum) * 100.0).round().clamp(0.0, 100.0) as i32\n+}\n+\n fn vote_edge_history(tree: &GlobalTree, group: &GroupState, left: &ItemId, right: &ItemId) -> Markup {\n let mut votes = edge_votes(group, left, right);\n votes.sort_by(|a, b| b.ts.cmp(&a.ts));\n@@ -106,17 +126,26 @@ fn vote_edge_history(tree: &GlobalTree, group: &GroupState, left: &ItemId, right\n h3 class=\"vote-edge-history-title\" {\n \"votes on this pair\"\n }\n+ p class=\"muted small vote-edge-legend\" {\n+ (format!(\"left: {legend_left} — right: {legend_right}\"))\n+ }\n ul class=\"vote-edge-history\" {\n @for v in &votes {\n @let (r_left, r_right) = ratios_for_page(v, left, right);\n- @let pct = ratio_pct(r_left, r_right);\n+ @let slider_val = slider_value_from_ratios(r_left, r_right);\n+ @let side = winner_side(r_left, r_right);\n+ @let label = winner_text(r_left, r_right);\n li class=\"vote-edge-history-row\" {\n div class=\"vote-edge-meta\" {\n span class=\"vote-edge-ratio\" { (format!(\"{}:{}\", r_left, r_right)) }\n+ span class=\"vote-edge-winner muted small\" { \" · \" (label) }\n }\n- div class=\"ratio-bar vote-edge-bar\" aria-hidden=\"true\" {\n- div class=\"ratio-left\" style={(format!(\"width: {:.3}%;\", pct))} {}\n- div class=\"ratio-right\" style={(format!(\"width: {:.3}%;\", 100.0 - pct))} {}\n+ label class=\"vote-hud-slider vote-edge-slider\" aria-hidden=\"true\" {\n+ input type=\"range\" class=\"vote-edge-range\" min=\"0\" max=\"100\" value=(slider_val)\n+ data-winner=(side)\n+ style={(format!(\"--vote-slider-pct: {}%;\", slider_val))}\n+ disabled\n+ tabindex=\"-1\";\n }\n }\n }\n@@ -283,7 +312,6 @@ pub async fn vote_page(\n span class=\"vote-compare-vs\" { \"vs\" }\n (vote_compare_item_card(&tree, &right, \"vote-compare-right\"))\n }\n- (vote_back_nav(&parent))\n div id=\"vote-edge-history-region\" {\n (edge_history)\n }\n@@ -308,3 +336,66 @@ pub async fn vote_page(\n )\n .into_response()\n }\n+\n+#[cfg(test)]\n+mod polarity_tests {\n+ use super::*;\n+ use crate::ranking::ranked_items;\n+ use crate::reducer::GlobalTree;\n+\n+ fn id(s: &str) -> ItemId {\n+ ItemId::parse(s).unwrap()\n+ }\n+\n+ /// The page's left number must always equal the vote's weight for the\n+ /// item shown on the left, regardless of which order the vote stored a/b.\n+ #[test]\n+ fn ratios_for_page_orients_to_page_left() {\n+ let left = id(\"left_item\");\n+ let right = id(\"right_item\");\n+\n+ // Stored a == page left: keep order.\n+ let v1 = VoteData::from_recorded(1, left.as_str(), right.as_str(), 9, 1).unwrap();\n+ assert_eq!(ratios_for_page(&v1, &left, &right), (9, 1));\n+\n+ // Stored a == page right: swap so left stays left.\n+ let v2 = VoteData::from_recorded(2, right.as_str(), left.as_str(), 9, 1).unwrap();\n+ assert_eq!(ratios_for_page(&v2, &left, &right), (1, 9));\n+ }\n+\n+ #[test]\n+ fn winner_side_follows_larger_ratio() {\n+ assert_eq!(winner_side(9, 1), \"left\");\n+ assert_eq!(winner_side(1, 9), \"right\");\n+ assert_eq!(winner_side(1, 1), \"even\");\n+ }\n+\n+ #[test]\n+ fn slider_value_matches_hud_mapping() {\n+ assert_eq!(slider_value_from_ratios(9, 1), 10);\n+ assert_eq!(slider_value_from_ratios(1, 4), 80);\n+ assert_eq!(slider_value_from_ratios(1, 1), 50);\n+ }\n+\n+ /// End-to-end polarity invariant: a vote that favours the LEFT item (higher\n+ /// `ratio_left`, recorded as the RPC's `a`) must make that item rank #1.\n+ /// This is the property the UI must preserve: sliding left => left wins.\n+ #[test]\n+ fn sliding_left_makes_left_item_win_ranking() {\n+ let parent = id(\"scope\");\n+ let left = id(\"left_item\");\n+ let right = id(\"right_item\");\n+\n+ // Slider dragged left yields e.g. 9:1 with a = left item.\n+ let vote = VoteData::from_recorded(1, left.as_str(), right.as_str(), 9, 1).unwrap();\n+ let mut tree = GlobalTree::new();\n+ tree.apply_vote(&parent, vote);\n+\n+ let group = &tree.get(&parent).unwrap().local_ranking;\n+ let ranked = ranked_items(group);\n+ assert_eq!(\n+ ranked[0].item, left,\n+ \"left item should rank first when ratio favours the left\"\n+ );\n+ }\n+}\ndiff --git a/server/static/sorter.css b/server/static/sorter.css\nindex 5da967e8bfddc2bc34662fced841860f63f1ef36..bdd3d931365703705be08537a07f3ccaf975d3ea 100644\n--- a/server/static/sorter.css\n+++ b/server/static/sorter.css\n@@ -124,7 +124,7 @@ code {\n z-index: 1;\n box-shadow:\n inset 0 0 0 3px var(--accent),\n- inset 0 0 0 5px color-mix(in oklch, var(--rank-fg) 70%, transparent);\n+ inset 0 0 0 5px color-mix(in oklch, var(--rank-fg, var(--fg)) 70%, transparent);\n filter: saturate(1.15) brightness(1.04);\n }\n \n@@ -320,7 +320,7 @@ h1 {\n grid-template-columns: var(--vote-ratio-col) minmax(0, 1fr) var(--vote-actions-col);\n gap: 0.5rem 0.65rem;\n align-items: center;\n- --vote-ratio-col: 3.25rem;\n+ --vote-ratio-col: 12.5rem;\n --vote-actions-col: 11.5rem;\n }\n \n@@ -332,7 +332,7 @@ h1 {\n margin: 0;\n width: var(--vote-ratio-col);\n min-width: var(--vote-ratio-col);\n- text-align: center;\n+ text-align: right;\n white-space: nowrap;\n }\n \n@@ -474,6 +474,16 @@ h1 {\n --vote-track-muted: color-mix(in oklch, var(--muted) 55%, var(--bg));\n }\n \n+/* Center-anchored fill: the accent grows from the midpoint toward the thumb,\n+ so the highlighted mass always sits on the *winning* side (the side the\n+ thumb was dragged toward). Left winning => accent on the left half. */\n+.vote-hud-slider input[type=\"range\"][data-winner=\"even\"]::-webkit-slider-runnable-track {\n+ height: 0.65rem;\n+ border-radius: 0;\n+ border: 2px solid var(--border);\n+ background: var(--vote-track-muted);\n+}\n+\n .vote-hud-slider input[type=\"range\"][data-winner=\"left\"]::-webkit-slider-runnable-track {\n height: 0.65rem;\n border-radius: 0;\n@@ -483,7 +493,9 @@ h1 {\n var(--vote-track-muted) 0%,\n var(--vote-track-muted) var(--vote-slider-pct, 50%),\n var(--accent) var(--vote-slider-pct, 50%),\n- var(--accent) 100%\n+ var(--accent) 50%,\n+ var(--vote-track-muted) 50%,\n+ var(--vote-track-muted) 100%\n );\n }\n \n@@ -493,7 +505,9 @@ h1 {\n border: 2px solid var(--border);\n background: linear-gradient(\n to right,\n- var(--accent) 0%,\n+ var(--vote-track-muted) 0%,\n+ var(--vote-track-muted) 50%,\n+ var(--accent) 50%,\n var(--accent) var(--vote-slider-pct, 50%),\n var(--vote-track-muted) var(--vote-slider-pct, 50%),\n var(--vote-track-muted) 100%\n@@ -513,26 +527,35 @@ h1 {\n }\n \n .vote-hud-slider input[type=\"range\"][data-winner=\"left\"]::-moz-range-track,\n-.vote-hud-slider input[type=\"range\"][data-winner=\"right\"]::-moz-range-track {\n+.vote-hud-slider input[type=\"range\"][data-winner=\"right\"]::-moz-range-track,\n+.vote-hud-slider input[type=\"range\"][data-winner=\"even\"]::-moz-range-track {\n height: 0.65rem;\n border-radius: 0;\n border: 2px solid var(--border);\n }\n \n+.vote-hud-slider input[type=\"range\"][data-winner=\"even\"]::-moz-range-track {\n+ background: var(--vote-track-muted);\n+}\n+\n .vote-hud-slider input[type=\"range\"][data-winner=\"left\"]::-moz-range-track {\n background: linear-gradient(\n to right,\n var(--vote-track-muted) 0%,\n var(--vote-track-muted) var(--vote-slider-pct, 50%),\n var(--accent) var(--vote-slider-pct, 50%),\n- var(--accent) 100%\n+ var(--accent) 50%,\n+ var(--vote-track-muted) 50%,\n+ var(--vote-track-muted) 100%\n );\n }\n \n .vote-hud-slider input[type=\"range\"][data-winner=\"right\"]::-moz-range-track {\n background: linear-gradient(\n to right,\n- var(--accent) 0%,\n+ var(--vote-track-muted) 0%,\n+ var(--vote-track-muted) 50%,\n+ var(--accent) 50%,\n var(--accent) var(--vote-slider-pct, 50%),\n var(--vote-track-muted) var(--vote-slider-pct, 50%),\n var(--vote-track-muted) 100%\n@@ -573,20 +596,23 @@ h1 {\n margin-bottom: 0.25rem;\n }\n \n-.ratio-bar {\n- display: flex;\n- height: 8px;\n- border-radius: 0;\n- overflow: hidden;\n- background: var(--border);\n+/* Read-only sliders in vote history — same track/thumb styling as the HUD. */\n+.vote-edge-slider {\n+ display: block;\n+ margin-top: 0.15rem;\n }\n \n-.ratio-left {\n- background: var(--accent);\n+.vote-edge-slider input[type=\"range\"] {\n+ pointer-events: none;\n+ cursor: default;\n+}\n+\n+.vote-edge-slider input[type=\"range\"]:disabled {\n+ opacity: 1;\n }\n \n-.ratio-right {\n- background: var(--muted);\n+.vote-edge-legend {\n+ margin: 0 0 0.5rem;\n }\n \n @media (max-width: 900px) {\ndiff --git a/server/static/sorter_ui.js b/server/static/sorter_ui.js\nindex f665b45f4fd4771427dc4c37e563e4976873beee..5d6d765f69f301722e59248c76e919043559fb78 100644\n--- a/server/static/sorter_ui.js\n+++ b/server/static/sorter_ui.js\n@@ -138,6 +138,10 @@\n function update() {\n var v = parseInt(slider.value, 10);\n if (!Number.isFinite(v)) v = 50;\n+ // Slider position drives the colored fill (a center-anchored bar that\n+ // grows toward whichever side is winning — see sorter.css). Sliding the\n+ // thumb left raises the left number; left winning keeps the accent mass\n+ // on the left, matching the \"votes on this pair\" history bars.\n slider.style.setProperty('--vote-slider-pct', v + '%');\n slider.setAttribute('aria-valuenow', String(v));\n var left = Math.max(1, 100 - v);\n@@ -147,8 +151,12 @@\n right = right / divisor;\n if (leftInput) leftInput.value = String(left);\n if (rightInput) rightInput.value = String(right);\n- if (ratioDisplay) ratioDisplay.textContent = left + ':' + right;\n- slider.dataset.winner = left >= right ? 'left' : 'right';\n+ var winner = left > right ? 'left' : (right > left ? 'right' : 'even');\n+ slider.dataset.winner = winner;\n+ if (ratioDisplay) {\n+ var label = winner === 'even' ? 'tie' : (winner + ' wins');\n+ ratioDisplay.textContent = left + ':' + right + ' \\u00b7 ' + label;\n+ }\n }\n slider.addEventListener('input', update);\n update();\n","role":"user"}],"model":"~x-ai/grok-latest"}