{"messages":[{"content":"You are a constitutional council ranking individual git commits for ownership allocation.\n\nCompare these two commits. Decide which contributed more lasting value to the project.\n\nJudge substance, not spectacle:\n- Prefer correct, lasting design and real bugfixes over churn, formatting, renames, or generated noise.\n- Prefer clarity and necessity over sheer line count. A small precise change can beat a large diffuse one.\n- Do not favor a side merely because its patch is longer or noisier.\n- Weight what the change does for the project, not the contributor's name.\n\nReturn ONLY a JSON object: {\"winner\": \"A\" or \"B\", \"ratio\": \"N:M\", \"explanation\": \"...\"}\nThe explanation must cite concrete differences in the patches (1-3 sentences).\n\nSide A — contributor: tommy-mor\nSide A — commit message:\n[03cd8f2e] Skip pinned Reddit posts when importing subreddit listings.\n\nCo-authored-by: Cursor \n\nSide A — unified diff (full patch):\ndiff --git a/server/src/reddit.rs b/server/src/reddit.rs\nindex f409764c1e1f36216f1b08107043c2eab905694c..fa5577f8ee0a8c53ff4dbec988a90a5d2fc3cdee 100644\n--- a/server/src/reddit.rs\n+++ b/server/src/reddit.rs\n@@ -661,6 +661,7 @@ pub fn map_children_url(id: &ItemId, api_base: &str) -> String {\n /// Parse a subreddit listing payload into `(child_id, child_payload)` entries.\n /// Each child id is the post's permalink under `reddit.com/…`, and the payload\n /// is the raw `{kind, data}` listing element (persisted per child).\n+/// Pinned / stickied posts are skipped.\n fn parse_children(_parent: &ItemId, payload: &Value) -> Vec<(ItemId, Value)> {\n let mut out = Vec::new();\n let children = match payload.pointer(\"/data/children\").and_then(|c| c.as_array()) {\n@@ -668,6 +669,9 @@ fn parse_children(_parent: &ItemId, payload: &Value) -> Vec<(ItemId, Value)> {\n None => return out,\n };\n for child in children {\n+ if child_is_pinned(child) {\n+ continue;\n+ }\n let permalink = match child.pointer(\"/data/permalink\").and_then(|p| p.as_str()) {\n Some(p) if !p.is_empty() => p,\n _ => continue,\n@@ -680,6 +684,15 @@ fn parse_children(_parent: &ItemId, payload: &Value) -> Vec<(ItemId, Value)> {\n out\n }\n \n+fn child_is_pinned(child: &Value) -> bool {\n+ let data = match child.get(\"data\") {\n+ Some(d) => d,\n+ None => return false,\n+ };\n+ data.get(\"stickied\").and_then(|v| v.as_bool()) == Some(true)\n+ || data.get(\"pinned\").and_then(|v| v.as_bool()) == Some(true)\n+}\n+\n fn parse_reddit_view(id: &ItemId, v: &Value) -> Option {\n let segments: Vec<&str> = id.as_str().split('/').collect();\n \n@@ -853,4 +866,46 @@ mod tests {\n Some(\"http://v3.redgifs.com/watch/impossibleprestigioushedgehog\")\n );\n }\n+\n+ #[test]\n+ fn parse_children_skips_pinned_posts() {\n+ let payload = serde_json::json!({\n+ \"kind\": \"Listing\",\n+ \"data\": {\n+ \"children\": [\n+ {\n+ \"kind\": \"t3\",\n+ \"data\": {\n+ \"title\": \"Official rules (pinned)\",\n+ \"permalink\": \"/r/rust/comments/pin/official_rules/\",\n+ \"stickied\": true\n+ }\n+ },\n+ {\n+ \"kind\": \"t3\",\n+ \"data\": {\n+ \"title\": \"Also pinned via pinned field\",\n+ \"permalink\": \"/r/rust/comments/pin2/also_pinned/\",\n+ \"pinned\": true\n+ }\n+ },\n+ {\n+ \"kind\": \"t3\",\n+ \"data\": {\n+ \"title\": \"Normal post\",\n+ \"permalink\": \"/r/rust/comments/aaa/normal_post/\",\n+ \"stickied\": false\n+ }\n+ }\n+ ]\n+ }\n+ });\n+ let parent = ItemId::from_url(\"https://reddit.com/r/rust\").unwrap();\n+ let children = parse_children(&parent, &payload);\n+ assert_eq!(children.len(), 1);\n+ assert_eq!(\n+ children[0].0.as_str(),\n+ \"https://reddit.com/r/rust/comments/aaa\"\n+ );\n+ }\n }\n\n\nSide B — contributor: tommy-mor\nSide B — commit message:\n[3bc88847] removed optional\n\nSide B — unified diff (full patch):\ndiff --git a/server/src/api/rpc.rs b/server/src/api/rpc.rs\nindex ba93ca87182d49f57dffc8220f604ffa150f9a6c..5049a26b096bd8435d6eb9e75ccb751b6f489061 100644\n--- a/server/src/api/rpc.rs\n+++ b/server/src/api/rpc.rs\n@@ -1337,8 +1337,7 @@ pub async fn handle_rpc_batch(\n .ingests_by_scope_thread\n .get(&(scope.clone(), e.thread.clone()))\n .and_then(|q| q.iter().rev().position(|id| id == &e.post_id))\n- .map(|i| i + 1)\n- .unwrap_or(0);\n+ .expect(\"rank history post_id must be in ingests_by_scope_thread for (scope, thread)\");\n RankHistoryRow {\n ts: e.ts,\n scope_rank: e.scope_rank,\ndiff --git a/server/src/html/garden.rs b/server/src/html/garden.rs\nindex 319feb15a6b68d2b5df98b4289fedbc9bdd048d3..23245d6fdfc9019b199ab8417150faf5f3297067 100644\n--- a/server/src/html/garden.rs\n+++ b/server/src/html/garden.rs\n@@ -450,6 +450,7 @@ struct RankHistoryEntryView {\n scope_total: usize,\n scope_rank_delta: i32,\n thread: String,\n+ /// 0-based index as [`crate::html::forum::ingest::thread_post_index_in_scope`] / `/t/tag/N`.\n thread_post_index: usize,\n caused_by: Vec,\n }\n@@ -573,11 +574,11 @@ fn build_rank_history(\n })\n .unwrap_or_default();\n \n- let thread_post_index = reduced.ingests_by_scope_thread\n+ let thread_post_index = reduced\n+ .ingests_by_scope_thread\n .get(&(scope.clone(), e.thread.clone()))\n .and_then(|q| q.iter().rev().position(|id| id == &e.post_id))\n- .map(|i| i + 1)\n- .unwrap_or(0);\n+ .expect(\"rank history post_id must be in ingests_by_scope_thread for (scope, thread)\");\n \n RankHistoryEntryView {\n ts: e.ts,\n@@ -704,11 +705,9 @@ async fn render_scope_view(\n span class=\"muted\" { (ago) (label) }\n \" · \"\n a href=(thread_href(&e.thread)) { \"#\" (e.thread) }\n- @if e.thread_post_index > 0 {\n- \" \"\n- a href=(format!(\"{}/{}\", thread_href(&e.thread), e.thread_post_index)) {\n- span class=\"muted\" { \"post #\" (e.thread_post_index) }\n- }\n+ \" \"\n+ a href=(format!(\"{}/{}\", thread_href(&e.thread), e.thread_post_index)) {\n+ span class=\"muted\" { \"post #\" (e.thread_post_index) }\n }\n }\n @if e.caused_by.is_empty() {\ndiff --git a/server/tests/integration.rs b/server/tests/integration.rs\nindex d4c5bfe9c6f1c71dc61878bd8c5e729b1b7c69ef..9766adb43ad315a64f5df17b79f66718ce149509 100644\n--- a/server/tests/integration.rs\n+++ b/server/tests/integration.rs\n@@ -1322,6 +1322,11 @@ async fn test_rank_history() {\n assert_eq!(entry[\"scope_rank_delta\"], 0, \"delta is 0 on first appearance\");\n let caused_by = entry[\"caused_by\"].as_array().unwrap();\n assert_eq!(caused_by.len(), 2, \"both votes in the ingest touched rust\");\n+ assert_eq!(\n+ entry[\"thread_post_index\"],\n+ 0,\n+ \"rank history links use same 0-based index as /t/hist-test/0\"\n+ );\n \n ingest(\n \"00000000-0000-0000-0000-000000000002:rig:test/model\",\n@@ -1349,6 +1354,16 @@ async fn test_rank_history() {\n assert_eq!(caused_by2.len(), 1);\n assert!(caused_by2[0][\"a\"].as_str().unwrap().ends_with(\"python\") ||\n caused_by2[0][\"b\"].as_str().unwrap().ends_with(\"python\"));\n+ assert_eq!(\n+ hist2[0][\"thread_post_index\"],\n+ 0,\n+ \"first hist-test post is chronological index 0\"\n+ );\n+ assert_eq!(\n+ hist2[1][\"thread_post_index\"],\n+ 1,\n+ \"second ingest is chronological index 1\"\n+ );\n \n let hist_rust2 = rpc_batch(\n &client,\ndiff --git a/types/src/lib.rs b/types/src/lib.rs\nindex edbb923e4d7d41ad82dfc254c3bd697562383527..49abba8ea9f786ef68e3157d2a5d309e15e09ba0 100644\n--- a/types/src/lib.rs\n+++ b/types/src/lib.rs\n@@ -253,7 +253,7 @@ pub struct FeedPost {\n /// Primary thread tag (without #), if the ingest declared one.\n #[serde(skip_serializing_if = \"Option::is_none\")]\n pub thread: Option,\n- /// 1-indexed chronological position of this post within the thread.\n+ /// 1-based display ordinal for this post within the thread (feed only; URLs use 0-based paths).\n #[serde(skip_serializing_if = \"Option::is_none\")]\n pub thread_post_index: Option,\n /// Full raw body of the ingest document.\n@@ -628,7 +628,7 @@ pub struct RankHistoryRow {\n pub score: f64,\n /// Thread tag of the ingest that triggered this rank change.\n pub thread: String,\n- /// 1-indexed chronological position of this post within the thread.\n+ /// 0-indexed chronological position of this post within the thread (same as `/t/tag/N` routes).\n pub thread_post_index: usize,\n /// Votes from this ingest that directly touched this item. Empty when change was transitive.\n pub caused_by: Vec,\n","role":"user"}],"model":"~x-ai/grok-latest"}