{"messages":[{"content":"You are a constitutional council ranking individual git commits for ownership allocation.\n\nCompare these two commits. Decide which contributed more lasting value to the project.\n\nJudge substance, not spectacle:\n- Prefer correct, lasting design and real bugfixes over churn, formatting, renames, or generated noise.\n- Prefer clarity and necessity over sheer line count. A small precise change can beat a large diffuse one.\n- Do not favor a side merely because its patch is longer or noisier.\n- Weight what the change does for the project, not the contributor's name.\n\nReturn ONLY a JSON object: {\"winner\": \"A\" or \"B\", \"ratio\": \"N:M\", \"explanation\": \"...\"}\nThe explanation must cite concrete differences in the patches (1-3 sentences).\n\nSide A — contributor: tommy-mor\nSide A — commit message:\n[10c9caac] Fix all workspace clippy warnings.\n\nWire up a missing ui_action test, allow dead code in shared integration helpers, and apply small clippy cleanups across server and types.\n\nCo-authored-by: Cursor <cursoragent@cursor.com>\n\nSide A — unified diff (full patch):\ndiff --git a/server/src/dsl.rs b/server/src/dsl.rs\nindex a45c5b33e10d0d2ea48c7313061cfa1e6430bcfc..faa8aac6616bc6ea2b102d08ae999c01a716ef6e 100644\n--- a/server/src/dsl.rs\n+++ b/server/src/dsl.rs\n@@ -927,9 +927,7 @@ mod tests {\n     #[test]\n     fn parse_vote_rejects_zero_zero_ratio() {\n         let err = parse_full(\"{tie placeholder}\\n~/a 0:0 ~/b\").unwrap_err();\n-        let msg = match err {\n-            DslError::Parse(m) => m,\n-        };\n+        let DslError::Parse(msg) = err;\n         assert!(\n             msg.contains(\"0:0\"),\n             \"expected 0:0 rejection message, got: {msg}\"\ndiff --git a/server/src/html/garden/tests.rs b/server/src/html/garden/tests.rs\nindex c2036fca7752aef63d260e36cfe9649f63b5c550..0a1be1290fdc93197ca191197a473840bb4decbc 100644\n--- a/server/src/html/garden/tests.rs\n+++ b/server/src/html/garden/tests.rs\n@@ -346,7 +346,7 @@ fn vote_compare_item_card_renders_github_import_markup() {\n         \"headline\": \"#1 Compare card\",\n         \"sublines\": [\"State: open\"],\n     });\n-    let body = format!(\"```slug-github-card\\n{}\\n```\", json.to_string());\n+    let body = format!(\"```slug-github-card\\n{json}\\n```\");\n     let html = vote_compare_item_card(\n         &nav,\n         &item,\ndiff --git a/server/src/html/ui_action.rs b/server/src/html/ui_action.rs\nindex 2589a2cc00bb7b18cd19ebcbb938083122d6921d..5e4131dd346a6f80bfe091a9b0cf7902721bc47f 100644\n--- a/server/src/html/ui_action.rs\n+++ b/server/src/html/ui_action.rs\n@@ -246,6 +246,7 @@ mod tests {\n         );\n     }\n \n+    #[test]\n     fn set_new_thread_compose_expanded_true() {\n         let template = serde_json::json!({\n             \"action\": \"set_new_thread_compose_expanded\",\ndiff --git a/server/src/offline.rs b/server/src/offline.rs\nindex 2db6f67e22e00a24ce673d13095644dd9fa9342d..93d4d5ee55449da644f732bc0ba007ee4c2c7079 100644\n--- a/server/src/offline.rs\n+++ b/server/src/offline.rs\n@@ -167,7 +167,7 @@ fn rankings_for_simulated(\n         .iter()\n         .map(|parent| {\n             let scoped_content = simulated\n-                .content_for_scope(&scope)\n+                .content_for_scope(scope)\n                 .unwrap_or_else(|| simulated.public());\n             let scoped = build_children_rankings(scoped_content, parent);\n             let components: Vec<RankComponent> = scoped\n@@ -254,7 +254,9 @@ fn ingest_parse_error(raw: &str) -> Option<String> {\n     dsl::parse_full(raw).err().map(|e| e.to_string())\n }\n \n-fn load_events_from_jsonl(path: &Path) -> Result<(usize, Vec<(usize, Event)>, Vec<BadJsonLine>), std::io::Error> {\n+type JsonlEventsLoad = Result<(usize, Vec<(usize, Event)>, Vec<BadJsonLine>), std::io::Error>;\n+\n+fn load_events_from_jsonl(path: &Path) -> JsonlEventsLoad {\n     let text = std::fs::read_to_string(path)?;\n     let total_lines = text.lines().count();\n     let mut events = Vec::new();\ndiff --git a/server/src/resolvers/github.rs b/server/src/resolvers/github.rs\nindex 30dd4cdac96de0e3da4fa03fdf82f91bed73bfe0..3cec5e8b7249a4597c378890cc9e6125104e76c3 100644\n--- a/server/src/resolvers/github.rs\n+++ b/server/src/resolvers/github.rs\n@@ -749,6 +749,6 @@ mod tests {\n             GithubImportKind::Issue,\n         );\n         assert!(card.sublines.iter().any(|l| l.contains(\"@octo\")));\n-        assert_eq!(card.excerpt.as_deref(), Some(\"The issue body.\").as_deref());\n+        assert_eq!(card.excerpt.as_deref(), Some(\"The issue body.\"));\n     }\n }\ndiff --git a/server/tests/basic.rs b/server/tests/basic.rs\nindex 31a35251a8abd6f4a48c1d7782b6985f621375e1..9d83e7a97e2c7494790db17c4b5b30c181705026 100644\n--- a/server/tests/basic.rs\n+++ b/server/tests/basic.rs\n@@ -337,7 +337,7 @@ async fn event_log_handles_corrupt_lines() {\n         .unwrap();\n \n     // Add empty line.\n-    writeln!(f, \"\").unwrap();\n+    writeln!(f).unwrap();\n \n     let (loaded, bad) = log.load_all().await.unwrap();\n     assert_eq!(loaded.len(), 2);\n@@ -511,9 +511,7 @@ fn dsl_parse_rejects_zero_zero_vote_ratio() {\n         \"~/t/a {a}\\n~/t/b {b}\\n{zero}\\n~/t/a 0:0 ~/t/b\\n\",\n     )\n     .expect_err(\"0:0 vote must be rejected by the parser\");\n-    let msg = match err {\n-        slugsocial_server::dsl::DslError::Parse(m) => m,\n-    };\n+    let slugsocial_server::dsl::DslError::Parse(msg) = err;\n     assert!(\n         msg.contains(\"0:0\"),\n         \"expected message about invalid 0:0 ratio, got: {msg}\"\n@@ -904,7 +902,7 @@ fn posts_by_actor_indexes_and_profile_visibility() {\n fn feed_query(state: &ReducerState, cutoff: i64, limit: usize) -> (usize, Vec<String>) {\n     let matching: Vec<&str> = state.ingests_ordered.iter().rev()\n         .map(|id| id.as_str())\n-        .take_while(|id| state.ingests_by_id.get(*id).map_or(false, |ing| ing.ts > cutoff))\n+        .take_while(|id| state.ingests_by_id.get(*id).is_some_and(|ing| ing.ts > cutoff))\n         .filter(|id| {\n             state.ingests_by_id.get(*id).is_some_and(|ing| {\n                 let scope = slugsocial_server::reducer::scope_from_room_wire(&ing.room_id);\ndiff --git a/server/tests/integration_health.rs b/server/tests/integration_health.rs\nindex 481222d8c48c44fcfb7e9ba26cf7644b5c26d5f4..351aae6b0e9738021886a076ee08fab5cf5a0001 100644\n--- a/server/tests/integration_health.rs\n+++ b/server/tests/integration_health.rs\n@@ -7,7 +7,7 @@ async fn test_healthz() {\n     let (addr, _tmp, _log, _handle) = create_test_server().await;\n     let client = reqwest::Client::new();\n     let response = client\n-        .get(&format!(\"http://{}/healthz\", addr))\n+        .get(format!(\"http://{}/healthz\", addr))\n         .send()\n         .await\n         .unwrap();\ndiff --git a/server/tests/integration_rpc.rs b/server/tests/integration_rpc.rs\nindex ccd89a02594bd2a8e7047edafca04b0e54384139..ec446d94a38c8d6961d2135dd031da7ab2a39b48 100644\n--- a/server/tests/integration_rpc.rs\n+++ b/server/tests/integration_rpc.rs\n@@ -440,7 +440,6 @@ async fn test_rank_history() {\n     let bearer = test_bearer();\n     let ingest = |delegate: &str, text: &str| {\n         let client = client.clone();\n-        let addr = addr;\n         let bearer = bearer.clone();\n         let text = text.to_string();\n         let delegate = delegate.to_string();\ndiff --git a/server/tests/support/mod.rs b/server/tests/support/mod.rs\nindex 84dc1d68b6c1e1fdfdbd0757139c06c3daf1e9a6..4a620eaa875e7a1145f2a4e82cc4ff2be21d5345 100644\n--- a/server/tests/support/mod.rs\n+++ b/server/tests/support/mod.rs\n@@ -1,3 +1,6 @@\n+//! Shared helpers for integration tests; each test binary uses a different subset.\n+#![allow(dead_code)]\n+\n use sha2::{Digest, Sha256};\n use slugsocial_server::{\n     event_log::EventLog,\ndiff --git a/types/src/paths.rs b/types/src/paths.rs\nindex ebc299c5e1af456c3e4b7fa45ed9fb23313e88c4..d2e799942b98dd7342764475deb17903fb60c600 100644\n--- a/types/src/paths.rs\n+++ b/types/src/paths.rs\n@@ -411,7 +411,7 @@ mod tests {\n     #[test]\n     fn garden_item_url_deref_to_str() {\n         let g = GardenItemUrl::from_storage_str(\"https://slug.social/~/x\", \"public\");\n-        let s: &str = &*g;\n+        let s: &str = &g;\n         assert_eq!(s, \"https://slug.social/~/x\");\n     }\n \n\n\nSide B — contributor: tommy-mor\nSide B — commit message:\n[36e92cf2] Fix /vote/compare page: attribution, fallback, swap button, and route rename.\n\n- Pass WEB_BROWSER_AGENT as delegate_opt out-of-band (not in DSL body text)\n- Error instead of falling back to all items when sibling pool < 2\n- Remove pointless \"swap sides\" button\n- Rename route /vote/compare → /vote\n\nCo-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>\n\nSide B — unified diff (full patch):\ndiff --git a/server/src/api/rpc.rs b/server/src/api/rpc.rs\nindex 0b7070a2b7289e5c40778c8d062bd4150285a8df..8e3d8e34922ddaaa89ea699edd99402bd40fdb1b 100644\n--- a/server/src/api/rpc.rs\n+++ b/server/src/api/rpc.rs\n@@ -281,6 +281,7 @@ pub async fn rpc_post_with_bearer(\n     bearer_token: &str,\n     room: String,\n     thread_tag: String,\n+    delegate_opt: Option<String>,\n     text: String,\n ) -> Result<RpcResult, RpcErr> {\n     use axum::http::{header, HeaderMap, HeaderValue};\n@@ -288,7 +289,7 @@ pub async fn rpc_post_with_bearer(\n     let hv = HeaderValue::from_str(&format!(\"Bearer {bearer_token}\"))\n         .map_err(|_| (\"invalid session token\".into(), None))?;\n     headers.insert(header::AUTHORIZATION, hv);\n-    rpc_post(state, &headers, room, thread_tag, None, text, false).await\n+    rpc_post(state, &headers, room, thread_tag, delegate_opt, text, false).await\n }\n \n async fn rpc_check(\ndiff --git a/server/src/api/ui_html.rs b/server/src/api/ui_html.rs\nindex a13a94767d8905adc09e31effff838e166781b6c..5faa642451d69555cb391974beb0ad22c9355c8c 100644\n--- a/server/src/api/ui_html.rs\n+++ b/server/src/api/ui_html.rs\n@@ -118,6 +118,7 @@ async fn dispatch_ui_action(\n                 &session.bearer,\n                 room.clone(),\n                 thread_tag.clone(),\n+                None,\n                 text,\n             )\n             .await\n@@ -246,8 +247,7 @@ async fn dispatch_ui_action(\n             }\n \n             let text = format!(\n-                \"@{}\\n{{\\n{}\\n}}\\n{} {}:{} {}\\n\",\n-                crate::api::auth::WEB_BROWSER_AGENT,\n+                \"{{\\n{}\\n}}\\n{} {}:{} {}\\n\",\n                 exp,\n                 left_id.as_str(),\n                 rl,\n@@ -260,6 +260,7 @@ async fn dispatch_ui_action(\n                 &session.bearer,\n                 room.clone(),\n                 thread_tag.clone(),\n+                Some(crate::api::auth::WEB_BROWSER_AGENT.to_string()),\n                 text,\n             )\n             .await\ndiff --git a/server/src/html/forum/nav.rs b/server/src/html/forum/nav.rs\nindex d33dc50f0b89a5ed7730c3bca204a67f6309388f..ae67f550a4bdf0bbeff58384c29a715015b64bd5 100644\n--- a/server/src/html/forum/nav.rs\n+++ b/server/src/html/forum/nav.rs\n@@ -85,7 +85,7 @@ impl ThreadNav {\n         format!(\"{}/{}/{}\", self.thread_path_prefix, tag, idx)\n     }\n \n-    /// Empty for public; `/r/:seg` for room — prefix for routes like `/vote/compare`.\n+    /// Empty for public; `/r/:seg` for room — prefix for routes like `/vote`.\n     pub(crate) fn room_path_prefix_for_vote_compare(&self) -> String {\n         match &self.scope {\n             ScopeId::Public => String::new(),\ndiff --git a/server/src/html/garden/vote.rs b/server/src/html/garden/vote.rs\nindex bdb4008c29ba49d7dc97b1cd2c32d9cdfce1ca04..1d7fc8aa7436bfa9c1186dfd940a8d751ab7e088 100644\n--- a/server/src/html/garden/vote.rs\n+++ b/server/src/html/garden/vote.rs\n@@ -208,7 +208,7 @@ pub(crate) async fn vote_compare_post_success_js(\n     state: &AppState,\n     nav: &ThreadNav,\n     _room_wire: &str,\n-    thread_tag: &str,\n+    _thread_tag: &str,\n     left: &ItemId,\n     right: &ItemId,\n     _post_id: &str,\n@@ -218,8 +218,7 @@ pub(crate) async fn vote_compare_post_success_js(\n     let content = content_for_garden_view(&reduced, &nav.scope());\n     let edge_history = vote_edge_history_markup(content, left, right);\n     let next_pair = suggest_next_vote_pair(content, left, right);\n-    let nav_markup =\n-        vote_compare_nav_markup(nav, next_pair.as_ref(), left, right, Some(thread_tag));\n+    let nav_markup = vote_compare_nav_markup(nav, next_pair.as_ref());\n     drop(reduced);\n     JsBuilder::new()\n         .morph_inner_selector(\"#vote-edge-history-region\", edge_history)\n@@ -236,7 +235,7 @@ pub(super) fn vote_compare_href(\n     let left_q = urlencoding::encode(left.as_str());\n     let right_q = urlencoding::encode(right.as_str());\n     let base = format!(\n-        \"{}/vote/compare?left={}&right={}\",\n+        \"{}/vote?left={}&right={}\",\n         nav.room_path_prefix_for_vote_compare(),\n         left_q,\n         right_q\n@@ -251,12 +250,8 @@ pub(super) fn vote_compare_href(\n fn vote_compare_nav_markup(\n     nav: &ThreadNav,\n     next_pair: Option<&(ItemId, ItemId)>,\n-    left: &ItemId,\n-    right: &ItemId,\n-    thread_override: Option<&str>,\n ) -> maud::Markup {\n     let next_pair_href = next_pair.map(|(nl, nr)| vote_compare_href(nav, nl, nr, None));\n-    let swap_pair_href = vote_compare_href(nav, right, left, thread_override);\n     html! {\n         div class=\"vote-compare-nav\" {\n             @if let Some(href) = &next_pair_href {\n@@ -264,7 +259,6 @@ fn vote_compare_nav_markup(\n             } @else {\n                 span class=\"vote-compare-next is-disabled\" { \"no next pair\" }\n             }\n-            a class=\"vote-compare-next\" href=(swap_pair_href) { \"swap sides\" }\n         }\n     }\n }\n@@ -274,7 +268,7 @@ pub(super) fn suggest_next_vote_pair(\n     current_left: &ItemId,\n     current_right: &ItemId,\n ) -> Option<(ItemId, ItemId)> {\n-    let mut pool: Vec<ItemId> = if current_left.parent().as_ref().map(|p| p.as_str())\n+    let pool: Vec<ItemId> = if current_left.parent().as_ref().map(|p| p.as_str())\n         == current_right.parent().as_ref().map(|p| p.as_str())\n     {\n         current_left\n@@ -291,7 +285,7 @@ pub(super) fn suggest_next_vote_pair(\n         Vec::new()\n     };\n     if pool.len() < 2 {\n-        pool = content.items.iter().cloned().collect();\n+        return None;\n     }\n     suggest_next_pair_in_pool(\n         &content.ranking_group,\n@@ -334,7 +328,7 @@ pub struct VoteCompareQuery {\n     pub thread: Option<String>,\n }\n \n-/// Public pairwise vote UI — `/vote/compare?left=&right=&thread=`.\n+/// Public pairwise vote UI — `/vote?left=&right=&thread=`.\n pub async fn vote_compare_page(\n     State(state): State<AppState>,\n     Query(q): Query<VoteCompareQuery>,\n@@ -426,7 +420,7 @@ async fn vote_compare_inner(\n     let next_path = uri\n         .path_and_query()\n         .map(|pq| pq.as_str().to_string())\n-        .unwrap_or_else(|| \"/vote/compare\".into());\n+        .unwrap_or_else(|| \"/vote\".into());\n \n     let rpc_json = template_json_compact(&json!({\n         \"action\": \"vote_compare_post\",\n@@ -462,7 +456,7 @@ async fn vote_compare_inner(\n                 Some(&item_bodies_for_cards),\n             ))\n         }\n-        (vote_compare_nav_markup(&nav, next_pair.as_ref(), &left, &right, q.thread.as_deref()))\n+        (vote_compare_nav_markup(&nav, next_pair.as_ref()))\n         div id=\"vote-edge-history-region\" {\n             (edge_history)\n         }\ndiff --git a/server/src/html/ui_action.rs b/server/src/html/ui_action.rs\nindex c7b643c8dde37dd1e3001f5ff716fe4f79d24c5e..dd5294202569454acf9f41b458718700bbf96f39 100644\n--- a/server/src/html/ui_action.rs\n+++ b/server/src/html/ui_action.rs\n@@ -38,7 +38,7 @@ pub enum HtmlUiAction {\n         #[serde(default)]\n         form_id: Option<String>,\n     },\n-    /// Post a pairwise vote from `/vote/compare` (browser compose).\n+    /// Post a pairwise vote from `/vote` (browser compose).\n     VoteComparePost {\n         room: String,\n         thread_tag: String,\ndiff --git a/server/src/lib.rs b/server/src/lib.rs\nindex ad8e31099c807fb5844acb16cd5086a2f19327a7..e102e73ec167fa35dcc22d4ec8c6f40202982429 100644\n--- a/server/src/lib.rs\n+++ b/server/src/lib.rs\n@@ -82,9 +82,9 @@ pub fn create_app(state: AppState) -> Router {\n         .route(\"/u/:username\", get(crate::html::user_profile_page))\n         .route(\"/try\", get(crate::html::editor_page))\n         .route(\"/try/check\", post(crate::html::editor_check))\n-        .route(\"/vote/compare\", get(crate::html::vote_compare_page))\n+        .route(\"/vote\", get(crate::html::vote_compare_page))\n         .route(\n-            \"/r/:room_key/vote/compare\",\n+            \"/r/:room_key/vote\",\n             get(crate::html::room_vote_compare_page),\n         )\n         .route(\"/~\", get(crate::html::garden_index))\ndiff --git a/server/tests/integration_html.rs b/server/tests/integration_html.rs\nindex a25a456c7cafd74a69e65e0c2e8ed2bfb2e27498..b3e31376737b2d5aabb739f408984a1f5ae0c974 100644\n--- a/server/tests/integration_html.rs\n+++ b/server/tests/integration_html.rs\n@@ -52,12 +52,12 @@ async fn test_view_counts_increment_and_display() {\n         .normalized_storage()\n         .to_storage_string();\n     let vote_q_right_first = format!(\n-        \"/vote/compare?right={}&left={}\",\n+        \"/vote?right={}&left={}\",\n         urlencoding::encode(&right),\n         urlencoding::encode(&left)\n     );\n     let vote_q_left_first = format!(\n-        \"/vote/compare?left={}&right={}\",\n+        \"/vote?left={}&right={}\",\n         urlencoding::encode(&left),\n         urlencoding::encode(&right)\n     );\n@@ -148,7 +148,7 @@ https://github.com/ghvotehi/a/issues/10 {\\n\\\n         .normalized_storage()\n         .to_storage_string();\n     let q = format!(\n-        \"/vote/compare?left={}&right={}\",\n+        \"/vote?left={}&right={}\",\n         urlencoding::encode(&left),\n         urlencoding::encode(&right)\n     );\ndiff --git a/server/tests/integration_ui.rs b/server/tests/integration_ui.rs\nindex 091afd922d28f48ab36aa9b9084aa825036d1f74..23db7b5672418d5bb0ab7529e05ef1f89e59062a 100644\n--- a/server/tests/integration_ui.rs\n+++ b/server/tests/integration_ui.rs\n@@ -110,7 +110,7 @@ async fn test_choose_username_carries_redirect_next() {\n             .expect(\"pending session must exist\");\n         pending.provider = Some(\"google\".to_string());\n         pending.provider_id = Some(\"google-user-redirect\".to_string());\n-        pending.redirect_next = Some(\"/vote/compare?left=%7E%2Fa&right=%7E%2Fb\".to_string());\n+        pending.redirect_next = Some(\"/vote?left=%7E%2Fa&right=%7E%2Fb\".to_string());\n     }\n \n     let choose = client\n@@ -122,7 +122,7 @@ async fn test_choose_username_carries_redirect_next() {\n \n     assert_eq!(choose.status(), reqwest::StatusCode::OK);\n     let body = choose.text().await.unwrap();\n-    assert!(body.contains(\"window.location = \\\"/vote/compare?left=%7E%2Fa&right=%7E%2Fb\\\"\"));\n+    assert!(body.contains(\"window.location = \\\"/vote?left=%7E%2Fa&right=%7E%2Fb\\\"\"));\n }\n \n #[tokio::test]\ndiff --git a/test/browser_vote_compare.clj b/test/browser_vote_compare.clj\nindex 7cd1e467fdd8a4480df1be2afd78adb45b9cdc6d..a98e144756421e1fa5064db6a9fc0dd8b08471c7 100644\n--- a/test/browser_vote_compare.clj\n+++ b/test/browser_vote_compare.clj\n@@ -66,7 +66,7 @@\n                       :headers {\"Authorization\" (str \"Bearer \" alice-token)})\n            post-json (json/parse-string (:body post-resp) false)\n            _ (is (true? (get-in post-json [\"results\" 0 \"ok\"])) \"seed items + edge vote via rpc\")\n-           cmp-url (str base-url \"/vote/compare?left=\" (enc left-url) \"&right=\" (enc third-url))]\n+           cmp-url (str base-url \"/vote?left=\" (enc left-url) \"&right=\" (enc third-url))]\n        (core/with-playwright [pw]\n          (core/with-browser [browser (core/launch-chromium pw {:headless true :channel \"chrome\"})]\n            (core/with-context [ctx (core/new-context browser)]\n","role":"user"}],"model":"~x-ai/grok-latest"}