{"messages":[{"content":"You are a constitutional council ranking individual git commits for ownership allocation.\n\nCompare these two commits. Decide which contributed more lasting value to the project.\n\nJudge substance, not spectacle:\n- Prefer correct, lasting design and real bugfixes over churn, formatting, renames, or generated noise.\n- Prefer clarity and necessity over sheer line count. A small precise change can beat a large diffuse one.\n- Do not favor a side merely because its patch is longer or noisier.\n- Weight what the change does for the project, not the contributor's name.\n\nReturn ONLY a JSON object: {\"winner\": \"A\" or \"B\", \"ratio\": \"N:M\", \"explanation\": \"...\"}\nThe explanation must cite concrete differences in the patches (1-3 sentences).\n\nSide A — contributor: tommy-mor\nSide A — commit message:\n[65bce99f] sibling groups #130\n\nSide A — unified diff (full patch):\ndiff --git a/server/src/html/garden.rs b/server/src/html/garden.rs\nindex 82c1b4b4f36ea13a906035a1789ba893222b3695..e3c56d124ab7b0fa08c7f9ae736103e6b7cf5862 100644\n--- a/server/src/html/garden.rs\n+++ b/server/src/html/garden.rs\n@@ -837,7 +837,8 @@ struct SiblingNavGroup {\n     links: Vec<SiblingNavLink>,\n }\n \n-/// Siblings under the same parent, grouped like child rankings (components then isolates).\n+/// Siblings under the same parent: one group per ranking component (ordered list), then one\n+/// group per isolated unranked sibling (each shows rank `1`, separated like components).\n #[derive(Debug, Clone)]\n struct SiblingNavBar {\n     groups: Vec<SiblingNavGroup>,\n@@ -890,15 +891,12 @@ fn build_sibling_nav(\n             groups.push(SiblingNavGroup { links });\n         }\n     }\n-    if !rankings.unranked_items.is_empty() {\n-        let links: Vec<SiblingNavLink> = rankings\n-            .unranked_items\n-            .iter()\n-            .map(|u| SiblingNavLink {\n+    for u in &rankings.unranked_items {\n+        groups.push(SiblingNavGroup {\n+            links: vec![SiblingNavLink {\n                 path: u.clone().normalized_storage().to_storage_string(),\n-            })\n-            .collect();\n-        groups.push(SiblingNavGroup { links });\n+            }],\n+        });\n     }\n     let sibling_total: usize = groups.iter().map(|g| g.links.len()).sum();\n     if sibling_total <= 1 {\n@@ -1541,6 +1539,29 @@ mod tests {\n         assert_eq!(nav.groups[1].links.len(), 1);\n     }\n \n+    #[test]\n+    fn sibling_nav_splits_each_unranked_into_its_own_group() {\n+        let mut reduced = ReducerState::default();\n+        apply_ingest(\n+            &mut reduced,\n+            1,\n+            \"@00000000-0000-0000-0000-000000000000:test:local/test\\n\\\n+             ~/topic {topic body}\\n\\\n+             ~/topic/a {alpha}\\n\\\n+             ~/topic/b {beta}\\n\\\n+             ~/topic/c {gamma}\\n\\\n+             ~/topic/d {delta}\\n\\\n+             {a beats b}\\n             ~/topic/a 2:1 ~/topic/b\\n\",\n+        );\n+\n+        let model = build_item_page_view_model(&reduced, &ScopeId::Public, \"~/topic/a\");\n+        let nav = model.sibling_nav.expect(\"expected sibling nav\");\n+        assert_eq!(nav.groups.len(), 3);\n+        assert_eq!(nav.groups[0].links.len(), 2);\n+        assert_eq!(nav.groups[1].links.len(), 1);\n+        assert_eq!(nav.groups[2].links.len(), 1);\n+    }\n+\n     #[test]\n     fn item_page_model_builds_ranked_child_components() {\n         let mut reduced = ReducerState::default();\n\n\nSide B — contributor: tommy-mor\nSide B — commit message:\n[047b82bd] Remove redundant zero-ratio guard from reducer.\n\nZeros are already rejected at the DSL parser and browser handler;\nthe guard in apply_vote was dead code. The negative clamping stays\nsince add_edge_weight already skips weight-0 edges correctly.\n\nCo-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>\n\nSide B — unified diff (full patch):\ndiff --git a/server/src/reducer.rs b/server/src/reducer.rs\nindex 0e36979abe0f051493038ff7e652efc7f7a0ac80..efbf7f67ff24c7a2989102fe62879b2794a27c5f 100644\n--- a/server/src/reducer.rs\n+++ b/server/src/reducer.rs\n@@ -112,11 +112,6 @@ impl GroupState {\n         if vote.ratio_right < 0 {\n             vote.ratio_right = 0;\n         }\n-        if vote.ratio_left == 0 || vote.ratio_right == 0 {\n-            // Zero on either side produces no valid edge; drop before registering items or pair.\n-            return;\n-        }\n-\n         let a_idx = self.ensure_item(&vote.a);\n         let b_idx = self.ensure_item(&vote.b);\n \ndiff --git a/server/tests/basic.rs b/server/tests/basic.rs\nindex 08159f4a7f0850fd165817a4a1af4f31ced2ad76..1748769ccf7196b2d81cf556d5368c7e723f6a4e 100644\n--- a/server/tests/basic.rs\n+++ b/server/tests/basic.rs\n@@ -533,7 +533,7 @@ fn dsl_parse_rejects_zero_zero_vote_ratio() {\n #[test]\n fn reducer_negative_ratio_clamped_to_zero() {\n     let _state = ReducerState::default();\n-    // GroupState::apply_vote clamps negatives to 0; when either side is 0 the vote is dropped.\n+    // apply_vote clamps negatives to 0; add_edge_weight skips zero-weight edges.\n     let mut group = GroupState::new();\n     group.apply_vote(slugsocial_server::reducer::VoteData {\n         ts: 1,\n@@ -546,10 +546,9 @@ fn reducer_negative_ratio_clamped_to_zero() {\n         delegate: Some(\"00000000-0000-0000-0000-000000000000:test:local/test\".to_string()),\n         thread_tag: \"t\".to_string(),\n     });\n-    // Nothing registered: zero-clamped vote is dropped before ensure_item.\n-    assert!(group.idx_to_item.is_empty());\n+    // Items and pair are registered; edges are absent because weight 0 is skipped.\n+    assert_eq!(group.idx_to_item.len(), 2);\n     assert!(group.edges.is_empty());\n-    assert!(group.voted_pairs.is_empty());\n }\n \n \n","role":"user"}],"model":"~x-ai/grok-latest"}