{"messages":[{"content":"You are a constitutional council ranking individual git commits for ownership allocation.\n\nCompare these two commits. Decide which contributed more lasting value to the project.\n\nJudge substance, not spectacle:\n- Prefer correct, lasting design and real bugfixes over churn, formatting, renames, or generated noise.\n- Prefer clarity and necessity over sheer line count. A small precise change can beat a large diffuse one.\n- Do not favor a side merely because its patch is longer or noisier.\n- Weight what the change does for the project, not the contributor's name.\n\nReturn ONLY a JSON object: {\"winner\": \"A\" or \"B\", \"ratio\": \"N:M\", \"explanation\": \"...\"}\nThe explanation must cite concrete differences in the patches (1-3 sentences).\n\nSide A — contributor: tommy-mor\nSide A — commit message:\n[aa0b175c] Enforce vote ratio constraints: both sides ≥ 1, max 100.\n\nZero on either side produces no valid graph edge; ratios above 100\nadd no meaningful signal. Enforce in the DSL parser, browser POST\nhandler, and reducer guard. Update browser pool test to use 99:1\ninstead of 100:0. Add unit and integration regression tests.\n\nCo-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>\n\nSide A — unified diff (full patch):\ndiff --git a/server/src/api/ui_html.rs b/server/src/api/ui_html.rs\nindex b79efdb4d52bd445a67f38cbfd61d3507d2b3014..bc8a0130b434cc7880a4bf16eb9237080c4aa383 100644\n--- a/server/src/api/ui_html.rs\n+++ b/server/src/api/ui_html.rs\n@@ -243,11 +243,23 @@ async fn dispatch_ui_action(\n             let pool_id = pool.as_deref().and_then(|p| {\n                 crate::path_types::ItemId::parse(p.trim()).map(|i| i.normalized_storage())\n             });\n-            let mut rl = ratio_left.trim().parse::<i32>().unwrap_or(0).max(0);\n-            let mut rr = ratio_right.trim().parse::<i32>().unwrap_or(0).max(0);\n-            if rl == 0 && rr == 0 {\n-                rl = 1;\n-                rr = 1;\n+            let rl = ratio_left.trim().parse::<i32>().unwrap_or(0).max(0);\n+            let rr = ratio_right.trim().parse::<i32>().unwrap_or(0).max(0);\n+            if rl == 0 || rr == 0 {\n+                return form_js_error(\n+                    err_tgt.as_ref(),\n+                    \"invalid ratio\",\n+                    \"Both ratio sides must be ≥ 1.\",\n+                )\n+                .into_response();\n+            }\n+            if rl > 100 || rr > 100 {\n+                return form_js_error(\n+                    err_tgt.as_ref(),\n+                    \"invalid ratio\",\n+                    \"Ratio sides must be ≤ 100.\",\n+                )\n+                .into_response();\n             }\n \n             let text = format!(\ndiff --git a/server/src/dsl.rs b/server/src/dsl.rs\nindex faa8aac6616bc6ea2b102d08ae999c01a716ef6e..338feacc579a92bed291867cc0f2f62462737462 100644\n--- a/server/src/dsl.rs\n+++ b/server/src/dsl.rs\n@@ -545,9 +545,14 @@ fn parse_block_prefixed_statement(\n \n     let ((ratio_left, ratio_right), k) = parse_comparison_at(s, i)\n         .ok_or_else(|| DslError::Parse(format!(\"invalid comparison near: {}\", &s[i..])))?;\n-    if ratio_left == 0 && ratio_right == 0 {\n+    if ratio_left == 0 || ratio_right == 0 {\n         return Err(DslError::Parse(\n-            \"vote ratio 0:0 is invalid; use 1:1 for a tie or omit the vote\".to_string(),\n+            \"vote ratio sides must be ≥ 1; use 1:1 for a tie or omit the vote\".to_string(),\n+        ));\n+    }\n+    if ratio_left > 100 || ratio_right > 100 {\n+        return Err(DslError::Parse(\n+            \"vote ratio sides must be ≤ 100\".to_string(),\n         ));\n     }\n     i = skip_ws(s, k);\n@@ -929,11 +934,50 @@ mod tests {\n         let err = parse_full(\"{tie placeholder}\\n~/a 0:0 ~/b\").unwrap_err();\n         let DslError::Parse(msg) = err;\n         assert!(\n-            msg.contains(\"0:0\"),\n-            \"expected 0:0 rejection message, got: {msg}\"\n+            msg.contains(\"≥ 1\"),\n+            \"expected zero-side rejection message, got: {msg}\"\n         );\n     }\n \n+    #[test]\n+    fn parse_vote_rejects_left_zero_ratio() {\n+        let err = parse_full(\"{prefer b}\\n~/a 0:5 ~/b\").unwrap_err();\n+        let DslError::Parse(msg) = err;\n+        assert!(\n+            msg.contains(\"≥ 1\"),\n+            \"expected zero-side rejection message, got: {msg}\"\n+        );\n+    }\n+\n+    #[test]\n+    fn parse_vote_rejects_right_zero_ratio() {\n+        let err = parse_full(\"{prefer a}\\n~/a 5:0 ~/b\").unwrap_err();\n+        let DslError::Parse(msg) = err;\n+        assert!(\n+            msg.contains(\"≥ 1\"),\n+            \"expected zero-side rejection message, got: {msg}\"\n+        );\n+    }\n+\n+    #[test]\n+    fn parse_vote_rejects_over_max_ratio() {\n+        let err = parse_full(\"{prefer a strongly}\\n~/a 101:1 ~/b\").unwrap_err();\n+        let DslError::Parse(msg) = err;\n+        assert!(\n+            msg.contains(\"≤ 100\"),\n+            \"expected max ratio rejection message, got: {msg}\"\n+        );\n+    }\n+\n+    #[test]\n+    fn parse_vote_accepts_max_ratio() {\n+        let doc = parse_full(\"{prefer a}\\n~/a 100:1 ~/b\").unwrap();\n+        assert!(matches!(\n+            doc.statements.last(),\n+            Some(Stmt::Vote { ratio_left: 100, ratio_right: 1, .. })\n+        ));\n+    }\n+\n     #[test]\n     fn parse_full_interleaves_prose() {\n         let input = \"hello\\n#tag\\nworld\";\ndiff --git a/server/src/reducer.rs b/server/src/reducer.rs\nindex e949e8e092297eedd5c20c131f16ef0121f329b3..6841d35cfc9de2389f340a22b8a45acb335e36c3 100644\n--- a/server/src/reducer.rs\n+++ b/server/src/reducer.rs\n@@ -119,11 +119,11 @@ impl GroupState {\n         let (i, j) = if a_idx < b_idx { (a_idx, b_idx) } else { (b_idx, a_idx) };\n         self.voted_pairs.insert((i, j));\n \n-        let mut w_a = vote.ratio_left.max(0) as f64;\n-        let mut w_b = vote.ratio_right.max(0) as f64;\n-        if w_a == 0.0 && w_b == 0.0 {\n-            w_a = 1.0;\n-            w_b = 1.0;\n+        let w_a = vote.ratio_left as f64;\n+        let w_b = vote.ratio_right as f64;\n+        if w_a == 0.0 || w_b == 0.0 {\n+            // Zero on either side produces no valid edge; drop the vote.\n+            return;\n         }\n \n         self.add_edge_weight(b_idx, a_idx, w_a);\ndiff --git a/server/tests/basic.rs b/server/tests/basic.rs\nindex 9d83e7a97e2c7494790db17c4b5b30c181705026..cc8c1a0d139f3722ba6ecd13dd001c65be835b67 100644\n--- a/server/tests/basic.rs\n+++ b/server/tests/basic.rs\n@@ -175,14 +175,14 @@ fn reducer_clamps_score_bounds() {\n     let mut state = ReducerState::default();\n     state.apply_event(ingest_event(\n         1,\n-        \"@00000000-0000-0000-0000-000000000000:test:local/test\\n~/t/a {a}\\n~/t/b {b}\\n{huge}\\n~/t/a 1000:1 ~/t/b\\n\",\n+        \"@00000000-0000-0000-0000-000000000000:test:local/test\\n~/t/a {a}\\n~/t/b {b}\\n{huge}\\n~/t/a 100:1 ~/t/b\\n\",\n     ));\n     state.apply_event(ingest_event(\n         2,\n-        \"@00000000-0000-0000-0000-000000000000:test:local/test\\n{huge}\\n~/t/a 1:1000 ~/t/b\\n\",\n+        \"@00000000-0000-0000-0000-000000000000:test:local/test\\n{huge}\\n~/t/a 1:100 ~/t/b\\n\",\n     ));\n \n-    assert_eq!(state.public().ranking_group.idx_to_item.len(), 2); // Should still work, scores clamped internally\n+    assert_eq!(state.public().ranking_group.idx_to_item.len(), 2); // Should still work, scores handled internally\n }\n \n // ============================================================================\n@@ -513,8 +513,8 @@ fn dsl_parse_rejects_zero_zero_vote_ratio() {\n     .expect_err(\"0:0 vote must be rejected by the parser\");\n     let slugsocial_server::dsl::DslError::Parse(msg) = err;\n     assert!(\n-        msg.contains(\"0:0\"),\n-        \"expected message about invalid 0:0 ratio, got: {msg}\"\n+        msg.contains(\"≥ 1\"),\n+        \"expected message about invalid zero ratio, got: {msg}\"\n     );\n \n     let mut state = ReducerState::default();\n@@ -533,7 +533,7 @@ fn dsl_parse_rejects_zero_zero_vote_ratio() {\n #[test]\n fn reducer_negative_ratio_clamped_to_zero() {\n     let _state = ReducerState::default();\n-    // GroupState::apply_vote clamps negatives to 0, then 0:0 -> 1:1\n+    // GroupState::apply_vote clamps negatives to 0; when either side is 0 the vote is dropped.\n     let mut group = GroupState::new();\n     group.apply_vote(slugsocial_server::reducer::VoteData {\n         ts: 1,\n@@ -546,12 +546,12 @@ fn reducer_negative_ratio_clamped_to_zero() {\n         delegate: Some(\"00000000-0000-0000-0000-000000000000:test:local/test\".to_string()),\n         thread_tag: \"t\".to_string(),\n     });\n+    // Items are registered, but the zero-clamped vote produces no edges.\n     assert_eq!(group.idx_to_item.len(), 2);\n-    // Both edges should exist (negatives clamped to 0, then 0:0 -> 1:1)\n     let a_idx = group.item_to_idx[&item_id(\"https://slug.social/~/t/a\")];\n     let b_idx = group.item_to_idx[&item_id(\"https://slug.social/~/t/b\")];\n-    assert!(group.edges.contains_key(&(a_idx, b_idx)));\n-    assert!(group.edges.contains_key(&(b_idx, a_idx)));\n+    assert!(!group.edges.contains_key(&(a_idx, b_idx)));\n+    assert!(!group.edges.contains_key(&(b_idx, a_idx)));\n }\n \n \ndiff --git a/server/tests/integration_ui.rs b/server/tests/integration_ui.rs\nindex 23db7b5672418d5bb0ab7529e05ef1f89e59062a..09c5481f039d59efb617a82bafcc432a186e2d30 100644\n--- a/server/tests/integration_ui.rs\n+++ b/server/tests/integration_ui.rs\n@@ -256,3 +256,96 @@ async fn test_sse_public_thread_morph_includes_post_body_not_thread_not_found()\n     );\n }\n \n+fn ui_vote_compare_post_rpc(\n+    room: &str,\n+    thread_tag: &str,\n+    left: &str,\n+    right: &str,\n+    ratio_left: &str,\n+    ratio_right: &str,\n+    explanation: &str,\n+) -> String {\n+    serde_json::json!({\n+        \"action\": \"vote_compare_post\",\n+        \"room\": room,\n+        \"thread_tag\": thread_tag,\n+        \"left_item\": left,\n+        \"right_item\": right,\n+        \"ratio_left\": ratio_left,\n+        \"ratio_right\": ratio_right,\n+        \"explanation\": explanation,\n+        \"next\": \"/vote\",\n+    })\n+    .to_string()\n+}\n+\n+#[tokio::test]\n+async fn test_vote_compare_post_rejects_zero_left_ratio() {\n+    let (addr, _tmp, _log, _handle) = create_test_server().await;\n+    let client = reqwest::Client::new();\n+    let bearer = test_bearer();\n+\n+    let rpc = ui_vote_compare_post_rpc(\"public\", \"test-vote\", \"~/a\", \"~/b\", \"0\", \"5\", \"prefer b\");\n+    let resp = client\n+        .post(format!(\"http://{addr}/ui\"))\n+        .header(\"Authorization\", format!(\"Bearer {bearer}\"))\n+        .form(&[(\"__rpc__\", rpc.as_str())])\n+        .send()\n+        .await\n+        .unwrap();\n+\n+    assert_eq!(resp.status(), reqwest::StatusCode::OK);\n+    let js = resp.text().await.unwrap();\n+    assert!(\n+        js.contains(\"invalid ratio\") || js.contains(\"≥ 1\"),\n+        \"expected zero-ratio rejection, got: {js}\"\n+    );\n+}\n+\n+#[tokio::test]\n+async fn test_vote_compare_post_rejects_zero_right_ratio() {\n+    let (addr, _tmp, _log, _handle) = create_test_server().await;\n+    let client = reqwest::Client::new();\n+    let bearer = test_bearer();\n+\n+    let rpc = ui_vote_compare_post_rpc(\"public\", \"test-vote\", \"~/a\", \"~/b\", \"5\", \"0\", \"prefer a\");\n+    let resp = client\n+        .post(format!(\"http://{addr}/ui\"))\n+        .header(\"Authorization\", format!(\"Bearer {bearer}\"))\n+        .form(&[(\"__rpc__\", rpc.as_str())])\n+        .send()\n+        .await\n+        .unwrap();\n+\n+    assert_eq!(resp.status(), reqwest::StatusCode::OK);\n+    let js = resp.text().await.unwrap();\n+    assert!(\n+        js.contains(\"invalid ratio\") || js.contains(\"≥ 1\"),\n+        \"expected zero-ratio rejection, got: {js}\"\n+    );\n+}\n+\n+#[tokio::test]\n+async fn test_vote_compare_post_rejects_over_max_ratio() {\n+    let (addr, _tmp, _log, _handle) = create_test_server().await;\n+    let client = reqwest::Client::new();\n+    let bearer = test_bearer();\n+\n+    let rpc =\n+        ui_vote_compare_post_rpc(\"public\", \"test-vote\", \"~/a\", \"~/b\", \"101\", \"1\", \"prefer a\");\n+    let resp = client\n+        .post(format!(\"http://{addr}/ui\"))\n+        .header(\"Authorization\", format!(\"Bearer {bearer}\"))\n+        .form(&[(\"__rpc__\", rpc.as_str())])\n+        .send()\n+        .await\n+        .unwrap();\n+\n+    assert_eq!(resp.status(), reqwest::StatusCode::OK);\n+    let js = resp.text().await.unwrap();\n+    assert!(\n+        js.contains(\"invalid ratio\") || js.contains(\"≤ 100\"),\n+        \"expected over-max ratio rejection, got: {js}\"\n+    );\n+}\n+\ndiff --git a/test/browser_vote_pool.clj b/test/browser_vote_pool.clj\nindex 23d0bd80b02bd8b1b48853454bed02793296550e..738608801027d1e662660b5d6c830b4ccd07c434 100644\n--- a/test/browser_vote_pool.clj\n+++ b/test/browser_vote_pool.clj\n@@ -38,8 +38,8 @@\n ;; Set the hidden ratio inputs so the alphabetically-earlier item wins.\n (defn- set-ratio! [pg left-text right-text]\n   (let [[rl rr] (if (neg? (compare (leaf left-text) (leaf right-text)))\n-                  [100 0]   ; left is earlier → prefer left\n-                  [0 100])] ; right is earlier → prefer right\n+                  [99 1]   ; left is earlier → prefer left\n+                  [1 99])] ; right is earlier → prefer right\n     (page/evaluate pg (str \"document.getElementById('vote-ratio-left').value='\" rl \"'\"))\n     (page/evaluate pg (str \"document.getElementById('vote-ratio-right').value='\" rr \"'\"))))\n \n\n\nSide B — contributor: tommy-mor\nSide B — commit message:\n[81de487b] Fix zero-ratio guard in reducer to drop before registering items or pair.\n\nPreviously the early-return for zero-weight votes happened after\nensure_item and voted_pairs.insert, leaving ghost items in the index\nand the pair incorrectly marked as voted. Move the check to before\nany side effects.\n\nCo-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>\n\nSide B — unified diff (full patch):\ndiff --git a/server/src/reducer.rs b/server/src/reducer.rs\nindex 6841d35cfc9de2389f340a22b8a45acb335e36c3..0e36979abe0f051493038ff7e652efc7f7a0ac80 100644\n--- a/server/src/reducer.rs\n+++ b/server/src/reducer.rs\n@@ -112,6 +112,10 @@ impl GroupState {\n         if vote.ratio_right < 0 {\n             vote.ratio_right = 0;\n         }\n+        if vote.ratio_left == 0 || vote.ratio_right == 0 {\n+            // Zero on either side produces no valid edge; drop before registering items or pair.\n+            return;\n+        }\n \n         let a_idx = self.ensure_item(&vote.a);\n         let b_idx = self.ensure_item(&vote.b);\n@@ -121,10 +125,6 @@ impl GroupState {\n \n         let w_a = vote.ratio_left as f64;\n         let w_b = vote.ratio_right as f64;\n-        if w_a == 0.0 || w_b == 0.0 {\n-            // Zero on either side produces no valid edge; drop the vote.\n-            return;\n-        }\n \n         self.add_edge_weight(b_idx, a_idx, w_a);\n         self.add_edge_weight(a_idx, b_idx, w_b);\ndiff --git a/server/tests/basic.rs b/server/tests/basic.rs\nindex cc8c1a0d139f3722ba6ecd13dd001c65be835b67..08159f4a7f0850fd165817a4a1af4f31ced2ad76 100644\n--- a/server/tests/basic.rs\n+++ b/server/tests/basic.rs\n@@ -546,12 +546,10 @@ fn reducer_negative_ratio_clamped_to_zero() {\n         delegate: Some(\"00000000-0000-0000-0000-000000000000:test:local/test\".to_string()),\n         thread_tag: \"t\".to_string(),\n     });\n-    // Items are registered, but the zero-clamped vote produces no edges.\n-    assert_eq!(group.idx_to_item.len(), 2);\n-    let a_idx = group.item_to_idx[&item_id(\"https://slug.social/~/t/a\")];\n-    let b_idx = group.item_to_idx[&item_id(\"https://slug.social/~/t/b\")];\n-    assert!(!group.edges.contains_key(&(a_idx, b_idx)));\n-    assert!(!group.edges.contains_key(&(b_idx, a_idx)));\n+    // Nothing registered: zero-clamped vote is dropped before ensure_item.\n+    assert!(group.idx_to_item.is_empty());\n+    assert!(group.edges.is_empty());\n+    assert!(group.voted_pairs.is_empty());\n }\n \n \n","role":"user"}],"model":"openai/gpt-chat-latest"}