{"messages":[{"content":"You are a constitutional council ranking individual git commits for ownership allocation.\n\nCompare these two commits. Decide which contributed more lasting value to the project.\n\nJudge substance, not spectacle:\n- Prefer correct, lasting design and real bugfixes over churn, formatting, renames, or generated noise.\n- Prefer clarity and necessity over sheer line count. A small precise change can beat a large diffuse one.\n- Do not favor a side merely because its patch is longer or noisier.\n- Weight what the change does for the project, not the contributor's name.\n\nReturn ONLY a JSON object: {\"winner\": \"A\" or \"B\", \"ratio\": \"N:M\", \"explanation\": \"...\"}\nThe explanation must cite concrete differences in the patches (1-3 sentences).\n\nSide A — contributor: tommy-mor\nSide A — commit message:\n[0bebe819] Unify kaocha test discovery to one auto-discovered suite.\n\nReplace the two hand-enumerated suites (:http-integration, :browser) with\na single :all suite that picks up every test.* namespace under test/. New\ntest files now run automatically without touching tests.edn — needed for\nthe test.ranking namespace added alongside the #146 fix, and for any\nfuture tests.\n\nBoth ./TEST.sh and CI (.github/workflows/ci.yml) invoke\n`clojure -M:kaocha`, so both pick up the new suite without changes.\n\nCo-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>\n\nSide A — unified diff (full patch):\ndiff --git a/tests.edn b/tests.edn\nindex 5e2b0433a66c51806d08ef38d691259cfccd1fe0..e51ffcc81eeae6f41c85d1bfc5ba32f592cc5818 100644\n--- a/tests.edn\n+++ b/tests.edn\n@@ -1,30 +1,14 @@\n #kaocha/v1\n-{:tests\n- [{:id :http-integration\n-   :test-paths [\"test\"]\n-   :source-paths [\".\"]\n-   :ns-patterns [\"^test\\\\.integration$\"\n-                 \"^test\\\\.auth$\"\n-                 \"^test\\\\.grants$\"\n-                 \"^test\\\\.invites$\"\n-                 \"^test\\\\.room-list$\"]\n-   :kaocha.filter/skip-meta [:skip]\n-   :parallel? false}\n-  {:id :browser\n-   :test-paths [\"test\"]\n-   :source-paths [\".\"]\n-   :ns-patterns [\"^test\\\\.browser-sse$\"\n-                 \"^test\\\\.browser-ui-morph$\"\n-                 \"^test\\\\.browser-post-redact$\"\n-                 \"^test\\\\.browser-room-delete$\"\n-                 \"^test\\\\.browser-public-garden$\"\n-                 \"^test\\\\.browser-redact-thread-index$\"\n-                 \"^test\\\\.browser-garden-pin$\"\n-                 \"^test\\\\.browser-vote-compare$\"\n-                 \"^test\\\\.browser-github-resolver$\"]\n-   :kaocha.filter/skip-meta [:skip]\n-   :parallel? false}]\n- :plugins [:kaocha.plugin/junit-xml]\n- :kaocha.plugin.junit-xml/target-file \"target/kaocha-junit.xml\"\n- :kaocha.plugin.junit-xml/add-location-metadata? true\n- :reporter kaocha.report.progress/report}\n+ {:tests\n+  [{:id :all\n+    :test-paths [\"test\"]\n+    :source-paths [\".\"]\n+   ;; Pick up every test.* namespace under test/. New files don't need to be\n+   ;; enumerated here — drop them in test/ with `(ns test.foo …)` and they run.\n+    :ns-patterns [\"^test\\\\..+\"]\n+    :kaocha.filter/skip-meta [:skip]\n+    :parallel? false}]\n+  :plugins [:kaocha.plugin/junit-xml]\n+  :kaocha.plugin.junit-xml/target-file \"target/kaocha-junit.xml\"\n+  :kaocha.plugin.junit-xml/add-location-metadata? true\n+  :reporter kaocha.report.progress/report}\n\n\nSide B — contributor: tommy-mor\nSide B — commit message:\n[047b82bd] Remove redundant zero-ratio guard from reducer.\n\nZeros are already rejected at the DSL parser and browser handler;\nthe guard in apply_vote was dead code. The negative clamping stays\nsince add_edge_weight already skips weight-0 edges correctly.\n\nCo-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>\n\nSide B — unified diff (full patch):\ndiff --git a/server/src/reducer.rs b/server/src/reducer.rs\nindex 0e36979abe0f051493038ff7e652efc7f7a0ac80..efbf7f67ff24c7a2989102fe62879b2794a27c5f 100644\n--- a/server/src/reducer.rs\n+++ b/server/src/reducer.rs\n@@ -112,11 +112,6 @@ impl GroupState {\n         if vote.ratio_right < 0 {\n             vote.ratio_right = 0;\n         }\n-        if vote.ratio_left == 0 || vote.ratio_right == 0 {\n-            // Zero on either side produces no valid edge; drop before registering items or pair.\n-            return;\n-        }\n-\n         let a_idx = self.ensure_item(&vote.a);\n         let b_idx = self.ensure_item(&vote.b);\n \ndiff --git a/server/tests/basic.rs b/server/tests/basic.rs\nindex 08159f4a7f0850fd165817a4a1af4f31ced2ad76..1748769ccf7196b2d81cf556d5368c7e723f6a4e 100644\n--- a/server/tests/basic.rs\n+++ b/server/tests/basic.rs\n@@ -533,7 +533,7 @@ fn dsl_parse_rejects_zero_zero_vote_ratio() {\n #[test]\n fn reducer_negative_ratio_clamped_to_zero() {\n     let _state = ReducerState::default();\n-    // GroupState::apply_vote clamps negatives to 0; when either side is 0 the vote is dropped.\n+    // apply_vote clamps negatives to 0; add_edge_weight skips zero-weight edges.\n     let mut group = GroupState::new();\n     group.apply_vote(slugsocial_server::reducer::VoteData {\n         ts: 1,\n@@ -546,10 +546,9 @@ fn reducer_negative_ratio_clamped_to_zero() {\n         delegate: Some(\"00000000-0000-0000-0000-000000000000:test:local/test\".to_string()),\n         thread_tag: \"t\".to_string(),\n     });\n-    // Nothing registered: zero-clamped vote is dropped before ensure_item.\n-    assert!(group.idx_to_item.is_empty());\n+    // Items and pair are registered; edges are absent because weight 0 is skipped.\n+    assert_eq!(group.idx_to_item.len(), 2);\n     assert!(group.edges.is_empty());\n-    assert!(group.voted_pairs.is_empty());\n }\n \n \n","role":"user"}],"model":"~x-ai/grok-latest"}