{"messages":[{"content":"You are a constitutional council ranking individual git commits for ownership allocation.\n\nCompare these two commits. Decide which contributed more lasting value to the project.\n\nJudge substance, not spectacle:\n- Prefer correct, lasting design and real bugfixes over churn, formatting, renames, or generated noise.\n- Prefer clarity and necessity over sheer line count. A small precise change can beat a large diffuse one.\n- Do not favor a side merely because its patch is longer or noisier.\n- Weight what the change does for the project, not the contributor's name.\n\nReturn ONLY a JSON object: {\"winner\": \"A\" or \"B\", \"ratio\": \"N:M\", \"explanation\": \"...\"}\nThe explanation must cite concrete differences in the patches (1-3 sentences).\n\nSide A — contributor: tommy-mor\nSide A — commit message:\n[432e1450] nice\n\nSide A — unified diff (full patch):\ndiff --git a/reddit.rs b/reddit.rs\nnew file mode 100644\nindex 0000000000000000000000000000000000000000..da27f6f76482dd27d44cad9d7b844972bf042e64\n--- /dev/null\n+++ b/reddit.rs\n@@ -0,0 +1,420 @@\n+use governor::{Quota, RateLimiter, Jitter};\n+use nonzero_ext::nonzero;\n+use reqwest::{Client, StatusCode};\n+use serde::{Deserialize, Serialize};\n+use std::sync::Arc;\n+use std::time::Duration;\n+use anyhow::{Result, Context, anyhow};\n+\n+/// Reddit API client with built-in rate limiting\n+pub struct RedditClient {\n+    client: Client,\n+    limiter: Arc<governor::DefaultDirectRateLimiter>,\n+    user_agent: String,\n+}\n+\n+impl RedditClient {\n+    /// Create a new Reddit client with rate limiting\n+    /// Reddit API allows 60 requests per minute for OAuth2 authenticated apps\n+    /// We'll be conservative and use 50 requests per minute\n+    pub fn new() -> Self {\n+        // Create rate limiter: 50 requests per minute\n+        let quota = Quota::per_minute(nonzero!(50u32));\n+        let limiter = Arc::new(RateLimiter::direct(quota));\n+        \n+        // Create HTTP client with timeout\n+        let client = Client::builder()\n+            .timeout(Duration::from_secs(30))\n+            .build()\n+            .expect(\"Failed to create HTTP client\");\n+        \n+        // Reddit requires a unique user agent\n+        let user_agent = format!(\n+            \"rust:sorter:v{} (by /u/hourLong_arnould)\",\n+            env!(\"CARGO_PKG_VERSION\")\n+        );\n+        \n+        Self {\n+            client,\n+            limiter,\n+            user_agent,\n+        }\n+    }\n+    \n+    /// Fetch hot posts from a subreddit\n+    pub async fn get_subreddit_hot(&self, subreddit: &str, limit: usize) -> Result<RedditListingResponse> {\n+        // Wait for rate limiter\n+        self.limiter.until_ready_with_jitter(Jitter::up_to(Duration::from_millis(100))).await;\n+        \n+        let url = format!(\"https://www.reddit.com/r/{}/hot.json?limit={}\", subreddit, limit);\n+        \n+        let response = self.client\n+            .get(&url)\n+            .header(\"User-Agent\", &self.user_agent)\n+            .send()\n+            .await\n+            .context(\"Failed to send request to Reddit\")?;\n+        \n+        self.handle_response(response).await\n+    }\n+    \n+    /// Fetch top posts from a subreddit\n+    pub async fn get_subreddit_top(&self, subreddit: &str, limit: usize, time_period: &str) -> Result<RedditListingResponse> {\n+        self.limiter.until_ready_with_jitter(Jitter::up_to(Duration::from_millis(100))).await;\n+        \n+        let url = format!(\n+            \"https://www.reddit.com/r/{}/top.json?limit={}&t={}\",\n+            subreddit, limit, time_period\n+        );\n+        \n+        let response = self.client\n+            .get(&url)\n+            .header(\"User-Agent\", &self.user_agent)\n+            .send()\n+            .await\n+            .context(\"Failed to send request to Reddit\")?;\n+        \n+        self.handle_response(response).await\n+    }\n+    \n+    /// Fetch new posts from a subreddit\n+    pub async fn get_subreddit_new(&self, subreddit: &str, limit: usize) -> Result<RedditListingResponse> {\n+        self.limiter.until_ready_with_jitter(Jitter::up_to(Duration::from_millis(100))).await;\n+        \n+        let url = format!(\"https://www.reddit.com/r/{}/new.json?limit={}\", subreddit, limit);\n+        \n+        let response = self.client\n+            .get(&url)\n+            .header(\"User-Agent\", &self.user_agent)\n+            .send()\n+            .await\n+            .context(\"Failed to send request to Reddit\")?;\n+        \n+        self.handle_response(response).await\n+    }\n+    \n+    /// Fetch a specific post and its comments\n+    pub async fn get_post(&self, subreddit: &str, post_id: &str) -> Result<Vec<RedditListingResponse>> {\n+        self.limiter.until_ready_with_jitter(Jitter::up_to(Duration::from_millis(100))).await;\n+        \n+        let url = format!(\n+            \"https://www.reddit.com/r/{}/comments/{}.json\",\n+            subreddit, post_id\n+        );\n+        \n+        let response = self.client\n+            .get(&url)\n+            .header(\"User-Agent\", &self.user_agent)\n+            .send()\n+            .await\n+            .context(\"Failed to send request to Reddit\")?;\n+        \n+        match response.status() {\n+            StatusCode::OK => {\n+                let listings: Vec<RedditListingResponse> = response\n+                    .json()\n+                    .await\n+                    .context(\"Failed to parse Reddit response\")?;\n+                Ok(listings)\n+            }\n+            StatusCode::TOO_MANY_REQUESTS => {\n+                Err(anyhow!(\"Reddit rate limit exceeded. Please try again later.\"))\n+            }\n+            StatusCode::NOT_FOUND => {\n+                Err(anyhow!(\"Post not found: r/{}/comments/{}\", subreddit, post_id))\n+            }\n+            status => {\n+                Err(anyhow!(\"Reddit API error: {}\", status))\n+            }\n+        }\n+    }\n+    \n+    /// Fetch user profile (posts and comments)\n+    pub async fn get_user_profile(&self, username: &str, content_type: &str, limit: usize) -> Result<RedditListingResponse> {\n+        self.limiter.until_ready_with_jitter(Jitter::up_to(Duration::from_millis(100))).await;\n+        \n+        let url = format!(\n+            \"https://www.reddit.com/user/{}/{}.json?limit={}\",\n+            username, content_type, limit\n+        );\n+        \n+        let response = self.client\n+            .get(&url)\n+            .header(\"User-Agent\", &self.user_agent)\n+            .send()\n+            .await\n+            .context(\"Failed to send request to Reddit\")?;\n+        \n+        self.handle_response(response).await\n+    }\n+    \n+    /// Handle Reddit API response with proper error checking\n+    async fn handle_response(&self, response: reqwest::Response) -> Result<RedditListingResponse> {\n+        match response.status() {\n+            StatusCode::OK => {\n+                let listing: RedditListingResponse = response\n+                    .json()\n+                    .await\n+                    .context(\"Failed to parse Reddit response\")?;\n+                Ok(listing)\n+            }\n+            StatusCode::TOO_MANY_REQUESTS => {\n+                Err(anyhow!(\"Reddit rate limit exceeded. Please try again later.\"))\n+            }\n+            StatusCode::NOT_FOUND => {\n+                Err(anyhow!(\"Reddit resource not found\"))\n+            }\n+            StatusCode::FORBIDDEN => {\n+                Err(anyhow!(\"Access forbidden. The subreddit may be private.\"))\n+            }\n+            status => {\n+                Err(anyhow!(\"Reddit API error: {}\", status))\n+            }\n+        }\n+    }\n+}\n+\n+// Reddit API response types\n+#[derive(Debug, Clone, Serialize, Deserialize)]\n+pub struct RedditListingResponse {\n+    pub kind: String,\n+    pub data: RedditListingData,\n+}\n+\n+#[derive(Debug, Clone, Serialize, Deserialize)]\n+pub struct RedditListingData {\n+    #[serde(skip_serializing_if = \"Option::is_none\")]\n+    pub after: Option<String>,\n+    #[serde(skip_serializing_if = \"Option::is_none\")]\n+    pub before: Option<String>,\n+    pub children: Vec<RedditThing>,\n+    #[serde(skip_serializing_if = \"Option::is_none\")]\n+    pub modhash: Option<String>,\n+}\n+\n+#[derive(Debug, Clone, Serialize, Deserialize)]\n+pub struct RedditThing {\n+    pub kind: String,\n+    pub data: RedditThingData,\n+}\n+\n+/// Reddit's \"Thing\" data can be either a post, comment, or other types\n+/// We use untagged enum to handle different data structures\n+#[derive(Debug, Clone, Serialize, Deserialize)]\n+#[serde(untagged)]\n+pub enum RedditThingData {\n+    Post(RedditPost),\n+    Comment(RedditComment),\n+    // For things we don't care about yet (like \"more\" comments)\n+    Other(serde_json::Value),\n+}\n+\n+/// Reddit post data with serde handling all the parsing\n+#[derive(Debug, Clone, Serialize, Deserialize)]\n+pub struct RedditPost {\n+    pub id: String,\n+    pub name: String, // Full name (t3_xxx)\n+    #[serde(default = \"default_untitled\")]\n+    pub title: String,\n+    #[serde(default = \"default_deleted_user\")]\n+    pub author: String,\n+    pub subreddit: String,\n+    #[serde(default)]\n+    pub url: String,\n+    #[serde(default)]\n+    pub permalink: String,\n+    #[serde(default, deserialize_with = \"deserialize_selftext\")]\n+    pub selftext: Option<String>,\n+    #[serde(default)]\n+    pub score: i64,\n+    #[serde(default)]\n+    pub num_comments: i64,\n+    #[serde(default)]\n+    pub created_utc: f64,\n+    #[serde(default, deserialize_with = \"deserialize_thumbnail\")]\n+    pub thumbnail: Option<String>,\n+    #[serde(default)]\n+    pub is_video: bool,\n+    #[serde(default)]\n+    pub is_self: bool,\n+    // Additional useful fields\n+    #[serde(default)]\n+    pub ups: i64,\n+    #[serde(default)]\n+    pub downs: i64,\n+    #[serde(default)]\n+    pub upvote_ratio: f64,\n+    #[serde(default)]\n+    pub over_18: bool,\n+    #[serde(default)]\n+    pub spoiler: bool,\n+    #[serde(default)]\n+    pub stickied: bool,\n+    #[serde(default)]\n+    pub locked: bool,\n+    #[serde(default)]\n+    pub distinguished: Option<String>,\n+}\n+\n+/// Reddit comment data\n+#[derive(Debug, Clone, Serialize, Deserialize)]\n+pub struct RedditComment {\n+    pub id: String,\n+    pub name: String, // Full name (t1_xxx)\n+    #[serde(default = \"default_deleted_user\")]\n+    pub author: String,\n+    #[serde(default)]\n+    pub body: String,\n+    #[serde(default)]\n+    pub score: i64,\n+    #[serde(default)]\n+    pub created_utc: f64,\n+    #[serde(default)]\n+    pub parent_id: String,\n+    #[serde(default)]\n+    pub permalink: String,\n+    #[serde(default)]\n+    pub depth: i32,\n+    // Additional useful fields\n+    #[serde(default)]\n+    pub ups: i64,\n+    #[serde(default)]\n+    pub downs: i64,\n+    #[serde(default)]\n+    pub edited: RedditEditStatus,\n+    #[serde(default)]\n+    pub stickied: bool,\n+    #[serde(default)]\n+    pub distinguished: Option<String>,\n+    #[serde(default)]\n+    pub is_submitter: bool,\n+    #[serde(default)]\n+    pub collapsed: bool,\n+    #[serde(default)]\n+    pub controversiality: i32,\n+}\n+\n+/// Reddit's edit status - can be false or a timestamp\n+#[derive(Debug, Clone, Serialize, Deserialize)]\n+#[serde(untagged)]\n+pub enum RedditEditStatus {\n+    NotEdited(bool),\n+    EditedAt(f64),\n+}\n+\n+impl Default for RedditEditStatus {\n+    fn default() -> Self {\n+        RedditEditStatus::NotEdited(false)\n+    }\n+}\n+\n+// Helper functions for serde defaults\n+fn default_untitled() -> String {\n+    \"Untitled\".to_string()\n+}\n+\n+fn default_deleted_user() -> String {\n+    \"[deleted]\".to_string()\n+}\n+\n+// Custom deserializer for selftext (empty strings should be None)\n+fn deserialize_selftext<'de, D>(deserializer: D) -> Result<Option<String>, D::Error>\n+where\n+    D: serde::Deserializer<'de>,\n+{\n+    let s: Option<String> = Option::deserialize(deserializer)?;\n+    Ok(s.filter(|text| !text.is_empty()))\n+}\n+\n+// Custom deserializer for thumbnail (filter out \"self\", \"default\", empty)\n+fn deserialize_thumbnail<'de, D>(deserializer: D) -> Result<Option<String>, D::Error>\n+where\n+    D: serde::Deserializer<'de>,\n+{\n+    let s: Option<String> = Option::deserialize(deserializer)?;\n+    Ok(s.filter(|thumb| {\n+        !thumb.is_empty() && thumb != \"self\" && thumb != \"default\" && thumb != \"nsfw\" && thumb != \"spoiler\"\n+    }))\n+}\n+\n+// Helper methods for extracting typed data from Things\n+impl RedditThing {\n+    /// Try to get this Thing as a Post\n+    pub fn as_post(&self) -> Option<&RedditPost> {\n+        if self.kind != \"t3\" {\n+            return None;\n+        }\n+        match &self.data {\n+            RedditThingData::Post(post) => Some(post),\n+            _ => None,\n+        }\n+    }\n+    \n+    /// Try to get this Thing as a Comment\n+    pub fn as_comment(&self) -> Option<&RedditComment> {\n+        if self.kind != \"t1\" {\n+            return None;\n+        }\n+        match &self.data {\n+            RedditThingData::Comment(comment) => Some(comment),\n+            _ => None,\n+        }\n+    }\n+    \n+    /// Check if this is a \"more comments\" indicator\n+    pub fn is_more_comments(&self) -> bool {\n+        self.kind == \"more\"\n+    }\n+}\n+\n+// Helper methods for working with listing responses\n+impl RedditListingResponse {\n+    /// Extract all posts from this listing\n+    pub fn get_posts(&self) -> Vec<&RedditPost> {\n+        self.data.children.iter()\n+            .filter_map(|thing| thing.as_post())\n+            .collect()\n+    }\n+    \n+    /// Extract all comments from this listing\n+    pub fn get_comments(&self) -> Vec<&RedditComment> {\n+        self.data.children.iter()\n+            .filter_map(|thing| thing.as_comment())\n+            .collect()\n+    }\n+    \n+    /// Extract posts as owned values\n+    pub fn into_posts(self) -> Vec<RedditPost> {\n+        self.data.children.into_iter()\n+            .filter_map(|thing| {\n+                if thing.kind == \"t3\" {\n+                    match thing.data {\n+                        RedditThingData::Post(post) => Some(post),\n+                        _ => None,\n+                    }\n+                } else {\n+                    None\n+                }\n+            })\n+            .collect()\n+    }\n+    \n+    /// Extract comments as owned values\n+    pub fn into_comments(self) -> Vec<RedditComment> {\n+        self.data.children.into_iter()\n+            .filter_map(|thing| {\n+                if thing.kind == \"t1\" {\n+                    match thing.data {\n+                        RedditThingData::Comment(comment) => Some(comment),\n+                        _ => None,\n+                    }\n+                } else {\n+                    None\n+                }\n+            })\n+            .collect()\n+    }\n+}\n+\n+\n+\n\n\nSide B — contributor: tommy-mor\nSide B — commit message:\n[047b82bd] Remove redundant zero-ratio guard from reducer.\n\nZeros are already rejected at the DSL parser and browser handler;\nthe guard in apply_vote was dead code. The negative clamping stays\nsince add_edge_weight already skips weight-0 edges correctly.\n\nCo-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>\n\nSide B — unified diff (full patch):\ndiff --git a/server/src/reducer.rs b/server/src/reducer.rs\nindex 0e36979abe0f051493038ff7e652efc7f7a0ac80..efbf7f67ff24c7a2989102fe62879b2794a27c5f 100644\n--- a/server/src/reducer.rs\n+++ b/server/src/reducer.rs\n@@ -112,11 +112,6 @@ impl GroupState {\n         if vote.ratio_right < 0 {\n             vote.ratio_right = 0;\n         }\n-        if vote.ratio_left == 0 || vote.ratio_right == 0 {\n-            // Zero on either side produces no valid edge; drop before registering items or pair.\n-            return;\n-        }\n-\n         let a_idx = self.ensure_item(&vote.a);\n         let b_idx = self.ensure_item(&vote.b);\n \ndiff --git a/server/tests/basic.rs b/server/tests/basic.rs\nindex 08159f4a7f0850fd165817a4a1af4f31ced2ad76..1748769ccf7196b2d81cf556d5368c7e723f6a4e 100644\n--- a/server/tests/basic.rs\n+++ b/server/tests/basic.rs\n@@ -533,7 +533,7 @@ fn dsl_parse_rejects_zero_zero_vote_ratio() {\n #[test]\n fn reducer_negative_ratio_clamped_to_zero() {\n     let _state = ReducerState::default();\n-    // GroupState::apply_vote clamps negatives to 0; when either side is 0 the vote is dropped.\n+    // apply_vote clamps negatives to 0; add_edge_weight skips zero-weight edges.\n     let mut group = GroupState::new();\n     group.apply_vote(slugsocial_server::reducer::VoteData {\n         ts: 1,\n@@ -546,10 +546,9 @@ fn reducer_negative_ratio_clamped_to_zero() {\n         delegate: Some(\"00000000-0000-0000-0000-000000000000:test:local/test\".to_string()),\n         thread_tag: \"t\".to_string(),\n     });\n-    // Nothing registered: zero-clamped vote is dropped before ensure_item.\n-    assert!(group.idx_to_item.is_empty());\n+    // Items and pair are registered; edges are absent because weight 0 is skipped.\n+    assert_eq!(group.idx_to_item.len(), 2);\n     assert!(group.edges.is_empty());\n-    assert!(group.voted_pairs.is_empty());\n }\n \n \n","role":"user"}],"model":"~x-ai/grok-latest"}