constitution · epochs · watch · epoch 3

comparison

c_e4fb43f04791 (tommy-mor) vs c_28dfd8015c8a (tommy-mor)

download prompt · raw event · cmp_16fdb4d7ee55e4

council reasoning

openai/gpt-chat-latest · winner B · 4:1 · permalink

Side B replaces two manually maintained Kaocha test suites with a single auto-discovered `:all` suite using the `^test\..+` namespace pattern, so new test namespaces run automatically without editing `tests.edn`, reducing ongoing maintenance and preventing missed tests. Side A mostly removes a wrapping `section` from the vote-compare HTML and adjusts ranking-list CSS styling across themes, which is primarily structural and visual rather than a lasting functional improvement.

openai/gpt-5.3-chat · winner B · 3:1 · permalink

Side B replaces two manually enumerated Kaocha suites with a single auto-discovered suite using `:ns-patterns ["^test\\..+"]`, ensuring new tests run without config changes and preventing silent omissions. Side A mainly removes a wrapping `section.vote-compare-shell` and adds CSS styling for ranking lists, which is largely presentational and less impactful on long-term correctness or maintenance.

openai/gpt-5.2-chat · winner B · 3:1 · permalink

Side B replaces two manually enumerated Kaocha suites with a single auto-discovering `:all` suite using `^test\..+`, ensuring new `test.*` namespaces run automatically without editing `tests.edn`, which improves long-term test reliability and maintenance. Side A mainly removes a wrapping `section` in `garden.rs` and tweaks CSS for ranking list styling (font sizes, counters, layout), which are largely presentational changes without comparable impact on project correctness or workflow.

~anthropic/claude-sonnet-latest · winner B · 6:4 · permalink

Side B makes a small, clear infrastructure fix that removes a maintenance trap (manually enumerating test namespaces), ensuring new test files are auto-discovered — a lasting, low-risk improvement to CI reliability. Side A is mostly cosmetic: removing an unused wrapper section (dead HTML markup) and CSS tweaks to ranking-list bullet styling, which is minor polish rather than substantive functionality or bug fixing.

~x-ai/grok-latest · winner B · 3:1 · permalink

B replaces brittle hand-enumerated kaocha suites with a single auto-discovered ^test\..+ suite so new tests run without editing tests.edn—a lasting maintainability fix used by CI and TEST.sh. A mainly drops a vote-compare-shell wrapper and retouches ranking-list number CSS across themes, which is minor presentational cleanup with less durable project impact.

sides

A — c_e4fb43f04791 (tommy-mor)

message

[09842c93] remove shell

diff preview

diff --git a/server/src/html/garden.rs b/server/src/html/garden.rs
index 8fc6be1de8dd975f9547de615809222236be4b70..76ba96e45c9e16291a6ccd8096fdd01b274c1560 100644
--- a/server/src/html/garden.rs
+++ b/server/src/html/garden.rs
@@ -1321,55 +1321,53 @@ async fn vote_compare_inner(
     .expect("vote compare rpc json");
 
     let body = html! {
-        section class="vote-compare-shell" {
-            h2 { "compare" }
-            div class="vote-compare-pair" {
-                a class="vote-compare-item" href=(nav.garden_item_href(&left)) {
-                    code { (item_display_path(left.as_str())) }
-                }
-                span class="vote-compare-vs" { "vs" }
-                a class="vote-compare-item" href=(nav.garden_item_href(&right)) {
-                    code { (item_display_path(right.as_str())) }
-                }
-            }
-            div id="vote-edge-history-region" {
-                (edge_history)
-            }
-            @if can_post {
-                form id="vote-compare-form" method="POST" action="/ui" {
-                    input type="hidden" name=(UI_RPC_FIELD) value=(rpc_json);
-                    div class="vote-thread-picker" {
-                        label class="vote-thread-picker-label" { "thread" }
-                        select id="vote-thread-select" name="thread_tag" aria-label="Thread to post vote into" {
-                            @if thread_tags.is_empty() {
-                                option value="vote" selected { "#vote" }
-                            }
-                            @for t in &thread_tags {
-                                @if *t == auto_thread {
-                                    option value=(t) selected { "#" (t) }
-                                } @else {
-                                    option value=(t) { "#" (t) }
-                                }
-                            }
-                        }
+    h2 { "compare" }
+    div class="vote-compare-pair" {
+        a class="vote-compare-item" href=(nav.garden_item_href(&left)) {
+            code { (item_display_path(left.as_str())) }
+        }
+        span class="vote-compare-vs" { "vs" }
+        a class="vote-compare-item" href=(nav.garden_item_href(&right)) {
+            code { (item_display_path(right.as_str())) }
+        }
+    }
+    div id="vote-edge-history-region" {
+        (edge_history)
+    }
+    @if can_post {
+        form id="vote-compare-form" method="POST" action="/ui" {
+            input type="hidden" name=(UI_RPC_FIELD) value=(rpc_json);
+            div class="vote-thread-picker" {
+                label class="vote-thread-picker-label" { "thread" }
+                select id="vote-thread-select" name="thread_tag" aria-label="Thread to post vote into" {
+                    @if thread_tags.is_empty() {
+                        option value="vote" selected { "#vote" }
                     }
-                    input type="hidden" name="ratio_left" id="vote-ratio-left" value="50";
-                    input type="hidden" name="ratio_right" id="vote-ratio-right" value="50";
-                    label class="vote-compare-slider-label" {
-                        span id="vote-slider-left-label" { (item_display_path(left.as_str())) }
-                        input type="range" id="vote-preference-slider" min="0" max="100" value="50"
-                            aria-valuemin="0" aria-valuemax="100";
-                        span id="vote-slider-right-label" { (item_display_path(right.as_str())) }
+                    @for t in &thread_tags {
+                        @if *t == auto_thread {
+                            option value=(t) selected { "#" (t) }
+                        } @else {
+                            option value=(t) { "#" (t) }
+                        }
                     }
-                    label class="vote-explain-label" { "reason (required)" }
-                    textarea name="explanation" id="vote-explain" rows="5" placeholder="why this split?" required {}
-                    div id="vote-compare-errors" {}
-                    p { button type="submit" { "post vote" } }
                 }
-            } @else {
-                p class="muted" { a href="/login" { "log in" } " to post this vote." }
             }
+            input type="hidden" name="ratio_left" id="vote-ratio-left" value="50";
+            input type="hidden" name="ratio_right" id="vote-ratio-right" value="50";
+            label class="vote-compare-slider-label" {
+                span id="vote-slider-left-label" { (item_display_path(left.as_str())) }
+                input type="range" id="vote-preference-slider" min="0" max="100" value="50"
+                    aria-valuemin="0" aria-valuemax="100";
+                span id="vote-slider-right-label" { (item_display_path(right.as_str())) }
+            }
+            label class="vote-explain-label" { "reason (required)" }
+            textarea name="explanation" id="vote-explain" rows="5" placeholder="why this split?" required {}
+            div id="vote-compare-errors" {}
+            p { button type="submit" { "post vote" } }
         }
+    } @else {
+        p class="muted" { a href="/login" { "log in" } " to post this vote." }
+    }
     };
 
     let page = layout_full_bleed_chromeless(
diff --git a/server/static/theme_default.css b/server/static/theme_default.css
index a441c4f79d8cf88f5a8240f9992f47dbbd1ab46b..fdcde86c718eb53cce8273e45a9844c2d8041f88 100644
--- a/server/static/theme_default.css
+++ b/server/static/theme_default.css
@@ -1270,8 +1270,12 @@ body.view-ontology-dark .ont-ranking-list li {
 body.view-ontology-dark .ont-ranking-list li::before {
   color: var(--meta);
   content: counter(ont-rank) ".";
-  font-size: 11px;
-  min-width: 18px;
+  flex-shrink: 0;
+  font-size: 1.35rem;
+  font-weight: 700;
+  font-variant-numeric: tabular-nums;
+  line-height: 1;
+  min-width: 2.25ch;
   text-align: right;
 }
 body.view-ontology-dark .ont-rank-score {
@@ -1424,8 +1428,12 @@ body.view-ontology-light .ont-ranking-list li {
 body.view-ontology-light .ont-ranking-list li::before {
   color: var(--meta);
   content: counter(ont-rank) ".";
-  font-size: 11px;
-  min-width: 18px;
+  flex-shrink: 0;
+  font-size: 1.35rem;
+  font-weight: 700;
+  font-variant-numeric: tabular-nums;
+  line-height: 1;
+  min-width: 2.25ch;
   text-align: right;
 }
 body.view-ontology-light .ont-rank-score {
diff --git a/server/static/theme_retro.css b/server/static/theme_retro.css
index 373f15bbd75b62604cdd14b9f0fadda2d6176991..61e1448b2f66a075c0e33325d6980448712fc927 100644
--- a/server/static/theme_retro.css
+++ b/server/static/theme_retro.css
@@ -135,6 +135,30 @@ body.view-ontology nav.breadcrumb a:hover {
 body.view-ontology nav.breadcrumb a.bc-current { color: #111; font-weight: 600; }
 body.view-ontology nav.breadcrumb .bc-sep { color: #888; padding: 0 2px; }
 
+body.view-ontology ol.ont-ranking-list {
+  counter-reset: ont-rank;
+  list-style: none;
+  margin: 0.5rem 0;
+  padding: 0;
+}
+body.view-ontology ol.ont-ranking-list li {
+  align-items: baseline;
+  counter-increment: ont-rank;
+  display: flex;
+  gap: 0.35rem;
+}
+body.view-ontology ol.ont-ranking-list li::before {
+  flex-shrink: 0;
+  color: #666;
+  content: counter(ont-rank) ".";
+  font-size: 1.35rem;
+  font-weight: 700;
+  font-variant-numeric: tabular-nums;
+  line-height: 1;
+  min-width: 2.25ch;
+  text-align: right;
+}
+
 nav.breadcrumb.ont-sibling-nav {
   margin-top: 0;
   width: 100%;
diff --git a/server/static/theme_retro_craft.css b/server/static/theme_retro_craft.css
index 6eb9222184a8795d67a5d09d41de08c8ac1b148f..7da102040484c887833158a37c307d078205c701 100644
--- a/server/static/theme_retro_craft.css
+++ b/server/static/theme_retro_craft.css
@@ -742,12 +742,32 @@ body.view-ontology button.ont-garden-pin-ico:focus-visible {
   outline-offset: 2px;
 }
 
+body.view-ontology ol.ont-ranking-list {
+  counter-reset: ont-rank;
+  list-style: none;
+  margin: 0;
+  padding: 0;
+}
 body.view-ontology ol.ont-ranking-list li,
 body.view-ontology ul.ont-group-list li {
   display: flex;
   align-items: baseline;
   gap: 0.35rem;
 }
+body.view-ontology ol.ont-ranking-list li {
+  counter-increment: ont-rank;
+}
+body.view-ontology ol.ont-ranking-list li::before {
+  flex-shrink: 0;
+  color: #5c574e;
+  content: counter(ont-rank) ".";
+  font-size: 1.35rem;
+  font-weight: 700;
+  font-variant-numeric: tabular-nums;
+  line-height: 1;
+  min-width: 2.25ch;
+  text-align: right;
+}
 body.view-ontology ol.ont-ranking-list li .item-link,
 body.view-ontology ul.ont-group-list li .item-link {
   flex: 1;

download full diff A

B — c_28dfd8015c8a (tommy-mor)

message

[0bebe819] Unify kaocha test discovery to one auto-discovered suite.

Replace the two hand-enumerated suites (:http-integration, :browser) with
a single :all suite that picks up every test.* namespace under test/. New
test files now run automatically without touching tests.edn — needed for
the test.ranking namespace added alongside the #146 fix, and for any
future tests.

Both ./TEST.sh and CI (.github/workflows/ci.yml) invoke
`clojure -M:kaocha`, so both pick up the new suite without changes.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

diff preview

diff --git a/tests.edn b/tests.edn
index 5e2b0433a66c51806d08ef38d691259cfccd1fe0..e51ffcc81eeae6f41c85d1bfc5ba32f592cc5818 100644
--- a/tests.edn
+++ b/tests.edn
@@ -1,30 +1,14 @@
 #kaocha/v1
-{:tests
- [{:id :http-integration
-   :test-paths ["test"]
-   :source-paths ["."]
-   :ns-patterns ["^test\\.integration$"
-                 "^test\\.auth$"
-                 "^test\\.grants$"
-                 "^test\\.invites$"
-                 "^test\\.room-list$"]
-   :kaocha.filter/skip-meta [:skip]
-   :parallel? false}
-  {:id :browser
-   :test-paths ["test"]
-   :source-paths ["."]
-   :ns-patterns ["^test\\.browser-sse$"
-                 "^test\\.browser-ui-morph$"
-                 "^test\\.browser-post-redact$"
-                 "^test\\.browser-room-delete$"
-                 "^test\\.browser-public-garden$"
-                 "^test\\.browser-redact-thread-index$"
-                 "^test\\.browser-garden-pin$"
-                 "^test\\.browser-vote-compare$"
-                 "^test\\.browser-github-resolver$"]
-   :kaocha.filter/skip-meta [:skip]
-   :parallel? false}]
- :plugins [:kaocha.plugin/junit-xml]
- :kaocha.plugin.junit-xml/target-file "target/kaocha-junit.xml"
- :kaocha.plugin.junit-xml/add-location-metadata? true
- :reporter kaocha.report.progress/report}
+ {:tests
+  [{:id :all
+    :test-paths ["test"]
+    :source-paths ["."]
+   ;; Pick up every test.* namespace under test/. New files don't need to be
+   ;; enumerated here — drop them in test/ with `(ns test.foo …)` and they run.
+    :ns-patterns ["^test\\..+"]
+    :kaocha.filter/skip-meta [:skip]
+    :parallel? false}]
+  :plugins [:kaocha.plugin/junit-xml]
+  :kaocha.plugin.junit-xml/target-file "target/kaocha-junit.xml"
+  :kaocha.plugin.junit-xml/add-location-metadata? true
+  :reporter kaocha.report.progress/report}

download full diff B

Hardlinks — judgments / attempts / prompt

prompt download

judgments

attempts

Prompt text is loaded only by the download route.