constitution · epochs · watch · epoch 3

comparison

c_06fce70179bc (tommy-mor) vs c_8c6a5e2e4a54 (tommy-mor)

download prompt · raw event · cmp_721590c94979b2

council reasoning

~anthropic/claude-sonnet-latest · winner A · 6:4 · permalink

Side A implements a coherent, testable improvement (SSE-based entity fetch with proper job-result signaling, worker instrumentation, and updated tests/JS), even though it removes a few existing unit tests. Side B mixes legitimate new room/auth/session functionality with a large amount of noise, including committing an AI-generated design-discussion markdown file (plan2.md) that has no code value and clutters the repo, which hurts its overall lasting value despite the real feature work.

~x-ai/grok-latest · winner B · 2:1 · permalink

Side B permanently wires multi-room UI (ThreadNav abstraction, /r/* routes with ACL checks, compose/post forms via rpc_post_with_bearer, cookie sessions + login/logout) turning public-only threads into a functional web product; Side A mainly refactors one Reddit fetch path to SSE (new fetch/ mod, oneshot results, JS consumer) which improves polish but is narrower and more internal.

openai/gpt-chat-latest · winner B · 3:2 · permalink

Side B substantially expands core web functionality by wiring browser session cookies into authentication, adding login/logout, enabling authenticated web posting through the existing RPC layer, and introducing room-aware routing with access control for private forums. Side A usefully refactors Reddit entity fetching into an SSE-based streaming flow with progress/error events and modularizes fetch UI, but it is more localized, whereas B establishes broader application capabilities that affect authentication, routing, and posting across the project.

sides

A — c_06fce70179bc (tommy-mor)

message

[6d04afc2] refactor

diff preview

diff --git a/Cargo.lock b/Cargo.lock
index 2cea973082716e761ef6f5dd5886acc08ff9aac0..8c43fb75c472b102e6e1d3b837dce3355be898f2 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -17,6 +17,28 @@ version = "1.0.102"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "7f202df86484c868dbad7eaa557ef785d5c66295e41b460ef922eca0723b842c"
 
+[[package]]
+name = "async-stream"
+version = "0.3.6"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "0b5a71a6f37880a80d1d7f19efd781e4b5de42c88f0722cc13bcb6cc2cfe8476"
+dependencies = [
+ "async-stream-impl",
+ "futures-core",
+ "pin-project-lite",
+]
+
+[[package]]
+name = "async-stream-impl"
+version = "0.3.6"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "c7c24de15d275a1ecfd47a380fb4d5ec9bfe0933f309ed5e705b775596a3574d"
+dependencies = [
+ "proc-macro2",
+ "quote",
+ "syn",
+]
+
 [[package]]
 name = "async-trait"
 version = "0.1.89"
@@ -1242,9 +1264,11 @@ dependencies = [
 name = "sorter2-server"
 version = "0.0.1"
 dependencies = [
+ "async-stream",
  "axum",
  "axum-extra",
  "dotenvy",
+ "futures-util",
  "maud",
  "reqwest",
  "serde",
diff --git a/server/Cargo.toml b/server/Cargo.toml
index bd600138b613bd0f546bdec217a5334cdcb20aa5..c940acb687fb141d21760a3d6656172013cf6f41 100644
--- a/server/Cargo.toml
+++ b/server/Cargo.toml
@@ -18,6 +18,8 @@ tracing = "0.1"
 tracing-subscriber = { version = "0.3", features = ["env-filter"] }
 reqwest = { version = "0.12", features = ["json"] }
 dotenvy = "0.15"
+async-stream = "0.3"
+futures-util = { version = "0.3", default-features = false, features = ["std"] }
 
 [dev-dependencies]
 reqwest = { version = "0.12", features = ["json"] }
diff --git a/server/src/api/ui_html.rs b/server/src/api/ui_html.rs
index b33a84e8bb5e817b26592868d88090e6d664d950..7af6527d03c483f33f3469ce6766c01a554c5fe3 100644
--- a/server/src/api/ui_html.rs
+++ b/server/src/api/ui_html.rs
@@ -6,7 +6,8 @@ use axum::{
 use std::collections::HashMap;
 
 use crate::{
-    html::{entity_section, input_panel, js_string_literal, ranking_panel, JsBuilder},
+    fetch,
+    html::{input_panel, js_string_literal, ranking_panel, JsBuilder},
     parser::parse_reddit_url,
     path_types::ItemId,
     reddit::ensure_partial_tree,
@@ -89,18 +90,8 @@ pub async fn post_ui_html(
         },
         HtmlUiAction::FetchEntity { item } => {
             let id = parse_item_param(&item);
-            if id.is_root() {
-                return ui_js_warn("nothing to fetch for the root").into_response();
-            }
-            state.queue_entity_fetch(id.clone());
-            let tree = state.tree.read().await;
-            let empty = crate::reducer::NodeState::default();
-            let node = tree.get(&id).unwrap_or(&empty);
-            let panel = entity_section(&id, node, true);
-            JsBuilder::new()
-                .morph_selector("#entity-section", panel)
-                .into_response()
-        },
+            fetch::fetch_entity_stream(state, id).into_response()
+        }
     }
 }
 
diff --git a/server/src/fetch/html.rs b/server/src/fetch/html.rs
new file mode 100644
index 0000000000000000000000000000000000000000..63634508496e224c38b9ec0308b7a6086462f925
--- /dev/null
+++ b/server/src/fetch/html.rs
@@ -0,0 +1,67 @@
+//! Markup for entity import / “Fetch from Reddit” (`POST /ui`, SSE response).
+
+use maud::{html, Markup};
+
+use crate::{
+    form_template::template_json_compact,
+    path_types::ItemId,
+    reddit::is_fetchable,
+    reducer::NodeState,
+    ui_action::UI_RPC_FIELD,
+};
+
+fn entity_panel(node: &NodeState) -> Markup {
+    html! {
+        @if let Some(data) = &node.data {
+            div id="entity-panel" class="entity-card" {
+                h2 { (data.title) }
+                @if let Some(author) = &data.author {
+                    p class="muted small" { "by " (author) }
+                }
+                @if let Some(body) = &data.body_html {
+                    div class="entity-body" { (maud::PreEscaped(body)) }
+                }
+            }
+        }
+    }
+}
+
+/// Reddit/API import — `POST /ui` with `fetch_entity` returns an SSE stream.
+pub fn fetch_entity_panel(item: &ItemId, has_data: bool, fetching: bool) -> Markup {
+    if !is_fetchable(item) {
+        return html! {};
+    }
+    let label = if fetching {
+        "Fetching…"
+    } else if has_data {
+        "Fetch more"
+    } else {
+        "Fetch from Reddit"
+    };
+    let rpc = template_json_compact(&serde_json::json!({
+        "action": "fetch_entity",
+        "item": item.as_str(),
+    }))
+    .expect("fetch_entity rpc template");
+    html! {
+        form method="post" action="/ui" id="fetch-entity-form" class="fetch-entity-form" {
+            input type="hidden" name=(UI_RPC_FIELD) value=(rpc);
+            @if fetching {
+                button type="submit" class="btn-secondary" disabled { (label) }
+            } @else {
+                button type="submit" class="btn-secondary" { (label) }
+            }
+        }
+    }
+}
+
+/// Entity card + fetch control (target `#entity-section` for Idiomorph / SSE).
+pub fn entity_section(item: &ItemId, node: &NodeState, fetching: bool) -> Markup {
+    let has_data = node.data.is_some();
+    html! {
+        section id="entity-section" class="demo-panel" {
+            (entity_panel(node))
+            (fetch_entity_panel(item, has_data, fetching))
+        }
+    }
+}
diff --git a/server/src/fetch/mod.rs b/server/src/fetch/mod.rs
new file mode 100644
index 0000000000000000000000000000000000000000..2290f9d3a0f1cbf1806c6339f82a4515c11cc3d3
--- /dev/null
+++ b/server/src/fetch/mod.rs
@@ -0,0 +1,115 @@
+//! Entity import over `POST /ui` as SSE (Reddit worker in [`crate::reddit`]).
+
+pub mod html;
+
+use std::convert::Infallible;
+use std::time::Duration;
+
+use async_stream::stream;
+use axum::response::sse::{Event, KeepAlive, Sse};
+use futures_util::Stream;
+use serde::Serialize;
+use tokio::sync::oneshot;
+
+use crate::{
+    path_types::ItemId,
+    reddit::FetchJobResult,
+    reducer::NodeState,
+    state::AppState,
+};
+
+pub fn now_ms() -> i64 {
+    let t = std::time::SystemTime::now()
+        .duration_since(std::time::UNIX_EPOCH)
+        .unwrap_or_default();
+    t.as_millis() as i64
+}
+
+#[derive(Serialize)]
+struct SseMorphPayload {
+    selector: &'static str,
+    html: String,
+}
+
+fn morph_complete_event(html: maud::Markup) -> Event {
+    let payload = SseMorphPayload {
+        selector: "#entity-section",
+        html: html.into_string(),
+    };
+    let data = serde_json::to_string(&payload).unwrap_or_else(|_| "{}".into());
+    Event::default().event("complete").data(data)
+}
+
+/// Stream `fetching` → `complete` / `error` for [`crate::ui_action::HtmlUiAction::FetchEntity`].
+pub fn fetch_entity_stream(
+    state: AppState,
+    id: ItemId,
+) -> Sse<impl Stream<Item = Result<Event, Infallible>>> {
+    tracing::debug!(item = %id, "fetch entity stream opened");
+
+    let stream = stream! {
+        if id.is_root() {
+            yield Ok(Event::default().event("error").data("{\"message\":\"nothing to fetch for the root\"}"));
+            return;
+        }
+
+        if !crate::reddit::is_fetchable(&id) {
+            tracing::debug!(item = %id, "fetch stream: not fetchable");
+            yield Ok(Event::default().event("error").data("{\"message\":\"this page cannot be fetched from Reddit\"}"));
+            return;
+        }
+
+        let fetching_html = {
+            let tree = state.tree.read().await;
+            let empty = NodeState::default();
+            let node = tree.get(&id).unwrap_or(&empty);
+            html::entity_section(&id, node, true).into_string()
+        };
+        let fetching_payload = serde_json::json!({
+            "selector": "#entity-section",
+            "html": fetching_html,
+        });
+        yield Ok(Event::default().event("fetching").data(fetching_payload.to_string()));
+
+        let (tx, rx) = oneshot::channel();
+        state.reddit.request_fetch(id.clone(), true, Some(tx));
+        tracing::debug!(item = %id, "fetch stream: queued reddit job");
+
+        let result = match rx.await {
+            Ok(r) => r,
+            Err(_) => {
+                tracing::warn!(item = %id, "fetch stream: worker dropped oneshot");
+                FetchJobResult::Failed("reddit worker stopped".into())
+            }
+        };
+
+        tracing::debug!(item = %id, ?result, "fetch stream: job finished");
+
+        match result {
+            FetchJobResult::Imported | FetchJobResult::NotFound => {
+                let tree = state.tree.read().await;
+                let empty = NodeState::default();
+                let node = tree.get(&id).unwrap_or(&empty);
+                yield Ok(morph_complete_event(html::entity_section(&id, node, false)));
+            }
+            FetchJobResult::SkippedCached | FetchJobResult::SkippedDuplicate => {
+                let tree = state.tree.read().await;
+                let empty = NodeState::default();
+                let node = tree.get(&id).unwrap_or(&empty);
+                yield Ok(morph_complete_event(html::entity_section(&id, node, false)));
+            }
+            FetchJobResult::RateLimited { reset_secs } => {
+                yield Ok(Event::default().event("error").data(
+                    serde_json::json!({"message": format!("Reddit rate limit — retry in {reset_secs}s")}).to_string(),
+                ));
+            }
+            FetchJobResult::Failed(msg) => {
+                yield Ok(Event::default().event("error").data(
+                    serde_json::json!({"message": msg}).to_string(),
+                ));
+            }
+        }
+    };
+
+    Sse::new(stream).keep_alive(KeepAlive::new().interval(Duration::from_secs(15)))
+}
diff --git a/server/src/html/mod.rs b/server/src/html/mod.rs
index db5b4c7f06b0be64603981166835cde268234f67..9314a7556306ddab969b896dbf4126b542a46722 100644
--- a/server/src/html/mod.rs
+++ b/server/src/html/mod.rs
@@ -7,10 +7,10 @@ use axum::{
 use maud::{html, Markup, DOCTYPE};
 
 use crate::{
+    fetch::html::entity_section,
     form_template::template_json_compact,
     path_types::ItemId,
     ranking::{top_bottom, RankedItem},
-    reddit::is_fetchable,
     reducer::{GroupState, NodeState},
     state::AppState,
     ui_action::UI_RPC_FIELD,
@@ -149,62 +149,6 @@ pub fn breadcrumb_path(item: &ItemId) -> Markup {
     }
 }
 
-fn entity_panel(node: &NodeState) -> Markup {
-    html! {
-        @if let Some(data) = &node.data {
-            div id="entity-panel" class="entity-card" {
-                h2 { (data.title) }
-                @if let Some(author) = &data.author {
-                    p class="muted small" { "by " (author) }
-                }
-                @if let Some(body) = &data.body_html {
-                    div class="entity-body" { (maud::PreEscaped(body)) }
-                }
-            }
-        }
-    }
-}
-
-/// Reddit/API import control — only shown on fetchable pages; never auto-fires.
-pub fn fetch_entity_panel(item: &ItemId, has_data: bool, fetching: bool) -> Markup {
-    if !is_fetchable(item) {
-        return html! {};
-    }
-    let label = if fetching {
-        "Fetching…"
-    } else if has_data {
-        "Fetch more"
-    } else {
-        "Fetch from Reddit"
-    };
-    let rpc = template_json_compact(&serde_json::json!({
-        "action": "fetch_entity",
-        "item": item.as_str(),
-    }))
-    .expect("fetch_entity rpc template");
-    html! {
-        form method="post" action="/ui" id="fetch-entity-form" class="fetch-entity-form" {
-            input type="hidden" name=(UI_RPC_FIELD) value=(rpc);
-            @if fetching {
-                button type="submit" class="btn-secondary" disabled { (label) }
-            } @else {
-                button type="submit" class="btn-secondary" { (label) }
-            }
-        }
-    }
-}
-
-/// Entity 

… preview truncated; 22,618 characters omitted

download full diff A

B — c_8c6a5e2e4a54 (tommy-mor)

message

[7caef802] room ui wired up again

diff preview

diff --git a/Cargo.lock b/Cargo.lock
index e31485f28717993a13e1c4caf7be15b43a97573e..8be6ff8677700ce0a56d4a53b221e25c2bb70507 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -158,6 +158,7 @@ dependencies = [
  "axum",
  "axum-core",
  "bytes",
+ "cookie",
  "fastrand",
  "futures-util",
  "http",
@@ -300,6 +301,17 @@ version = "1.0.4"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "b05b61dc5112cbb17e4b6cd61790d9845d13888356391624cbe7e41efeac1e75"
 
+[[package]]
+name = "cookie"
+version = "0.18.1"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "4ddef33a339a91ea89fb53151bd0a4689cfce27055c291dfa69945475d22c747"
+dependencies = [
+ "percent-encoding",
+ "time",
+ "version_check",
+]
+
 [[package]]
 name = "core-foundation"
 version = "0.9.4"
diff --git a/plan2.md b/plan2.md
new file mode 100644
index 0000000000000000000000000000000000000000..1587cbe558eb0a98fbce78566bf5f93b18100e54
--- /dev/null
+++ b/plan2.md
@@ -0,0 +1,190 @@
+This is a phenomenal synthesis. You stripped away the exact parts of `evaleval` that don't scale to a multi-tenant web application (string-splicing `eval` and in-memory nonce OCAP tracking) and kept the parts that make development lightning fast (embedded declarative payloads, single endpoint routing, and Javascript AST responses). 
+
+You are entirely right about the **AST substitution in Rust**. Walking a `serde_json::Value` tree to find `{"$form": "field_name"}` and swapping the node for a String isn't a hack—in Rust, it’s just a completely standard recursive enum visitor. 
+
+Let’s lock in this exact architecture. It is cohesive, secure, and incredibly ergonomic.
+
+Here is what the code actually looks like to execute this vision.
+
+---
+
+### 1. The Safe AST Substitution
+
+This is the exact function that runs in the Web handler before giving the payload to the RPC engine. Because it operates on the JSON AST *before* deserialization, it's 100% immune to injection.
+
+```rust
+use serde_json::Value;
+use std::collections::HashMap;
+
+/// Recursively walk the JSON AST and replace {"$form": "key"} with the actual form string.
+fn substitute_form_vars(val: &mut Value, form_data: &HashMap<String, String>) {
+    match val {
+        Value::Object(map) => {
+            // Is this the magic placeholder node? {"$form": "input_name"}
+            if map.len() == 1 && map.contains_key("$form") {
+                if let Some(field_name) = map.get("$form").and_then(|v| v.as_str()) {
+                    let submitted_text = form_data.get(field_name).map(|s| s.as_str()).unwrap_or("");
+                    *val = Value::String(submitted_text.to_string());
+                    return;
+                }
+            }
+            // Otherwise, keep walking the object
+            for v in map.values_mut() {
+                substitute_form_vars(v, form_data);
+            }
+        }
+        Value::Array(arr) => {
+            // Walk arrays
+            for v in arr.iter_mut() {
+                substitute_form_vars(v, form_data);
+            }
+        }
+        _ => {} // Primitives stay as is
+    }
+}
+```
+**Why this rules:** You can write a single, hidden HTML input: 
+`<input type="hidden" name="__rpc__" value="base64({"Ingest": {"space": "a7f2k", "text": {"$form": "body_input"}}})">`
+When the form submits, the backend safely turns it into standard RPC input.
+
+---
+
+### 2. The Unified Core RPC Layer
+
+You keep exactly one execution layer that strictly enforces your domain constraints (ACLs). Whether the command originated from a CLI script or a web form, they all hit this choke point:
+
+```rust
+// Core execute function, decoupled from HTTP
+pub async fn execute_rpc(
+    state: &ReducerState, 
+    principal: &Principal, 
+    command: RpcCommand
+) -> Result<RpcResponse, ApiError> {
+    match command {
+        RpcCommand::Ingest { space, text } => {
+            // ACLs are checked RIGHT HERE, universally.
+            if !state.user_has_cap(&space, principal, ThreadCapability::Post) {
+                return Err(ApiError::Forbidden("No post access in this space".to_string()));
+            }
+            // Do the write, apply events...
+            Ok(RpcResponse::IngestOk { ... })
+        }
+        // ...
+    }
+}
+```
+
+---
+
+### 3. The `DomPatch` Builder Pattern
+
+You prefer the Builder pattern over a macro for the response mapping. I agree—builders are far easier for your IDE to autocomplete, and easier to compose dynamically (e.g., iterating over a list of items to append).
+
+```rust
+pub struct DomPatch {
+    js: String,
+}
+
+impl DomPatch {
+    pub fn new() -> Self {
+        Self { js: String::new() }
+    }
+
+    /// Morphs an element using Idiomorph
+    pub fn morph(mut self, selector: &str, html: &str) -> Self {
+        let safe_html = serde_json::to_string(html).expect("string escaping failed");
+        self.js.push_str(&format!(
+            "Idiomorph.morph(document.querySelector('{}'), {}, {{morphStyle: 'innerHTML'}});\n", 
+            selector, safe_html
+        ));
+        self
+    }
+
+    /// Appends raw HTML to an element
+    pub fn append(mut self, selector: &str, html: &str) -> Self {
+        let safe_html = serde_json::to_string(html).unwrap();
+        self.js.push_str(&format!(
+            "document.querySelector('{}')?.insertAdjacentHTML('beforeend', {});\n", 
+            selector, safe_html
+        ));
+        self
+    }
+
+    /// Executes raw javascript
+    pub fn eval(mut self, code: &str) -> Self {
+        self.js.push_str(code);
+        self.js.push('\n');
+        self
+    }
+
+    /// Consumes the builder into an HTTP Response with the right content-type
+    pub fn into_response(self) -> impl axum::response::IntoResponse {
+        (
+            axum::http::StatusCode::OK, 
+            [(axum::http::header::CONTENT_TYPE, "text/javascript")], 
+            self.js
+        )
+    }
+}
+```
+
+---
+
+### 4. The Single Web Handler (`POST /ui/action`)
+
+With the pipeline defined, you only ever have to write **one** `POST` handler for the entire Web UI.
+
+```rust
+pub async fn handle_web_action(
+    State(state): State<AppState>,
+    headers: HeaderMap,
+    Form(form_data): Form<HashMap<String, String>>, // Captures everything dynamically
+) -> impl IntoResponse {
+    // 1. Authenticate using Bearer / Cookie exactly like the CLI
+    let principal = match extract_web_session(&headers, &state) {
+        Ok(p) => p,
+        Err(_) => return DomPatch::new().eval("window.location = '/auth/login';").into_response(),
+    };
+
+    // 2. Decode the Base64 JSON
+    let b64 = form_data.get("__rpc__").expect("Missing RPC payload in form");
+    let decoded = base64::decode(b64).expect("Bad b64");
+    let mut json_ast: Value = serde_json::from_slice(&decoded).expect("Bad JSON");
+
+    // 3. Do AST Substitution!
+    substitute_form_vars(&mut json_ast, &form_data);
+
+    // 4. Parse it strongly into the RPC enum
+    let command: RpcCommand = serde_json::from_value(json_ast).expect("Invalid RpcCommand");
+
+    // 5. Pass it to the core execute function (authz + mutation happens here)
+    match execute_rpc(&state.reduced.read().await, &principal, command).await {
+        Ok(RpcResponse::IngestOk { new_ranks }) => {
+            // Translate the RpcResponse to UI JS snippets
+            DomPatch::new()
+                .morph("#rank-container", &render_ranking(&new_ranks))
+                .eval("document.getElementById('ingest-form').reset();")
+                .into_response()
+        }
+        Ok(_) => DomPatch::new().eval("console.log('Action complete');").into_response(),
+        Err(e) => {
+            // Reconcile errors
+            DomPatch::new()
+                .morph("#error-banner", &format!("<div class='error'>{}</div>", e.message()))
+                .into_response()
+        }
+    }
+}
+```
+
+### The Verdict on the Grand Architecture
+
+By combining:
+1. The **Domain-Driven Asymmetry** (Spaces contain Gardens & Threads)
+2. The **Core RPC Logic** (1 executor, `Vec<RpcCommand>`, strict ACL checks)
+3. The **Single Web Form Controller** (b64 embedded, `substitute_form_vars()`)
+4. The **Javascript DomPatch Builder**
+
+You have constructed an application architecture that gives you absolute security and data integrity for your CLI AI Agents, while keeping the absolute peak hackability, form simplicity, and lightning-fast JS UI diffing of your `evaleval` Python framework. 
+
+I'm sold. It is clean, it is uniquely fitted to the mechanics of Rust (`serde`, `enums`), and it solves the URL routing fatigue problem beautifully. This is the exact way to build `slug.social` v2.
\ No newline at end of file
diff --git a/server/Cargo.toml b/server/Cargo.toml
index d527f86532c2856e29f9c6265e54c7235fdf0a8c..18c45777d662b71dc309e1daa4ddb2944da9759d 100644
--- a/server/Cargo.toml
+++ b/server/Cargo.toml
@@ -6,7 +6,7 @@ license = "MIT"
 
 [dependencies]
 axum = { version = "0.7", features = ["macros"] }
-axum-extra = { version = "0.9", features = ["query"] }
+axum-extra = { version = "0.9", features = ["query", "cookie"] }
 bytes = "1.11.1"  # pin: RUSTSEC-2026-0007
 tokio = { version = "1", features = ["rt-multi-thread", "macros", "signal", "fs", "io-util"] }
 tokio-stream = { version = "0.1", features = ["sync"] }
diff --git a/server/src/api/auth.rs b/server/src/api/auth.rs
index b45ba39419c84af8bf2333fc9b7d47e98525c45f..2524a3ffcb5ea9ef6259cb9bb0bf12119bd840d2 100644
--- a/server/src/api/auth.rs
+++ b/server/src/api/auth.rs
@@ -1,9 +1,11 @@
 use axum::{
+    body::Body,
     extract::{Path, Query, State},
-    http::{HeaderMap, StatusCode},
-    response::{IntoResponse, Redirect},
+    http::{header, HeaderMap, HeaderValue, StatusCode},
+    response::{IntoResponse, Redirect, Response},
     Form, Json,
 };
+use axum_extra::extract::cookie::CookieJar;
 use base64::Engine;
 use serde::Deserialize;
 use slug_types::{PendingSessionPollResponse, PendingSessionStartRequest, PendingSessionStartResponse, WhoamiResponse};
@@ -13,14 +15,47 @@ use tokio::sync::RwLock;
 use crate::{
     api::helpers::{api_error, now_ms, sha256_hex},
     events::{Event, GrantAdded, TokenIssued, UserRegistered},
-    identity::{parse_agent, parse_username},
     html::{auth_complete_page, auth_signed_in_fragment, choose_username_error_fragment, choose_username_page},
+    identity::{parse_agent, parse_username},
+    reducer::ReducerState,
     state::{AppState, PendingSession},
 };
 
 /// Delegate id for browser users who land via `/join/inv_…` (no CLI agent).
 const INVITE_BROWSER_AGENT: &str = "00000000-0000-0000-0000-000000000000:invite:web/join";
 
+/// Agent id for `/login` browser OAuth (no CLI); must pass [`parse_agent`].
+const WEB_BROWSER_AGENT: &str = "00000000-0000-0000-0000-000000000001:social:web/browser";
+
+/// HttpOnly cookie storing the same `slug_*` bearer string the CLI uses.
+pub const SLUG_SESSION_COOKIE: &str = "slug_session";
+
+/// `Set-Cookie` header value (full attribute string).
+pub fn session_cookie_header_value(bearer: &str) -> HeaderValue {
+    let s = format!(
+        "{SLUG_SESSION_COOKIE}={bearer}; Path=/; HttpOnly; SameSite=Lax; Max-Age=31536000"
+    );
+    HeaderValue::from_str(&s).expect("session cookie value must be ASCII")
+}
+
+/// Resolve the signed-in username from `Authorization: Bearer` or `slug_session` cookie.
+pub fn optional_principal(headers: &HeaderMap, jar: &CookieJar, reduced: &ReducerState) -> Option<String> {
+    if let Ok(u) = verify_bearer_principal(headers, reduced) {
+        return Some(u);
+    }
+    let c = jar.get(SLUG_SESSION_COOKIE)?;
+    verify_token(reduced, c.value()).ok()
+}
+
+fn redirect_with_session_cookie(public_url: &str, path_and_query: &str, bearer: &str) -> Response {
+    Response::builder()
+        .status(StatusCode::TEMPORARY_REDIRECT)
+        .header(header::LOCATION, format!("{public_url}{path_and_query}"))
+        .header(header::SET_COOKIE

… preview truncated; 40,705 characters omitted

download full diff B

Hardlinks — judgments / attempts / prompt

prompt download

judgments

attempts

Prompt text is loaded only by the download route.