You are a constitutional council ranking individual git commits for ownership allocation. Compare these two commits. Decide which contributed more lasting value to the project. Judge substance, not spectacle: - Prefer correct, lasting design and real bugfixes over churn, formatting, renames, or generated noise. - Prefer clarity and necessity over sheer line count. A small precise change can beat a large diffuse one. - Do not favor a side merely because its patch is longer or noisier. - Weight what the change does for the project, not the contributor's name. Return ONLY a JSON object: {"winner": "A" or "B", "ratio": "N:M", "explanation": "..."} The explanation must cite concrete differences in the patches (1-3 sentences). Side A — contributor: tommy-mor Side A — commit message: [880eb778] Harden auth: fail-closed votes, mock OAuth gate, Secure cookies. Also show the current alias in the top nav and pin durable by rev. Co-authored-by: Cursor Side A — unified diff (full patch): diff --git a/AGENTS.md b/AGENTS.md index babb889d6fbfb1fa7176c9e6b7544ae17b61dd2e..6e0fd8ebb65d665c9c1438e3275971d62b98fd95 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -10,11 +10,11 @@ Single Rust web app **`sorter2-server`**: pairwise voting, rank-centrality ranki - **Bootstrap script**: `./scripts/cursor-env-install.sh` (also run via `.cursor/environment.json` on Cloud Agent boot) installs Playwright Chromium, Babashka, bbin, `clj-paren-repair`, and warms the RocksDB build. - **Rust 1.88+** is required (`rust-toolchain.toml`). The Cloud Dockerfile and `cursor-env-install.sh` install **rustup** 1.88.0 first so `cargo` works while Playwright/Clojure bootstrap continues. Do not rely on `/usr/local/cargo` (often missing or stale). -- **RocksDB / `durable`**: Ubuntu’s default `c++` is often **clang** without libc++ headers. Set **`CXX=g++`** and **`RUSTFLAGS="-C linker=g++"`** (or `CC=gcc`) before `cargo build` / `cargo test` — both are set in the bootstrap script and `.cursor/environment.json`. +- **RocksDB / `durable`**: `durable` is an external git dependency (`tommy-mor/durable`, pinned by rev in `server/Cargo.toml`). Ubuntu’s default `c++` is often **clang** without libc++ headers. Set **`CXX=g++`** and **`RUSTFLAGS="-C linker=g++"`** (or `CC=gcc`) before `cargo build` / `cargo test` — both are set in the bootstrap script and `.cursor/environment.json`. - **System packages** for builds: `build-essential`, `g++`, `clang`, `libclang-dev`, `pkg-config`, `libssl-dev`, `openjdk-21-jre-headless` (for `reqwest` / OpenSSL, `librocksdb-sys`, `zstd-sys` / bindgen, and **bbin** / Clojure JVM). The bootstrap sets **`JAVA_HOME`** when Java is present. - **Clojure CLI 1.12.0.1530** (used in CI): install from https://clojure.org/guides/install_clojure — needed for `./scripts/clj-test.sh` / Kaocha tests. - **Babashka / bbin / clj-paren-repair**: installed by `cursor-env-install.sh` into `~/.local/bin` (bb tasks in `bb.edn`, delimiter repair for Clojure edits). -- **Playwright** (Spel browser tests in `test/vote_compare.clj`): Chromium via `clojure -M -e "(com.microsoft.playwright.CLI/main ...)"` — run once after clone or use the bootstrap script. +- **Playwright** (Spel browser tests in `test/vote_compare.clj` / `test/auth_login.clj`): Chromium via `clojure -M -e "(com.microsoft.playwright.CLI/main ...)"` — run once after clone or use the bootstrap script. ### Commands (see also `TEST.sh`) @@ -34,13 +34,17 @@ Environment variables (defaults in `server/src/state.rs`): - `PORT` — default `8080` - `SORTER2_DATA_DIR` — default `./data` (created on startup) - `SORTER2_EVENT_LOG` — default `{data_dir}/events.jsonl` +- `SORTER2_BASE_URL` — public origin (also drives Secure cookies when `https://`) +- `GITHUB_CLIENT_ID` / `GITHUB_CLIENT_SECRET` — GitHub OAuth (optional; login disabled if unset) +- `SORTER2_ALLOW_MOCK_OAUTH=1` — allow `mock_user` on `/auth/github` (tests only) Health check: `GET /healthz` → `ok`. -Core UI flow: `POST /ui` with form field `__rpc__` (JSON). Example vote: +Core UI flow: `POST /ui` with form field `__rpc__` (JSON). Votes require a session cookie (sign in via `/login`). Example vote: ```bash curl -sf -X POST http://127.0.0.1:8080/ui \ + --cookie "sorter2_session=..." \ --data-urlencode '__rpc__={"action":"record_vote","a":"alpha","b":"beta","ratio_left":2,"ratio_right":1}' ``` diff --git a/Cargo.lock b/Cargo.lock index aa02997ad85777195f135bfd9456bcee0fc9a590..1f8690f3e486d099577a32c2ece48caf57ea7160 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -414,7 +414,7 @@ dependencies = [ [[package]] name = "durable" version = "0.2.0" -source = "git+https://github.com/tommy-mor/durable.git?branch=main#a6c14eaa809693140eea0c22b07ef24d8e74adaf" +source = "git+https://github.com/tommy-mor/durable.git?rev=a6c14eaa809693140eea0c22b07ef24d8e74adaf#a6c14eaa809693140eea0c22b07ef24d8e74adaf" dependencies = [ "ciborium", "durable-derive", @@ -426,7 +426,7 @@ dependencies = [ [[package]] name = "durable-derive" version = "0.2.0" -source = "git+https://github.com/tommy-mor/durable.git?branch=main#a6c14eaa809693140eea0c22b07ef24d8e74adaf" +source = "git+https://github.com/tommy-mor/durable.git?rev=a6c14eaa809693140eea0c22b07ef24d8e74adaf#a6c14eaa809693140eea0c22b07ef24d8e74adaf" dependencies = [ "proc-macro2", "quote", diff --git a/server/Cargo.toml b/server/Cargo.toml index dfa39beddecfa37dcdeaa602cb30f4b547528fbb..bd88687fb0ba47d68f2c08eb5e11d0e08b7c4398 100644 --- a/server/Cargo.toml +++ b/server/Cargo.toml @@ -25,7 +25,7 @@ futures-util = { version = "0.3", default-features = false, features = ["std"] } rand = "0.8" urlencoding = "2" url = "2" -durable = { git = "https://github.com/tommy-mor/durable.git", branch = "main" } +durable = { git = "https://github.com/tommy-mor/durable.git", rev = "a6c14eaa809693140eea0c22b07ef24d8e74adaf" } [dev-dependencies] reqwest = { version = "0.12", features = ["json"] } diff --git a/server/src/api/ui_html.rs b/server/src/api/ui_html.rs index b86581b1f337650564274254d840e8a75b49524d..9da62ffbed07eb28729aa3160bf33b07ce0d7945 100644 --- a/server/src/api/ui_html.rs +++ b/server/src/api/ui_html.rs @@ -71,10 +71,16 @@ pub async fn post_ui_html( return resp; } let parent = parent_from_scope(&scope); - let actor = resolve_vote_actor( + let actor = match resolve_vote_actor( state.projection_store.db(), session_id_from_jar(&jar).as_deref(), - ); + ) { + Ok(actor) => actor, + Err(_) => { + return vote_auth_redirect(&state, &jar) + .unwrap_or_else(|| login_redirect_js().into_response()); + } + }; if let Err(e) = state .record_vote(&parent, &a, &b, ratio_left, ratio_right, &actor) .await diff --git a/server/src/auth/config.rs b/server/src/auth/config.rs index a1f042c655bf3e5234eeb87a7d889f64592807fb..a5976af9a52ea207b35ae87bd1fe927c47a477ca 100644 --- a/server/src/auth/config.rs +++ b/server/src/auth/config.rs @@ -1,9 +1,42 @@ pub const AUTH_RETURN_COOKIE: &str = "sorter2_auth_return"; +/// Allow `mock_user` on `/auth/github` (test harness only). +pub fn mock_oauth_allowed() -> bool { + matches!( + std::env::var("SORTER2_ALLOW_MOCK_OAUTH").as_deref(), + Ok("1") | Ok("true") | Ok("TRUE") + ) +} + +/// Set the Secure flag on auth cookies when serving over HTTPS. +pub fn cookies_secure() -> bool { + std::env::var("SORTER2_BASE_URL") + .map(|u| u.starts_with("https://")) + .unwrap_or(false) +} + pub fn sanitize_return_to(raw: &str) -> String { let s = raw.trim(); - if s.is_empty() || !s.starts_with('/') || s.starts_with("//") { + if s.is_empty() || !s.starts_with('/') || s.starts_with("//") || s.starts_with("/\\") { + return "/".to_string(); + } + // Reject scheme-relative and protocol-smuggling forms. + if s.contains("://") || s.contains('\\') { return "/".to_string(); } s.to_string() } + +#[cfg(test)] +mod tests { + use super::*; + + #[test] + fn sanitize_return_to_blocks_open_redirects() { + assert_eq!(sanitize_return_to(""), "/"); + assert_eq!(sanitize_return_to("//evil.com"), "/"); + assert_eq!(sanitize_return_to("/\\evil.com"), "/"); + assert_eq!(sanitize_return_to("https://evil.com"), "/"); + assert_eq!(sanitize_return_to("/vote?parent=x"), "/vote?parent=x"); + } +} diff --git a/server/src/auth/mod.rs b/server/src/auth/mod.rs index 5ed535ba199fa736f0048c32623b14c3b1e5de2d..d4a85ef52c15dc35148e4c743f0d646cbbdb056d 100644 --- a/server/src/auth/mod.rs +++ b/server/src/auth/mod.rs @@ -26,7 +26,7 @@ use crate::{ ui_action::UI_RPC_FIELD, }; -pub use session::{resolve_vote_actor, session_id_from_jar, VoteActor}; +pub use session::{nav_pseudonym, resolve_vote_actor, session_id_from_jar, VoteActor}; pub fn base_url_from_env(port: u16) -> String { std::env::var("SORTER2_BASE_URL") @@ -168,6 +168,10 @@ pub async fn login_page( "login · sorter2", login_body(session.as_ref(), &aliases, &providers), state.views.get_views("/login"), + session + .as_ref() + .filter(|s| !s.pseudonym.trim().is_empty()) + .map(|s| s.pseudonym.as_str()), ); (jar, Html(markup.into_string())).into_response() } @@ -222,6 +226,7 @@ pub async fn alias_page( "choose alias · sorter2", body, state.views.get_views("/login/alias"), + None, ) .into_string(), ) @@ -237,7 +242,12 @@ pub async fn github_start( .ok_or(StatusCode::SERVICE_UNAVAILABLE)?; let return_to = return_from_query_or_jar(&jar, query.return_to.as_deref()); let state_token = session::new_oauth_state(); - let url = oauth::authorize_url(&cfg, &state_token, query.mock_user.as_deref()); + let mock_user = if config::mock_oauth_allowed() { + query.mock_user.as_deref() + } else { + None + }; + let url = oauth::authorize_url(&cfg, &state_token, mock_user); let jar = jar .add(session::oauth_state_cookie_value(&state_token)) .add(session::auth_return_cookie_value(&return_to)); diff --git a/server/src/auth/session.rs b/server/src/auth/session.rs index 09659240b9455c6fca12db5652e1d31cf8c2acfc..41df030ded3abcafc0ab3887ab769adf103f9aa0 100644 --- a/server/src/auth/session.rs +++ b/server/src/auth/session.rs @@ -5,7 +5,7 @@ use durable::{Db, Durability}; use rand::Rng; use crate::{ - auth::config::AUTH_RETURN_COOKIE, + auth::config::{self, AUTH_RETURN_COOKIE}, fetch::now_ms, identity::{DEFAULT_ACTOR_UUID, DEFAULT_PSEUDONYM}, storage_dto::{SessionDataV1, SESSION_DATA_VERSION}, @@ -37,6 +37,7 @@ pub struct VoteActor { } impl VoteActor { + /// Test / bench helper: seed votes as the default pseudonym without a session. pub fn anon() -> Self { Self { pseudonym: DEFAULT_PSEUDONYM.to_string(), @@ -70,20 +71,51 @@ fn hex_encode(bytes: &[u8]) -> String { bytes.iter().map(|b| format!("{b:02x}")).collect() } -pub fn resolve_vote_actor(db: &Db, session_id: Option<&str>) -> VoteActor { - let Some(session_id) = session_id else { - return VoteActor::anon(); - }; - let Ok(Some(session)) = load_session(db, session_id) else { - return VoteActor::anon(); - }; - if session.expires_at <= now_ms() { - return VoteActor::anon(); +fn build_cookie(name: &'static str, value: String) -> Cookie<'static> { + let mut builder = Cookie::build((name, value)) + .http_only(true) + .same_site(SameSite::Lax) + .path("/"); + if config::cookies_secure() { + builder = builder.secure(true); + } + builder.build() +} + +fn clear_cookie(name: &'static str) -> Cookie<'static> { + let mut builder = Cookie::build((name, "")) + .http_only(true) + .same_site(SameSite::Lax) + .path("/") + .removal(); + if config::cookies_secure() { + builder = builder.secure(true); + } + builder.build() +} + +/// Resolve the vote actor from a live session. Fail-closed: never falls back to anon. +pub fn resolve_vote_actor(db: &Db, session_id: Option<&str>) -> Result { + let session_id = session_id.ok_or("sign in to vote")?; + let session = load_valid_session(db, session_id).ok_or("session expired")?; + if !session_has_pseudonym(&session) { + return Err("choose an alias first"); } let trust_weight = user_trust_weight(db, &session.uuid).unwrap_or(1.0); - VoteActor { + Ok(VoteActor { pseudonym: session.current_pseudonym, trust_weight, + }) +} + +/// Display name for the top nav, if any session is active. +pub fn nav_pseudonym(db: &Db, jar: &CookieJar) -> Option { + let session_id = session_id_from_jar(jar)?; + let session = load_valid_session(db, &session_id)?; + if session_has_pseudonym(&session) { + Some(session.current_pseudonym) + } else { + None } } @@ -151,54 +183,27 @@ pub fn destroy_session(db: &Db, session_id: &str) -> Result<(), String> { } pub fn session_cookie_value(session_id: &str) -> Cookie<'static> { - Cookie::build((SESSION_COOKIE, session_id.to_string())) - .http_only(true) - .same_site(SameSite::Lax) - .path("/") - .build() + build_cookie(SESSION_COOKIE, session_id.to_string()) } pub fn clear_session_cookie() -> Cookie<'static> { - Cookie::build((SESSION_COOKIE, "")) - .http_only(true) - .same_site(SameSite::Lax) - .path("/") - .removal() - .build() + clear_cookie(SESSION_COOKIE) } pub fn oauth_state_cookie_value(state: &str) -> Cookie<'static> { - Cookie::build((OAUTH_STATE_COOKIE, state.to_string())) - .http_only(true) - .same_site(SameSite::Lax) - .path("/") - .build() + build_cookie(OAUTH_STATE_COOKIE, state.to_string()) } pub fn clear_oauth_state_cookie() -> Cookie<'static> { - Cookie::build((OAUTH_STATE_COOKIE, "")) - .http_only(true) - .same_site(SameSite::Lax) - .path("/") - .removal() - .build() + clear_cookie(OAUTH_STATE_COOKIE) } pub fn auth_return_cookie_value(return_to: &str) -> Cookie<'static> { - Cookie::build((AUTH_RETURN_COOKIE, return_to.to_string())) - .http_only(true) - .same_site(SameSite::Lax) - .path("/") - .build() + build_cookie(AUTH_RETURN_COOKIE, return_to.to_string()) } pub fn clear_auth_return_cookie() -> Cookie<'static> { - Cookie::build((AUTH_RETURN_COOKIE, "")) - .http_only(true) - .same_site(SameSite::Lax) - .path("/") - .removal() - .build() + clear_cookie(AUTH_RETURN_COOKIE) } pub fn auth_return_from_jar(jar: &CookieJar) -> Option { @@ -213,28 +218,35 @@ pub fn oauth_state_from_jar(jar: &CookieJar) -> Option { jar.get(OAUTH_STATE_COOKIE).map(|c| c.value().to_string()) } -pub fn actor_uuid_for_vote(db: &Db, session_id: Option<&str>) -> String { - let Some(session_id) = session_id else { - return DEFAULT_ACTOR_UUID.to_string(); - }; - load_session(db, session_id) - .ok() - .flatten() - .filter(|s| s.expires_at > now_ms()) - .map(|s| s.uuid) - .unwrap_or_else(|| DEFAULT_ACTOR_UUID.to_string()) -} - #[cfg(test)] mod tests { use super::*; #[test] - fn missing_session_falls_back_to_anon() { + fn missing_session_is_error() { + let dir = tempfile::tempdir().unwrap(); + let db = Db::open(dir.path()).unwrap(); + assert_eq!(resolve_vote_actor(&db, None).unwrap_err(), "sign in to vote"); + } + + #[test] + fn session_without_pseudonym_is_error() { + let dir = tempfile::tempdir().unwrap(); + let db = Db::open(dir.path()).unwrap(); + let (id, _) = create_session(&db, DEFAULT_ACTOR_UUID, "").unwrap(); + assert_eq!( + resolve_vote_actor(&db, Some(&id)).unwrap_err(), + "choose an alias first" + ); + } + + #[test] + fn session_with_pseudonym_resolves() { let dir = tempfile::tempdir().unwrap(); let db = Db::open(dir.path()).unwrap(); - let actor = resolve_vote_actor(&db, None); - assert_eq!(actor.pseudonym, DEFAULT_PSEUDONYM); + let (id, _) = create_session(&db, DEFAULT_ACTOR_UUID, "alice").unwrap(); + let actor = resolve_vote_actor(&db, Some(&id)).unwrap(); + assert_eq!(actor.pseudonym, "alice"); assert_eq!(actor.trust_weight, 1.0); } } diff --git a/server/src/html/mod.rs b/server/src/html/mod.rs index 46d18b87f1313bf0aeb29955d18f291961057509..3cc3d7bdf55b5cb5d009600f4ade1fcd201a410b 100644 --- a/server/src/html/mod.rs +++ b/server/src/html/mod.rs @@ -4,11 +4,13 @@ use axum::{ http::{header, StatusCode, Uri}, response::{IntoResponse, Response}, }; +use axum_extra::extract::cookie::CookieJar; use maud::{html, Markup, DOCTYPE}; use std::collections::HashSet; use crate::{ + auth::nav_pseudonym, fetch::html::entity_section, form_template::template_json_compact, path_types::ItemId, @@ -126,7 +128,7 @@ pub fn now_ms() -> i64 { t.as_millis() as i64 } -pub(crate) fn layout(title: &str, body: Markup, views: u64) -> Markup { +pub(crate) fn layout(title: &str, body: Markup, views: u64, nav_user: Option<&str>) -> Markup { let ver = asset_version(); let css_href = format!("/static/sorter.css?v={ver}"); let js_src = format!("/static/sorter_ui.js?v={ver}"); @@ -145,7 +147,15 @@ pub(crate) fn layout(title: &str, body: Markup, views: u64) -> Markup { span class="view-meta muted" { (views) " views" } } nav class="top-nav" { - a href="/login" { "login" } + @if let Some(name) = nav_user { + span class="top-nav-user" data-testid="nav-user" { (name) } + a href="/login" { "account" } + form class="top-nav-logout" method="post" action="/auth/logout" data-navigate="full" { + button type="submit" data-testid="nav-logout" { "log out" } + } + } @else { + a href="/login" data-testid="nav-login" { "login" } + } } div id="errors" {} (body) @@ -481,10 +491,11 @@ pub fn input_panel(query: &str, error: Option<&str>) -> Markup { } } -async fn item_page(state: AppState, uri: Uri, item: ItemId) -> Markup { +async fn item_page(state: AppState, uri: Uri, item: ItemId, jar: CookieJar) -> Markup { let path = uri.path().to_string(); state.views.increment(path.clone()); let views = state.views.get_views(&path); + let nav_user = nav_pseudonym(state.projection_store.db(), &jar); let tree = state .scope_tree(&item) @@ -513,16 +524,24 @@ async fn item_page(state: AppState, uri: Uri, item: ItemId) -> Markup { (ranking_panel(&item, node, &tree)) } }; - layout("sorter2", body, views) + layout("sorter2", body, views, nav_user.as_deref()) } -pub async fn home(State(state): State, uri: Uri) -> impl IntoResponse { - item_page(state, uri, ItemId::root()).await +pub async fn home( + State(state): State, + jar: CookieJar, + uri: Uri, +) -> impl IntoResponse { + item_page(state, uri, ItemId::root(), jar).await } -pub async fn browse(State(state): State, uri: Uri) -> impl IntoResponse { +pub async fn browse( + State(state): State, + jar: CookieJar, + uri: Uri, +) -> impl IntoResponse { let item = ItemId::from_browse_uri(uri.path()).unwrap_or(ItemId::root()); - item_page(state, uri, item).await + item_page(state, uri, item, jar).await } #[cfg(test)] diff --git a/server/src/html/vote.rs b/server/src/html/vote.rs index 3aa00c417c89a9cab3417c650b50ed7c73f08e20..cadbec188b17a48a63b269c0e2fa2ea8ffedd7ed 100644 --- a/server/src/html/vote.rs +++ b/server/src/html/vote.rs @@ -4,11 +4,13 @@ use axum::{ extract::{Query, State}, response::{Html, IntoResponse}, }; +use axum_extra::extract::cookie::CookieJar; use maud::{html, Markup}; use serde::Deserialize; use std::collections::HashSet; use crate::{ + auth::nav_pseudonym, fetch::html::entity_section, form_template::template_json_compact, html::{ranking_panel_with_highlights, scope_theme_style, JsBuilder}, @@ -262,6 +264,7 @@ fn suggest_next( pub async fn vote_page( State(state): State, + jar: CookieJar, Query(q): Query, ) -> impl IntoResponse { let parent = parse_item_param(&q.parent); @@ -329,8 +332,9 @@ pub async fn vote_page( let path = format!("/vote?parent={}", urlencoding::encode(parent.as_str())); state.views.increment(path.clone()); let views = state.views.get_views(&path); + let nav_user = nav_pseudonym(state.projection_store.db(), &jar); - Html(layout(&title, body, views).into_string()).into_response() + Html(layout(&title, body, views, nav_user.as_deref()).into_string()).into_response() } #[cfg(test)] diff --git a/server/static/sorter.css b/server/static/sorter.css index e66a1e6c1acc473c8ff1ddb1e16e75a82d33741c..257280b6b490c65222e580a325b77351cac6cc6b 100644 --- a/server/static/sorter.css +++ b/server/static/sorter.css @@ -34,6 +34,47 @@ body { font-size: 0.75rem; } +.top-nav { + display: flex; + align-items: center; + justify-content: flex-end; + gap: 0.75rem; + padding: 0.5rem 1rem; + font-size: 0.875rem; +} + +.top-nav a { + color: var(--muted); + text-decoration: none; +} + +.top-nav a:hover { + color: var(--fg); +} + +.top-nav-user { + color: var(--fg); + font-weight: 600; +} + +.top-nav-logout { + display: inline; + margin: 0; +} + +.top-nav-logout button { + background: none; + border: none; + padding: 0; + color: var(--muted); + font: inherit; + cursor: pointer; +} + +.top-nav-logout button:hover { + color: var(--fg); +} + .btn-primary { background: var(--accent); color: var(--accent-fg, #0f1115); diff --git a/test/support/harness.clj b/test/support/harness.clj index 3f05951f418258642dcacb4a10ccccc8bfbe8748..4505ece5aa193e826ca61c52f1467d252080d66b 100644 --- a/test/support/harness.clj +++ b/test/support/harness.clj @@ -43,6 +43,7 @@ "SORTER2_VIEWS_LOG" (str data-dir "/views.jsonl") "PORT" (str app-port) "SORTER2_BASE_URL" (str "http://127.0.0.1:" app-port) + "SORTER2_ALLOW_MOCK_OAUTH" "1" "GITHUB_CLIENT_ID" "test-client" "GITHUB_CLIENT_SECRET" "test-secret" "GITHUB_OAUTH_BASE" (str "http://127.0.0.1:" oauth-port) Side B — contributor: tommy-mor Side B — commit message: [2bc302c3] refactor Side B — unified diff (full patch): diff --git a/server/src/api/ui_html.rs b/server/src/api/ui_html.rs index 06001212820101e0cc953d3687dea64f85e60787..d2f9769108def7ca2c5857aec8b4319426188a66 100644 --- a/server/src/api/ui_html.rs +++ b/server/src/api/ui_html.rs @@ -47,7 +47,7 @@ pub async fn post_ui_html( ratio_left, ratio_right, scope, - next, + vote_compare, } => { let parent = parent_from_scope(&scope); if let Err(e) = state @@ -57,14 +57,12 @@ pub async fn post_ui_html( return ui_js_warn(&e).into_response(); } let tree = state.tree.read().await; - if !next.trim().is_empty() { + if vote_compare { + let left = parse_item_param(&a); + let right = parse_item_param(&b); + let morph = crate::html::vote::vote_recorded_morph(&tree, &parent, &left, &right); drop(tree); - return JsBuilder::new() - .raw(&format!( - "window.location.href={};", - js_string_literal(next.trim()) - )) - .into_response(); + return morph.into_response(); } let empty = crate::reducer::NodeState::default(); let node = tree.get(&parent).unwrap_or(&empty); @@ -137,7 +135,7 @@ mod tests { ratio_left: 3, ratio_right: 1, scope: String::new(), - next: String::new(), + vote_compare: false, } ); } diff --git a/server/src/html/mod.rs b/server/src/html/mod.rs index 61cdbc094819ddedb755572c59456ec0d6617619..cd578a5fea46a9a1d49e238d08a80c2caf18708d 100644 --- a/server/src/html/mod.rs +++ b/server/src/html/mod.rs @@ -65,6 +65,15 @@ impl JsBuilder { self } + pub(crate) fn morph_inner_selector(mut self, selector: &str, markup: Markup) -> Self { + let html = js_string_literal(&markup.into_string()); + self.snippets.push(format!( + "var __el = document.querySelector({sel}); if (__el) {{ Idiomorph.morph(__el, {html}, {{ morphStyle: 'innerHTML' }}); }}", + sel = js_string_literal(selector), + )); + self + } + pub(crate) fn raw(mut self, js: &str) -> Self { if !js.is_empty() { self.snippets.push(js.to_string()); diff --git a/server/src/html/vote.rs b/server/src/html/vote.rs new file mode 100644 index 0000000000000000000000000000000000000000..89ed621ad861214e147add2062224fc4137ff8ad --- /dev/null +++ b/server/src/html/vote.rs @@ -0,0 +1,306 @@ +//! Pairwise vote UI — `/vote?parent=` with optional `left` / `right`. + +use axum::{ + extract::{Query, State}, + response::{Html, IntoResponse}, +}; +use maud::{html, Markup}; +use serde::Deserialize; + +use crate::{ + form_template::template_json_compact, + html::JsBuilder, + pair::{children_of, resolve_pair, suggest_next_pair_in_pool}, + path_types::ItemId, + reducer::{GlobalTree, GroupState, NodeState, VoteData}, + state::{parse_item_param, AppState}, + ui_action::UI_RPC_FIELD, +}; + +use super::{breadcrumb_path, item_href, layout}; + +#[derive(Debug, Deserialize)] +pub struct VoteQuery { + pub parent: String, + #[serde(default)] + pub left: Option, + #[serde(default)] + pub right: Option, +} + +pub fn vote_href(parent: &ItemId) -> String { + format!( + "/vote?parent={}", + urlencoding::encode(parent.as_str()) + ) +} + +fn vote_compare_href(parent: &ItemId, left: &ItemId, right: &ItemId) -> String { + format!( + "/vote?parent={}&left={}&right={}", + urlencoding::encode(parent.as_str()), + urlencoding::encode(left.as_str()), + urlencoding::encode(right.as_str()), + ) +} + +fn display_label(id: &ItemId) -> String { + id.segments() + .last() + .map_or("item".into(), |v| v.to_string()) +} + +fn child_title(tree: &GlobalTree, id: &ItemId) -> String { + tree.get(id) + .and_then(|n| n.data.as_ref()) + .map(|d| d.title.clone()) + .unwrap_or_else(|| display_label(id)) +} + +fn ratio_pct(ratio_left: i32, ratio_right: i32) -> f64 { + let l = ratio_left.max(0) as f64; + let r = ratio_right.max(0) as f64; + let sum = l + r; + if sum <= 0.0 { + 50.0 + } else { + (l / sum) * 100.0 + } +} + +fn ratios_for_page(v: &VoteData, page_left: &ItemId, page_right: &ItemId) -> (i32, i32) { + match (v.a.as_str(), v.b.as_str()) { + (a, b) if a == page_left.as_str() && b == page_right.as_str() => { + (v.ratio_left, v.ratio_right) + } + (a, b) if a == page_right.as_str() && b == page_left.as_str() => { + (v.ratio_right, v.ratio_left) + } + _ => (v.ratio_left, v.ratio_right), + } +} + +fn edge_votes(group: &GroupState, left: &ItemId, right: &ItemId) -> Vec { + group + .recent_votes + .iter() + .filter(|v| { + (v.a.as_str() == left.as_str() && v.b.as_str() == right.as_str()) + || (v.a.as_str() == right.as_str() && v.b.as_str() == left.as_str()) + }) + .cloned() + .collect() +} + +fn vote_edge_history(tree: &GlobalTree, group: &GroupState, left: &ItemId, right: &ItemId) -> Markup { + let mut votes = edge_votes(group, left, right); + votes.sort_by(|a, b| b.ts.cmp(&a.ts)); + let legend_left = child_title(tree, left); + let legend_right = child_title(tree, right); + html! { + @if votes.is_empty() { + p class="muted vote-edge-empty" { "no votes on this pair yet" } + } @else { + h3 class="vote-edge-history-title" { + "votes on this pair" + span class="vote-edge-history-axis muted" { " · " (legend_left) " : " (legend_right) } + } + ul class="vote-edge-history" { + @for v in &votes { + @let (r_left, r_right) = ratios_for_page(v, left, right); + @let pct = ratio_pct(r_left, r_right); + li class="vote-edge-history-row" { + div class="vote-edge-meta" { + span class="vote-edge-ratio" { (format!("{}:{}", r_left, r_right)) } + } + div class="ratio-bar vote-edge-bar" aria-hidden="true" { + div class="ratio-left" style={(format!("width: {:.3}%;", pct))} {} + div class="ratio-right" style={(format!("width: {:.3}%;", 100.0 - pct))} {} + } + } + } + } + } + } +} + +fn vote_back_nav(parent: &ItemId) -> Markup { + html! { + div class="vote-compare-nav" { + a class="vote-compare-back muted" href=(item_href(parent)) { "← back to " (display_label(parent)) } + } + } +} + +fn vote_compare_actions(parent: &ItemId, next: Option<&(ItemId, ItemId)>) -> Markup { + let next_href = next.map(|(l, r)| vote_compare_href(parent, l, r)); + html! { + div id="vote-compare-actions" class="vote-compare-actions" { + button type="submit" class="btn-primary" data-testid="vote-post" { "post vote" } + @if let Some(href) = &next_href { + a class="btn-secondary vote-compare-next" data-testid="vote-next-pair" href=(href) { "next pair" } + } @else { + span class="btn-secondary vote-compare-next is-disabled" { "no next pair" } + } + } + } +} + +/// After recording a vote on the compare page: refresh edge history and next-pair link. +pub(crate) fn vote_recorded_morph( + tree: &GlobalTree, + parent: &ItemId, + left: &ItemId, + right: &ItemId, +) -> JsBuilder { + let pool = children_of(tree, parent); + let empty = NodeState::default(); + let group = tree + .get(parent) + .unwrap_or(&empty) + .local_ranking + .clone(); + let edge_history = vote_edge_history(tree, &group, left, right); + let next_pair = suggest_next(&group, left, right, &pool); + let actions = vote_compare_actions(parent, next_pair.as_ref()); + JsBuilder::new() + .morph_inner_selector("#vote-edge-history-region", edge_history) + .morph_selector("#vote-compare-actions", actions) +} + +fn vote_compare_item_card(tree: &GlobalTree, item: &ItemId, side_class: &str) -> Markup { + let href = item_href(item); + let title = child_title(tree, item); + html! { + div class=(format!("vote-compare-side {side_class}")) { + a class=(format!("vote-compare-item {side_class}")) href=(href) { + @if let Some(row) = crate::render::reddit::child_row_markup(tree, item, &href) { + (row) + } @else { + strong { (title) } + } + } + @if let Some(node) = tree.get(item) { + @if crate::render::reddit::is_reddit_post(item) { + @if let Some(data) = &node.data { + @if let Some(src) = data.image_url.as_ref().or(data.thumb_url.as_ref()) { + figure class="vote-compare-figure" { + img class="vote-compare-image" src=(src) alt="" loading="lazy"; + } + } + @if let Some(author) = &data.author { + p class="muted small" { "by " (author) } + } + } + } @else if let Some(data) = &node.data { + @if let Some(body) = &data.body_html { + div class="vote-compare-item-body" { + (maud::PreEscaped(body)) + } + } + } + } + } + } +} + + +fn suggest_next(group: &GroupState, left: &ItemId, right: &ItemId, pool: &[ItemId]) -> Option<(ItemId, ItemId)> { + suggest_next_pair_in_pool(group, pool, Some((left, right))) +} + +pub async fn vote_page( + State(state): State, + Query(q): Query, +) -> impl IntoResponse { + let parent = parse_item_param(&q.parent); + let left_param = q.left.as_deref().map(parse_item_param); + let right_param = q.right.as_deref().map(parse_item_param); + + let tree = state.tree.read().await; + let empty = NodeState::default(); + let parent_node = tree.get(&parent).unwrap_or(&empty); + + let (left, right) = match resolve_pair( + &tree, + &parent, + left_param.as_ref(), + right_param.as_ref(), + ) { + Ok(p) => p, + Err(e) => { + let (msg, status) = e.status_message(); + return (status, msg).into_response(); + } + }; + + let pool = children_of(&tree, &parent); + let group = &parent_node.local_ranking; + let next_pair = suggest_next(group, &left, &right, &pool); + let edge_history = vote_edge_history(&tree, group, &left, &right); + + let rpc_json = template_json_compact(&serde_json::json!({ + "action": "record_vote", + "a": left.as_str(), + "b": right.as_str(), + "ratio_left": {"$form:i32": "ratio_left"}, + "ratio_right": {"$form:i32": "ratio_right"}, + "scope": parent.as_str(), + "vote_compare": true, + })) + .expect("vote rpc json"); + + let title = format!( + "vote — {} vs {}", + child_title(&tree, &left), + child_title(&tree, &right) + ); + + let body = html! { + section class="vote-compare-shell" { + h1 { "compare" } + (breadcrumb_path(&parent)) + p class="muted vote-compare-scope" { + "ranking children of " + a href=(item_href(&parent)) { (child_title(&tree, &parent)) } + } + div class="vote-compare-pair" { + (vote_compare_item_card(&tree, &left, "vote-compare-left")) + span class="vote-compare-vs" { "vs" } + (vote_compare_item_card(&tree, &right, "vote-compare-right")) + } + (vote_back_nav(&parent)) + div id="vote-edge-history-region" { + (edge_history) + } + form id="vote-compare-form" method="POST" action="/ui" { + input type="hidden" name=(UI_RPC_FIELD) value=(rpc_json); + input type="hidden" name="ratio_left" id="vote-ratio-left" value="50"; + input type="hidden" name="ratio_right" id="vote-ratio-right" value="50"; + label class="vote-compare-slider-label" { + span id="vote-slider-left-label" { (child_title(&tree, &left)) } + input type="range" id="vote-preference-slider" min="0" max="100" value="50" + aria-valuemin="0" aria-valuemax="100"; + span id="vote-slider-right-label" { (child_title(&tree, &right)) } + } + (vote_compare_actions(&parent, next_pair.as_ref())) + } + } + }; + + drop(tree); + + let path = format!("/vote?parent={}", urlencoding::encode(parent.as_str())); + state.views.increment(path.clone()); + let views = state.views.get_views(&path); + + Html( + layout( + &title, + body, + views, + ) + .into_string(), + ) + .into_response() +} diff --git a/server/src/pair.rs b/server/src/pair.rs new file mode 100644 index 0000000000000000000000000000000000000000..606ffa51038a57ffacf335aa48bdb1185f8483fb --- /dev/null +++ b/server/src/pair.rs @@ -0,0 +1,340 @@ +//! Pick two children of a parent scope for pairwise voting. +//! +//! Pair selection prefers **bridge** votes — comparisons between items in +//! different connected components of the voted-pairs graph — so the pool +//! merges into one ranking group before refining within it. + +use rand::seq::SliceRandom; +use std::collections::{HashMap, HashSet}; + +use crate::{ + path_types::ItemId, + ranking::connected_components_from_voted_pairs, + reducer::{GlobalTree, GroupState}, +}; + +fn pairs_match(a: &ItemId, b: &ItemId, x: &ItemId, y: &ItemId) -> bool { + (a == x && b == y) || (a == y && b == x) +} + +fn pair_is_voted(group: &GroupState, a: &ItemId, b: &ItemId) -> bool { + let Some(&ai) = group.item_to_idx.get(a) else { + return false; + }; + let Some(&bi) = group.item_to_idx.get(b) else { + return false; + }; + let (i, j) = if ai < bi { (ai, bi) } else { (bi, ai) }; + group.voted_pairs.contains(&(i, j)) +} + +/// Component id per pool item: voted-pairs graph components plus one id per +/// never-voted child. +fn component_ids(group: &GroupState, pool: &[ItemId]) -> HashMap { + let n = group.idx_to_item.len(); + let (comps, isolates) = + connected_components_from_voted_pairs(n, group.voted_pairs.iter().copied()); + + let mut out: HashMap = HashMap::new(); + for (comp_idx, comp) in comps.iter().enumerate() { + for &idx in comp { + if idx < n { + out.insert(group.idx_to_item[idx].clone(), comp_idx); + } + } + } + let mut next = comps.len(); + for &idx in &isolates { + if idx < n { + out.insert(group.idx_to_item[idx].clone(), next); + next += 1; + } + } + for item in pool { + out.entry(item.clone()).or_insert_with(|| { + let id = next; + next += 1; + id + }); + } + out +} + +#[derive(Debug, Clone, Copy, PartialEq, Eq, PartialOrd, Ord)] +enum PairPriority { + /// Unvoted edge between two components — grows the ranking group. + BridgeUnvoted = 0, + /// Unvoted edge inside one component — refines order. + WithinUnvoted = 1, + /// Re-vote across components (rare once merged). + BridgeVoted = 2, + /// Re-vote within a component. + WithinVoted = 3, +} + +fn pair_priority( + group: &GroupState, + components: &HashMap, + a: &ItemId, + b: &ItemId, +) -> PairPriority { + let voted = pair_is_voted(group, a, b); + let bridge = components.get(a) != components.get(b); + match (bridge, voted) { + (true, false) => PairPriority::BridgeUnvoted, + (false, false) => PairPriority::WithinUnvoted, + (true, true) => PairPriority::BridgeVoted, + (false, true) => PairPriority::WithinVoted, + } +} + +/// All unordered pairs from `pool`, optionally skipping `exclude`. +fn candidate_pairs( + pool: &[ItemId], + exclude: Option<(&ItemId, &ItemId)>, +) -> Vec<(ItemId, ItemId)> { + let mut out = Vec::new(); + for i in 0..pool.len() { + for j in (i + 1)..pool.len() { + let a = &pool[i]; + let b = &pool[j]; + if a == b { + continue; + } + if exclude.is_some_and(|(x, y)| pairs_match(a, b, x, y)) { + continue; + } + out.push((a.clone(), b.clone())); + } + } + out +} + +/// Pick the next pair to vote on within `pool`. +/// +/// 1. Prefer unvoted **bridge** pairs (connect separate ranking components). +/// 2. Then unvoted within-component pairs (refinement). +/// 3. Then already-voted pairs (re-compare). +pub fn suggest_next_pair_in_pool( + group: &GroupState, + pool: &[ItemId], + exclude: Option<(&ItemId, &ItemId)>, +) -> Option<(ItemId, ItemId)> { + let candidates = candidate_pairs(pool, exclude); + if candidates.is_empty() { + return None; + } + let components = component_ids(group, pool); + let best = candidates + .iter() + .map(|(a, b)| (pair_priority(group, &components, a, b), (a, b))) + .min_by_key(|(p, _)| *p)? + .0; + let best_pairs: Vec<(ItemId, ItemId)> = candidates + .into_iter() + .filter(|(a, b)| pair_priority(group, &components, a, b) == best) + .collect(); + best_pairs.choose(&mut rand::thread_rng()).cloned() +} + +/// Random distinct pair from `children` (legacy pair.rs behavior). +pub fn random_pair(children: &[ItemId]) -> Option<(ItemId, ItemId)> { + if children.len() < 2 { + return None; + } + let left = children.choose(&mut rand::thread_rng())?; + let mut right = children.choose(&mut rand::thread_rng())?; + let mut guard = 0; + while left == right && guard < 32 { + right = children.choose(&mut rand::thread_rng())?; + guard += 1; + } + if left == right { + return None; + } + Some((left.clone(), right.clone())) +} + +/// Sorted children of `parent` from the global tree. +pub fn children_of(tree: &GlobalTree, parent: &ItemId) -> Vec { + let Some(node) = tree.get(parent) else { + return Vec::new(); + }; + let mut children: Vec = node.children.iter().cloned().collect(); + children.sort_by(|a, b| a.as_str().cmp(b.as_str())); + children +} + +/// Resolve a pair to compare under `parent`. +pub fn resolve_pair( + tree: &GlobalTree, + parent: &ItemId, + left: Option<&ItemId>, + right: Option<&ItemId>, +) -> Result<(ItemId, ItemId), PairError> { + let children = children_of(tree, parent); + if children.len() < 2 { + return Err(PairError::TooFewChildren); + } + let child_set: HashSet<_> = children.iter().collect(); + + match (left, right) { + (Some(l), Some(r)) => { + if l == r { + return Err(PairError::SameItem); + } + if !child_set.contains(l) || !child_set.contains(r) { + return Err(PairError::NotChild); + } + Ok((l.clone(), r.clone())) + } + (None, None) => { + let group = tree + .get(parent) + .map(|n| &n.local_ranking) + .cloned() + .unwrap_or_default(); + suggest_next_pair_in_pool(&group, &children, None).ok_or(PairError::NoPair) + } + _ => Err(PairError::IncompletePair), + } +} + +#[derive(Debug, Clone, PartialEq, Eq)] +pub enum PairError { + TooFewChildren, + SameItem, + NotChild, + IncompletePair, + NoPair, +} + +impl PairError { + pub fn status_message(&self) -> (&'static str, axum::http::StatusCode) { + match self { + Self::TooFewChildren => ( + "parent needs at least 2 children to vote", + axum::http::StatusCode::BAD_REQUEST, + ), + Self::SameItem => ( + "left and right must differ", + axum::http::StatusCode::BAD_REQUEST, + ), + Self::NotChild => ( + "left and right must be children of parent", + axum::http::StatusCode::BAD_REQUEST, + ), + Self::IncompletePair => ( + "provide both left and right, or neither", + axum::http::StatusCode::BAD_REQUEST, + ), + Self::NoPair => ( + "no pair available", + axum::http::StatusCode::BAD_REQUEST, + ), + } + } +} + +#[cfg(test)] +mod tests { + use super::*; + use crate::reducer::{GlobalTree, VoteData}; + + fn seed_children(parent: &ItemId, ids: &[&str]) -> GlobalTree { + let mut tree = GlobalTree::new(); + tree.ensure_path(parent); + for id in ids { + let child = ItemId::parse(id).unwrap(); + tree.ensure_path(&child); + if let Some(p) = tree.nodes.get_mut(parent) { + p.children.insert(child); + } + } + tree + } + + fn pair_set(pair: &(ItemId, ItemId)) -> HashSet<&str> { + [pair.0.as_str(), pair.1.as_str()].into_iter().collect() + } + + #[test] + fn suggest_prefers_unvoted_pair() { + let parent = ItemId::parse("reddit.com/r/rust").unwrap(); + let mut tree = seed_children( + &parent, + &[ + "reddit.com/r/rust/a", + "reddit.com/r/rust/b", + "reddit.com/r/rust/c", + ], + ); + let vote = + VoteData::from_recorded(1, "reddit.com/r/rust/a", "reddit.com/r/rust/b", 2, 1).unwrap(); + tree.apply_vote(&parent, vote); + let group = tree.get(&parent).unwrap().local_ranking.clone(); + let pool = children_of(&tree, &parent); + let (l, r) = suggest_next_pair_in_pool(&group, &pool, None).unwrap(); + let voted_ab = (l.as_str() == "reddit.com/r/rust/a" && r.as_str() == "reddit.com/r/rust/b") + || (l.as_str() == "reddit.com/r/rust/b" && r.as_str() == "reddit.com/r/rust/a"); + assert!(!voted_ab); + } + + #[test] + fn suggest_bridges_separate_components() { + let parent = ItemId::parse("reddit.com/r/rust").unwrap(); + let mut tree = seed_children( + &parent, + &[ + "reddit.com/r/rust/a", + "reddit.com/r/rust/b", + "reddit.com/r/rust/c", + "reddit.com/r/rust/d", + ], + ); + let ab = VoteData::from_recorded(1, "reddit.com/r/rust/a", "reddit.com/r/rust/b", 2, 1).unwrap(); + let cd = VoteData::from_recorded(2, "reddit.com/r/rust/c", "reddit.com/r/rust/d", 2, 1).unwrap(); + tree.apply_vote(&parent, ab); + tree.apply_vote(&parent, cd); + let group = tree.get(&parent).unwrap().local_ranking.clone(); + let pool = children_of(&tree, &parent); + let pair = suggest_next_pair_in_pool(&group, &pool, None).unwrap(); + let chosen = pair_set(&pair); + let from_ab = chosen.contains("reddit.com/r/rust/a") || chosen.contains("reddit.com/r/rust/b"); + let from_cd = chosen.contains("reddit.com/r/rust/c") || chosen.contains("reddit.com/r/rust/d"); + assert!(from_ab && from_cd, "expected bridge pair, got {:?}", chosen); + } + + #[test] + fn suggest_connects_isolate_to_existing_component() { + let parent = ItemId::parse("reddit.com/r/rust").unwrap(); + let mut tree = seed_children( + &parent, + &[ + "reddit.com/r/rust/a", + "reddit.com/r/rust/b", + "reddit.com/r/rust/c", + ], + ); + let ab = VoteData::from_recorded(1, "reddit.com/r/rust/a", "reddit.com/r/rust/b", 2, 1).unwrap(); + tree.apply_vote(&parent, ab); + let group = tree.get(&parent).unwrap().local_ranking.clone(); + let pool = children_of(&tree, &parent); + let pair = suggest_next_pair_in_pool(&group, &pool, None).unwrap(); + let chosen = pair_set(&pair); + assert!(chosen.contains("reddit.com/r/rust/c")); + assert!(chosen.contains("reddit.com/r/rust/a") || chosen.contains("reddit.com/r/rust/b")); + } + + #[test] + fn resolve_pair_picks_from_pool() { + let parent = ItemId::parse("reddit.com/r/rust").unwrap(); + let tree = seed_children(&parent, &["reddit.com/r/rust/a", "reddit.com/r/rust/b"]); + let pair = resolve_pair(&tree, &parent, None, None).unwrap(); + let pool: HashSet<_> = ["reddit.com/r/rust/a", "reddit.com/r/rust/b"] + .into_iter() + .collect(); + assert!(pool.contains(pair.0.as_str())); + assert!(pool.contains(pair.1.as_str())); + } +} diff --git a/server/src/path_types.rs b/server/src/path_types.rs index 12dce9888f5cd4e1a0974d12d6468368d0f775b9..a0d1a028b8bd3c5d1c714dea3ec597d1ac39e1bc 100644 --- a/server/src/path_types.rs +++ b/server/src/path_types.rs @@ -40,6 +40,22 @@ impl ItemId { Self::canonicalize(raw_url).map(Self) } + /// Normalize strings from forms, events, and Reddit imports into the same + /// stored id shape (e.g. drop post title slug after comment id). + pub fn from_storage(s: &str) -> Option { + let t = s.trim(); + if t.is_empty() { + return None; + } + if t.contains("://") || t.starts_with("r/") { + return Self::from_url(t).or_else(|| Self::parse(t)); + } + if t.starts_with("reddit.com/") && t.contains("/comments/") { + return Self::from_url(t).or_else(|| Self::parse(t)); + } + Self::parse(t).or_else(|| Self::from_url(t)) + } + /// Map legacy scope keys (`""`, `"rust"`) to fractal parent nodes. pub fn from_legacy_scope(raw: &str) -> Self { let s = raw.trim(); @@ -324,6 +340,12 @@ mod tests { assert_eq!(id.as_str(), "reddit.com/r/amitheasshole"); } + #[test] + fn from_storage_strips_post_title_slug() { + let id = ItemId::from_storage("reddit.com/r/rust/comments/aaa/announcing_rust_199").unwrap(); + assert_eq!(id.as_str(), "reddit.com/r/rust/comments/aaa"); + } + #[test] fn from_browse_uri_strips_prefix() { let id = ItemId::from_browse_uri("/~/https://reddit.com/r/rust").unwrap(); diff --git a/server/src/reddit.rs b/server/src/reddit.rs index 1168ec2afc77c092514eec91b513bac301cbe225..626454e5a2f638734193b5190a2beea286af85b6 100644 --- a/server/src/reddit.rs +++ b/server/src/reddit.rs @@ -567,7 +567,7 @@ fn parse_children(_parent: &ItemId, payload: &Value) -> Vec<(ItemId, Value)> { _ => continue, }; let path = format!("reddit.com{}", permalink.trim_end_matches('/')); - if let Some(id) = ItemId::parse(&path) { + if let Some(id) = ItemId::from_storage(&path) { out.push((id, child.clone())); } } diff --git a/server/src/reducer.rs b/server/src/reducer.rs index 336e78b77d3ab59361b89af5c9868e13da4ac962..fc23f41137d7df33997afe19c533505c250cc305 100644 --- a/server/src/reducer.rs +++ b/server/src/reducer.rs @@ -28,8 +28,8 @@ impl VoteData { ratio_left: i32, ratio_right: i32, ) -> Option { - let a = ItemId::parse(a)?; - let b = ItemId::parse(b)?; + let a = ItemId::from_storage(a)?; + let b = ItemId::from_storage(b)?; if a == b { return None; } @@ -85,8 +85,8 @@ impl GroupState { } pub fn apply_vote(&mut self, mut vote: VoteData) { - vote.a = ItemId::parse(vote.a.as_str()).unwrap_or_else(|| vote.a.clone()); - vote.b = ItemId::parse(vote.b.as_str()).unwrap_or_else(|| vote.b.clone()); + vote.a = ItemId::from_storage(vote.a.as_str()).unwrap_or(vote.a.clone()); + vote.b = ItemId::from_storage(vote.b.as_str()).unwrap_or(vote.b.clone()); if vote.ratio_left < 0 { vote.ratio_left = 0; } diff --git a/server/src/state.rs b/server/src/state.rs index d238701208a1c708b94a778a6a2e1891a678ecbc..4c3008e73cc74d8483a2064a0a280e73d82a01ec 100644 --- a/server/src/state.rs +++ b/server/src/state.rs @@ -18,7 +18,7 @@ pub fn parse_item_param(raw: &str) -> ItemId { if s.is_empty() { return ItemId::root(); } - ItemId::from_url(s).or_else(|| ItemId::parse(s)).unwrap_or_else(|| ItemId::opaque(s)) + ItemId::from_storage(s).unwrap_or_else(|| ItemId::opaque(s)) } /// Legacy: normalize raw ranking subject into a scope key for old event replay. diff --git a/server/src/ui_action.rs b/server/src/ui_action.rs index 53581e1362bfcc5dfb4ae3069c41ea6f7be41437..237411a689fb10ad1b7022ea66aee1969c7507ec 100644 --- a/server/src/ui_action.rs +++ b/server/src/ui_action.rs @@ -31,9 +31,9 @@ pub enum HtmlUiAction { /// Parent node [`ItemId`] string; empty = tree root. #[serde(default)] scope: String, - /// After vote, navigate here (vote compare page). + /// Posted from `/vote` compare UI — morph edge history in place. #[serde(default)] - next: String, + vote_compare: bool, }, /// Parse pasted Reddit URL/path; redirect to subreddit ranking on success. ParseQuery { @@ -98,7 +98,7 @@ mod tests { ratio_left: 60, ratio_right: 40, scope: "parent".into(), - next: String::new(), + vote_compare: false, } ); } @@ -129,7 +129,7 @@ mod tests { ratio_left: 2, ratio_right: 1, scope: "amitheasshole".into(), - next: String::new(), + vote_compare: false, } ); } @@ -156,7 +156,7 @@ mod tests { ratio_left: 2, ratio_right: 1, scope: String::new(), - next: String::new(), + vote_compare: false, } ); } diff --git a/server/static/sorter.css b/server/static/sorter.css index 3c2cec5cb5094013387147c621d75bd341bc06cc..b95718ce463b200a5667d3014dac2119836a0bef 100644 --- a/server/static/sorter.css +++ b/server/static/sorter.css @@ -289,11 +289,27 @@ h1 { } .vote-compare-nav { + margin: 1rem 0 0.5rem; +} + +.vote-compare-actions { display: flex; - justify-content: space-between; + flex-wrap: wrap; align-items: center; - gap: 1rem; - margin: 1rem 0; + gap: 0.75rem; + margin-top: 0.5rem; +} + +.vote-compare-actions .btn-secondary { + margin-top: 0; + display: inline-block; + text-decoration: none; + line-height: 1.4; +} + +.vote-compare-actions .vote-compare-next.is-disabled { + opacity: 0.6; + cursor: default; } .vote-compare-next { diff --git a/server/static/sorter_ui.js b/server/static/sorter_ui.js index c8d7c3ef2413399ced7898a7edb3e7a2c8e16163..ab15d27f508cc6f5fbca9d8926fd0ca26d64857b 100644 --- a/server/static/sorter_ui.js +++ b/server/static/sorter_ui.js @@ -104,11 +104,10 @@ if (f.getAttribute('data-navigate') === 'full') return; e.preventDefault(); await postUiForm(f); - if (f.id === 'vote-form' || f.id === 'vote-compare-form') { + if (f.id === 'vote-form') { f.reset(); - var slider = f.querySelector('#vote-preference-slider'); - if (slider) slider.value = '50'; - initVoteSlider(); + var firstField = f.querySelector('input[type="text"]'); + if (firstField) firstField.focus(); } }); } diff --git a/server/tests/integration_ui.rs b/server/tests/integration_ui.rs index df7d9ab357531c5146d0b326c149fdaa6b531a4a..56d2db313b313ffce07eff38a8ccdaa2fbb9498f 100644 --- a/server/tests/integration_ui.rs +++ b/server/tests/integration_ui.rs @@ -25,6 +25,53 @@ async fn start_test_server() -> (SocketAddr, TempDir) { (addr, tmp) } +#[tokio::test] +async fn post_ui_vote_compare_morphs_edge_history() { + let (addr, _tmp) = start_test_server().await; + let parent = "reddit.com/r/rust"; + let a = "reddit.com/r/rust/comments/aaa/announcing_rust_199"; + let b = "reddit.com/r/rust/comments/bbb/what_are_you_working_on"; + + let rpc = serde_json::json!({ + "action": "record_vote", + "a": a, + "b": b, + "ratio_left": {"$form:i32": "ratio_left"}, + "ratio_right": {"$form:i32": "ratio_right"}, + "scope": parent, + "vote_compare": true, + }) + .to_string(); + let mut form = HashMap::new(); + form.insert(UI_RPC_FIELD.to_string(), rpc); + form.insert("ratio_left".into(), "70".into()); + form.insert("ratio_right".into(), "30".into()); + + let client = reqwest::Client::new(); + let body = client + .post(format!("http://{addr}/ui")) + .form(&form) + .send() + .await + .unwrap() + .text() + .await + .unwrap(); + + assert!( + body.contains("vote-edge-history"), + "expected edge history morph, got: {body}" + ); + assert!( + body.contains("70:30"), + "expected recorded ratio in morph, got: {body}" + ); + assert!( + !body.contains("no votes on this pair yet"), + "should not show empty edge history after vote, got: {body}" + ); +} + #[tokio::test] async fn post_ui_record_vote_morphs_ranking_and_persists() { let (addr, tmp) = start_test_server().await; diff --git a/test/reddit_import.clj b/test/reddit_import.clj index 45a2a19f20799d77e84d8aa64735ab5e7e45f97c..b476488526252c13fd73bdda76e5201678e4a714 100644 --- a/test/reddit_import.clj +++ b/test/reddit_import.clj @@ -2,9 +2,8 @@ (:require [babashka.process :as process] [clojure.java.io :as io] [clojure.string :as str] - [clojure.test :refer [deftest is testing]]) - (:import [com.sun.net.httpserver HttpServer HttpHandler HttpExchange] - [java.net InetSocketAddress])) + [clojure.test :refer [deftest is testing]] + [test.support.mock-reddit :as mock-reddit])) (defn- repo-root [] (.getCanonicalPath (io/file (System/getProperty "user.dir")))) @@ -13,29 +12,6 @@ (with-open [s (java.net.ServerSocket. 0)] (.getLocalPort s))) -(defn- start-mock-reddit [port fixtures-dir] - (let [about (.getBytes (slurp (io/file fixtures-dir "r_rust_about.json")) "UTF-8") - listing (.getBytes (slurp (io/file fixtures-dir "r_rust_listing.json")) "UTF-8") - server (HttpServer/create (InetSocketAddress. "127.0.0.1" port) 0) - handler - (proxy [HttpHandler] [] - (handle [^HttpExchange exchange] - ;; Route by path: `/r//about.json` is the subreddit entity, - ;; `/r/.json` is the children listing. - (let [path (.getPath (.getRequestURI exchange)) - body (if (str/includes? path "/about") - about - listing)] - (.sendResponseHeaders exchange 200 (alength body)) - (let [out (.getResponseBody exchange)] - (.write out body) - (.close out)))))] - (.createContext server "/" handler) - (.setExecutor server nil) - (.start server) - (fn stop [] - (.stop server 0)))) - (defn- wait-health [base-url ms] (let [deadline (+ (System/currentTimeMillis) ms) url (str base-url "/healthz")] @@ -100,7 +76,7 @@ (deftest reddit-fetch-via-mock-api (testing "Fetch more queues import; event log stores full payload; page shows title" (let [root (repo-root) - fixtures (str root "/test/fixtures/reddit") + fixtures (mock-reddit/fixtures-dir root) data-dir (.getAbsolutePath (doto (io/file (System/getProperty "java.io.tmpdir") (str "sorter2-reddit-" (System/currentTimeMillis))) @@ -110,7 +86,7 @@ reddit-base (str "http://127.0.0.1:" reddit-port) app-base (str "http://127.0.0.1:" app-port) bin (str root "/target/release/sorter2-server") - stop-mock (start-mock-reddit reddit-port fixtures)] + stop-mock (mock-reddit/start-mock-reddit reddit-port fixtures)] (try (is (zero? (:exit (process/shell {:dir root} "cargo" "build" "--release" "--package" "sorter2-server"))) diff --git a/test/support/mock_reddit.clj b/test/support/mock_reddit.clj new file mode 100644 index 0000000000000000000000000000000000000000..5efa92db3e1f79b8f423a2f1adcbda959123c1ad --- /dev/null +++ b/test/support/mock_reddit.clj @@ -0,0 +1,35 @@ +(ns test.support.mock-reddit + "In-process HTTP stub for Reddit API fixtures (`test/fixtures/reddit/`)." + (:require [clojure.java.io :as io] + [clojure.string :as str]) + (:import [com.sun.net.httpserver HttpServer HttpHandler HttpExchange] + [java.net InetSocketAddress])) + +(defn fixtures-dir + ([] (fixtures-dir (System/getProperty "user.dir"))) + ([root] (str root "/test/fixtures/reddit"))) + +(defn start-mock-reddit + "Start a mock Reddit API on `port`. Returns a zero-arg `stop` function." + ([port] (start-mock-reddit port (fixtures-dir))) + ([port dir] + (let [about (.getBytes (slurp (io/file dir "r_rust_about.json")) "UTF-8") + listing (.getBytes (slurp (io/file dir "r_rust_listing.json")) "UTF-8") + server (HttpServer/create (InetSocketAddress. "127.0.0.1" port) 0) + handler + (proxy [HttpHandler] [] + (handle [^HttpExchange exchange] + ;; `/r//about.json` → subreddit entity; `/r/.json` → listing. + (let [path (.getPath (.getRequestURI exchange)) + body (if (str/includes? path "/about") + about + listing)] + (.sendResponseHeaders exchange 200 (alength body)) + (let [out (.getResponseBody exchange)] + (.write out body) + (.close out)))))] + (.createContext server "/" handler) + (.setExecutor server nil) + (.start server) + (fn stop [] + (.stop server 0))))) diff --git a/test/vote_compare.clj b/test/vote_compare.clj new file mode 100644 index 0000000000000000000000000000000000000000..fbc00281e466a1ba0833193c7b96fa30aeb45a5c --- /dev/null +++ b/test/vote_compare.clj @@ -0,0 +1,101 @@ +(ns test.vote-compare + (:require [babashka.process :as process] + [clojure.java.io :as io] + [clojure.string :as str] + [clojure.test :refer [deftest is testing]] + [com.blockether.spel.core :as core] + [com.blockether.spel.locator :as loc] + [com.blockether.spel.page :as page] + [test.support.mock-reddit :as mock-reddit]) + (:import [java.net URLEncoder])) + +(defn- repo-root [] + (.getCanonicalPath (io/file (System/getProperty "user.dir")))) + +(defn- pick-port [] + (with-open [s (java.net.ServerSocket. 0)] + (.getLocalPort s))) + +(defn- wait-health [base-url ms] + (let [deadline (+ (System/currentTimeMillis) ms) + url (str base-url "/healthz")] + (loop [] + (let [resp (try + (process/shell {:out :string :err :string} + "curl" "-sf" url) + (catch Exception _ nil))] + (if (and resp (zero? (:exit resp)) (= "ok" (str/trim (:out resp "")))) + true + (if (< (System/currentTimeMillis) deadline) + (do (Thread/sleep 200) (recur)) + false)))))) + +(defn- curl-fetch-children [base item] + (process/shell {:out :string :err :string} + "curl" "-sfN" "--max-time" "20" + "-X" "POST" (str base "/ui") + "--data-urlencode" + (str "__rpc__={\"action\":\"fetch_entity\",\"item\":\"" item + "\",\"kind\":\"children\"}"))) + +(defn- vote-page-url [base parent] + (str base "/vote?parent=" + (URLEncoder/encode parent "UTF-8"))) + +(deftest vote-compare-shows-recorded-vote-after-post + (testing "post vote on /vote morphs edge history (mock Reddit children seeded)" + (let [root (repo-root) + fixtures (mock-reddit/fixtures-dir root) + data-dir (.getAbsolutePath + (doto (io/file (System/getProperty "java.io.tmpdir") + (str "sorter2-vote-" (System/currentTimeMillis))) + (.mkdirs))) + reddit-port (pick-port) + app-port (pick-port) + reddit-base (str "http://127.0.0.1:" reddit-port) + app-base (str "http://127.0.0.1:" app-port) + bin (str root "/target/release/sorter2-server") + stop-mock (mock-reddit/start-mock-reddit reddit-port fixtures)] + (try + (is (zero? (:exit (process/shell {:dir root} + "cargo" "build" "--release" "--package" "sorter2-server"))) + "release build succeeds") + (let [proc (process/process {:dir root + :env (into (into {} (System/getenv)) + {"SORTER2_SKIP_DOTENV" "1" + "SORTER2_DATA_DIR" data-dir + "SORTER2_EVENT_LOG" (str data-dir "/events.jsonl") + "PORT" (str app-port) + "REDDIT_API_BASE" reddit-base + "REDDIT_OAUTH_BASE" reddit-base + "REDDIT_CLIENT_ID" "" + "REDDIT_CLIENT_SECRET" "" + "REDDIT_APP_ID" "" + "REDDIT_APP_SECRET" ""}) + :out :string + :err :string} + bin)] + (try + (is (wait-health app-base 20000) "app healthz") + (let [fetch (curl-fetch-children app-base "reddit.com/r/rust")] + (is (zero? (:exit fetch)) "fetch posts via mock Reddit") + (is (str/includes? (:out fetch) "Idiomorph.morph"))) + (core/with-testing-page [pg] + (page/navigate pg (vote-page-url app-base "reddit.com/r/rust")) + (page/wait-for-selector pg "#vote-compare-form") + (let [before (loc/text-content (page/locator pg "#vote-edge-history-region"))] + (is (str/includes? before "no votes on this pair yet") + "empty edge history before first vote")) + (loc/click (page/get-by-test-id pg "vote-post")) + (page/wait-for-selector pg ".vote-edge-history-title") + (let [after (loc/text-content (page/locator pg "#vote-edge-history-region"))] + (is (str/includes? after "votes on this pair") + "shows edge history title after vote") + (is (str/includes? after "50:50") + "shows submitted ratio after vote") + (is (not (str/includes? after "no votes on this pair yet")) + "does not revert to empty edge history"))) + (finally + (process/destroy proc)))) + (finally + (stop-mock))))))