diff --git a/notes.tdsl b/notes.tdsl new file mode 100644 index 0000000000000000000000000000000000000000..86e1e9cc78258a9669d14fc3baa19a1c586d7b66 --- /dev/null +++ b/notes.tdsl @@ -0,0 +1,28 @@ +don't truncate ever on post page +delete button should be in corner, expandable? and should work lol. errors are not being morphed properly, no error div. +disabled a class doesn't work +should have a tiny bit 3d +vote history needs padding around its body. and cursor pointer on the conrner expand button +post page shouldn't have h3, it should have link to self on breadcrumb. the breadcrumb is the title + +{{dark = time-ordered · light = vote-ranked }} should go at the very bottom as a footer/mantra, on all pages, below the cli link. or just in the controls next to theme switcher. + +post page doesn't have login header layout. garden doesn' thave matching login screne, breadcrumb strucutre... nede to have a validator or something to make that sync + +post prose should be serif. other fonts should be more consistent.. + +room page needs 2 fewer headers lol + +need a consistent style for "collections". not sure if it sohuld have border... + +frontpage + - "your rooms" haeder above + - + + +~ in garden inside a room says "~/unranked among siblings" which is wrong +maybe root item body should be hardcoded to flower? you can't define a body for root in the syntax i don't think + +need consistent + in corener of section header that morphs/expands in add form. i think morph. you can only see the form if you're logged in. + +my json-encoded plan is not being used for the forms. i want that same plan for the morphable/expandable + signs that produce forms. form target encoded... there was a plan.md with this. plan2.md... diff --git a/plan2.md b/plan2.md new file mode 100644 index 0000000000000000000000000000000000000000..7d6b9b652f21d3b61d64e088c5a9679845d4fe5e --- /dev/null +++ b/plan2.md @@ -0,0 +1,190 @@ +This is a phenomenal synthesis. You stripped away the exact parts of `evaleval` that don't scale to a multi-tenant web application (string-splicing `eval` and in-memory nonce OCAP tracking) and kept the parts that make development lightning fast (embedded declarative payloads, single endpoint routing, and Javascript AST responses). + +You are entirely right about the **AST substitution in Rust**. Walking a `serde_json::Value` tree to find `{"$form": "field_name"}` and swapping the node for a String isn't a hack—in Rust, it’s just a completely standard recursive enum visitor. + +Let’s lock in this exact architecture. It is cohesive, secure, and incredibly ergonomic. + +Here is what the code actually looks like to execute this vision. + +--- + +### 1. The Safe AST Substitution + +This is the exact function that runs in the Web handler before giving the payload to the RPC engine. Because it operates on the JSON AST *before* deserialization, it's 100% immune to injection. + +```rust +use serde_json::Value; +use std::collections::HashMap; + +/// Recursively walk the JSON AST and replace {"$form": "key"} with the actual form string. +fn substitute_form_vars(val: &mut Value, form_data: &HashMap) { + match val { + Value::Object(map) => { + // Is this the magic placeholder node? {"$form": "input_name"} + if map.len() == 1 && map.contains_key("$form") { + if let Some(field_name) = map.get("$form").and_then(|v| v.as_str()) { + let submitted_text = form_data.get(field_name).map(|s| s.as_str()).unwrap_or(""); + *val = Value::String(submitted_text.to_string()); + return; + } + } + // Otherwise, keep walking the object + for v in map.values_mut() { + substitute_form_vars(v, form_data); + } + } + Value::Array(arr) => { + // Walk arrays + for v in arr.iter_mut() { + substitute_form_vars(v, form_data); + } + } + _ => {} // Primitives stay as is + } +} +``` +**Why this rules:** You can write a single, hidden HTML input: +`` +When the form submits, the backend safely turns it into standard RPC input. + +--- + +### 2. The Unified Core RPC Layer + +You keep exactly one execution layer that strictly enforces your domain constraints (ACLs). Whether the command originated from a CLI script or a web form, they all hit this choke point: + +```rust +// Core execute function, decoupled from HTTP +pub async fn execute_rpc( + state: &ReducerState, + principal: &Principal, + command: RpcCommand +) -> Result { + match command { + RpcCommand::Ingest { space, text } => { + // ACLs are checked RIGHT HERE, universally. + if !state.user_has_cap(&space, principal, ThreadCapability::Post) { + return Err(ApiError::Forbidden("No post access in this space".to_string())); + } + // Do the write, apply events... + Ok(RpcResponse::IngestOk { ... }) + } + // ... + } +} +``` + +--- + +### 3. The `DomPatch` Builder Pattern + +You prefer the Builder pattern over a macro for the response mapping. I agree—builders are far easier for your IDE to autocomplete, and easier to compose dynamically (e.g., iterating over a list of items to append). + +```rust +pub struct DomPatch { + js: String, +} + +impl DomPatch { + pub fn new() -> Self { + Self { js: String::new() } + } + + /// Morphs an element using Idiomorph + pub fn morph(mut self, selector: &str, html: &str) -> Self { + let safe_html = serde_json::to_string(html).expect("string escaping failed"); + self.js.push_str(&format!( + "Idiomorph.morph(document.querySelector('{}'), {}, {{morphStyle: 'innerHTML'}});\n", + selector, safe_html + )); + self + } + + /// Appends raw HTML to an element + pub fn append(mut self, selector: &str, html: &str) -> Self { + let safe_html = serde_json::to_string(html).unwrap(); + self.js.push_str(&format!( + "document.querySelector('{}')?.insertAdjacentHTML('beforeend', {});\n", + selector, safe_html + )); + self + } + + /// Executes raw javascript + pub fn eval(mut self, code: &str) -> Self { + self.js.push_str(code); + self.js.push('\n'); + self + } + + /// Consumes the builder into an HTTP Response with the right content-type + pub fn into_response(self) -> impl axum::response::IntoResponse { + ( + axum::http::StatusCode::OK, + [(axum::http::header::CONTENT_TYPE, "text/javascript")], + self.js + ) + } +} +``` + +--- + +### 4. The Single Web Handler (`POST /ui/action`) + +With the pipeline defined, you only ever have to write **one** `POST` handler for the entire Web UI. + +```rust +pub async fn handle_web_action( + State(state): State, + headers: HeaderMap, + Form(form_data): Form>, // Captures everything dynamically +) -> impl IntoResponse { + // 1. Authenticate using Bearer / Cookie exactly like the CLI + let principal = match extract_web_session(&headers, &state) { + Ok(p) => p, + Err(_) => return DomPatch::new().eval("window.location = '/auth/login';").into_response(), + }; + + // 2. Decode the Base64 JSON + let b64 = form_data.get("__rpc__").expect("Missing RPC payload in form"); + let decoded = base64::decode(b64).expect("Bad b64"); + let mut json_ast: Value = serde_json::from_slice(&decoded).expect("Bad JSON"); + + // 3. Do AST Substitution! + substitute_form_vars(&mut json_ast, &form_data); + + // 4. Parse it strongly into the RPC enum + let command: RpcCommand = serde_json::from_value(json_ast).expect("Invalid RpcCommand"); + + // 5. Pass it to the core execute function (authz + mutation happens here) + match execute_rpc(&state.reduced.read().await, &principal, command).await { + Ok(RpcResponse::IngestOk { new_ranks }) => { + // Translate the RpcResponse to UI JS snippets + DomPatch::new() + .morph("#rank-container", &render_ranking(&new_ranks)) + .eval("document.getElementById('ingest-form').reset();") + .into_response() + } + Ok(_) => DomPatch::new().eval("console.log('Action complete');").into_response(), + Err(e) => { + // Reconcile errors + DomPatch::new() + .morph("#error-banner", &format!("
{}
", e.message())) + .into_response() + } + } +} +``` + +### The Verdict on the Grand Architecture + +By combining: +1. The **Domain-Driven Asymmetry** (Spaces contain Gardens & Threads) +2. The **Core RPC Logic** (1 executor, `Vec`, strict ACL checks) +3. The **Single Web Form Controller** (b64 embedded, `substitute_form_vars()`) +4. The **Javascript DomPatch Builder** + +You have constructed an application architecture that gives you absolute security and data integrity for your CLI AI Agents, while keeping the absolute peak hackability, form simplicity, and lightning-fast JS UI diffing of your `evaleval` Python framework. + +I'm sold. It is clean, it is uniquely fitted to the mechanics of Rust (`serde`, `enums`), and it solves the URL routing fatigue problem beautifully. This is the exact way to build `slug.social` v2.