Side A adds a genuinely useful diagnostic script (sample-fixture) and cleanly refactors the monolithic forum.rs into cohesive submodules (access, ingest, nav, new_thread, room_members), improving maintainability with minimal behavioral risk. Side B merely deletes an entire feature (the tree view UI, its routes, and its well-covered test suite) with no replacement or migration path, which removes functionality and prior test coverage rather than adding lasting value.
constitution · epochs · watch · epoch 3
comparison
c_59974b9da42a (tommy-mor) vs c_0e1a063d5849 (tommy-mor)
download prompt · raw event · cmp_3a4fcf35c20f25
council reasoning
A modularizes the live forum HTML stack into focused modules (nav, ingest, access, new_thread, room_members), which is lasting structure on core product code, plus adds a reusable sample-fixture helper. B only deletes the abandoned tree UI (~819 lines) and its exports—valuable cleanup, but pure subtraction without improving design of what remains.
Side A performs a substantial architectural refactor by splitting the forum code into focused modules (such as access, ingest, navigation, room members, and new-thread handling), while preserving behavior and introducing reusable helpers like ThreadNav and permission checks. It also adds a useful developer profiling script (`sample-fixture`) for diagnosing fixture processes, whereas Side B primarily removes the entire tree feature (`tree.rs`) and its exports, which is mostly feature deletion rather than an enduring improvement to the codebase.
sides
A — c_59974b9da42a (tommy-mor)
message
[c99adc26] refactor forum into files
diff preview
diff --git a/bb.edn b/bb.edn
index 4680e82d4227057d2eea6041dc5647beb759131d..ce0f6fcd45a67ead3295b90db2a301e9b304f3da 100644
--- a/bb.edn
+++ b/bb.edn
@@ -51,6 +51,11 @@
:requires ([test.walkthrough-fixture :as walkthrough-fixture])
:task (walkthrough-fixture/run-fixture)}
+ sample-fixture
+ {:doc "macOS: run `sample` on process(es) listening on the fixture TCP port (default 8080). Usage: bb sample-fixture [PORT] [DURATION_SEC] [OUT_DIR]"
+ :requires ([scripts.sample-fixture :as sample-fixture])
+ :task (apply sample-fixture/-main *command-line-args*)}
+
perf
{:doc "Performance test: concurrent HTTP requests to detect blocking I/O"
:requires ([scripts.perf :as perf])
diff --git a/scripts/sample_fixture.bb b/scripts/sample_fixture.bb
new file mode 100644
index 0000000000000000000000000000000000000000..ac2368623c5043ba6e027afef6b5b37d392767b0
--- /dev/null
+++ b/scripts/sample_fixture.bb
@@ -0,0 +1,70 @@
+(ns scripts.sample-fixture
+ "Find process(es) listening on the fixture port (default 8080) and run macOS `sample`."
+ (:require [babashka.fs :as fs]
+ [babashka.process :as p]
+ [clojure.string :as str]))
+
+(defn- usage []
+ (println "Usage: bb sample-fixture [PORT] [DURATION_SEC] [OUT_DIR]")
+ (println "")
+ (println " Finds PIDs bound to TCP LISTEN on PORT (default 8080), then runs")
+ (println " `sample` for each PID. OUT_DIR defaults to the current directory.")
+ (println "")
+ (println " Example: bb sample-fixture")
+ (println " bb sample-fixture 8080 10")
+ (println " bb sample-fixture 8080 5 /tmp")
+ (println "")
+ (println " Requires macOS (the `sample` tool)."))
+
+(defn- parse-long* [s]
+ (try (Long/parseLong s)
+ (catch NumberFormatException _ nil)))
+
+(defn- listen-pids [port]
+ (let [spec (str "TCP:" port)
+ {:keys [out exit]}
+ @(p/process ["lsof" "-nP" (str "-i" spec) "-sTCP:LISTEN" "-t"]
+ {:out :string :err :string})]
+ (when (zero? exit)
+ (->> (str/split-lines out)
+ (map str/trim)
+ (remove str/blank?)
+ (distinct)
+ vec))))
+
+(defn- sample-bin []
+ (or (fs/which "sample")
+ (throw (ex-info "macOS `sample` not found on PATH" {}))))
+
+(defn- run-sample! [sample duration-sec pid out-file]
+ (println (str "sampling PID " pid " for " duration-sec "s → " out-file))
+ (let [{:keys [exit err]} @(p/process [sample (str pid) (str duration-sec) "-file" out-file]
+ {:out :inherit :err :inherit})]
+ (when-not (zero? exit)
+ (binding [*out* *err*]
+ (println "sample failed:" err))
+ (System/exit exit))))
+
+(defn -main [& args]
+ (when (some #{"-h" "--help" "help"} args)
+ (usage)
+ (System/exit 0))
+ (let [port (or (some-> (first args) parse-long*) 8080)
+ duration-sec (or (some-> (second args) parse-long*) 5)
+ out-dir (or (nth args 2 nil) ".")
+ pids (listen-pids port)]
+ (when (or (nil? pids) (empty? pids))
+ (binding [*out* *err*]
+ (println (str "No process listening on TCP " port " (LISTEN). Is `bb fixture` running?")))
+ (System/exit 1))
+ (when-not (fs/exists? out-dir)
+ (binding [*out* *err*]
+ (println "Output directory does not exist:" out-dir))
+ (System/exit 1))
+ (let [sample (sample-bin)
+ ts (str (System/currentTimeMillis))]
+ (println (str "port " port " → PIDs " (str/join ", " pids)))
+ (doseq [pid pids]
+ (let [out-file (str (fs/path out-dir) "/slug-sample-" port "-" pid "-" ts ".txt")]
+ (run-sample! sample duration-sec pid (str out-file))))
+ (println "done."))))
diff --git a/server/src/html/forum.rs b/server/src/html/forum.rs
index a55fc1f79d03719eb74b216865b2c15199c48ea7..5ad8dfc84dd735d589432e2c613ff687a75f2e61 100644
--- a/server/src/html/forum.rs
+++ b/server/src/html/forum.rs
@@ -380,22 +380,6 @@ fn room_members_inner(members: &[RoomMemberRow]) -> Markup {
}
}
-pub(crate) fn set_room_members_expanded_rpc(room_wire: &str, expanded: bool) -> String {
- template_json_compact(&HtmlUiAction::SetRoomMembersExpanded {
- room_wire: room_wire.to_string(),
- expanded,
- })
- .expect("static json")
-}
-
-pub(crate) fn set_room_new_thread_compose_expanded_rpc(nav: &ThreadNav, expanded: bool) -> String {
- template_json_compact(&HtmlUiAction::SetRoomNewThreadComposeExpanded {
- room_wire: nav.room_wire.clone(),
- expanded,
- })
- .expect("static json")
-}
-
/// Fragment for `#room-members-section` — expand/collapse is server-driven via `POST /ui`.
pub(crate) fn room_members_section_markup(
reduced: &ReducerState,
@@ -406,13 +390,14 @@ pub(crate) fn room_members_section_markup(
if members.is_empty() {
return html! {};
}
- let rpc_open = set_room_members_expanded_rpc(room_id, true);
- let rpc_close = set_room_members_expanded_rpc(room_id, false);
html! {
div id="room-members-section" {
@if members_expanded {
form method="POST" action="/ui" {
- input type="hidden" name=(UI_RPC_FIELD) value=(rpc_close);
+ input type="hidden" name=(UI_RPC_FIELD) value=(template_json_compact(&HtmlUiAction::SetRoomMembersExpanded {
+ room_wire: room_id.to_string(),
+ expanded: false,
+ }).expect("static json"));
button type="submit" class="form-toggle" aria-expanded="true" {
"hide members & permissions"
}
@@ -422,7 +407,10 @@ pub(crate) fn room_members_section_markup(
}
} @else {
form method="POST" action="/ui" {
- input type="hidden" name=(UI_RPC_FIELD) value=(rpc_open);
+ input type="hidden" name=(UI_RPC_FIELD) value=(template_json_compact(&HtmlUiAction::SetRoomMembersExpanded {
+ room_wire: room_id.to_string(),
+ expanded: true,
+ }).expect("static json"));
button type="submit" class="form-toggle" aria-expanded="false" {
"members & permissions"
}
@@ -514,28 +502,24 @@ fn compose_form(nav: &ThreadNav, thread_tag: &str, show: bool) -> Markup {
if !show {
return html! {};
}
- let rpc_post = template_json_compact(&json!({
- "action": "post_ingest",
- "room": nav.room_wire,
- "thread_tag": thread_tag,
- "text": {"$form": "text"},
- "error_target": "thread-compose-errors",
- "form_id": "thread-compose-form",
- }))
- .unwrap();
- let rpc_check = template_json_compact(&json!({
- "action": "check_ingest",
- "room": nav.room_wire,
- "thread_tag": thread_tag,
- "text": {"$form": "text"},
- "error_target": "thread-compose-errors",
- "form_id": "thread-compose-form",
- }))
- .unwrap();
html! {
section class="compose" id="thread-compose" {
- form id="thread-compose-form" method="POST" action="/ui" data-check-action="/ui" data-check-rpc=(rpc_check) {
- input type="hidden" name=(UI_RPC_FIELD) value=(rpc_post);
+ form id="thread-compose-form" method="POST" action="/ui" data-check-action="/ui" data-check-rpc=(template_json_compact(&json!({
+ "action": "check_ingest",
+ "room": nav.room_wire,
+ "thread_tag": thread_tag,
+ "text": {"$form": "text"},
+ "error_target": "thread-compose-errors",
+ "form_id": "thread-compose-form",
+ })).unwrap()) {
+ input type="hidden" name=(UI_RPC_FIELD) value=(template_json_compact(&json!({
+ "action": "post_ingest",
+ "room": nav.room_wire,
+ "thread_tag": thread_tag,
+ "text": {"$form": "text"},
+ "error_target": "thread-compose-errors",
+ "form_id": "thread-compose-form",
+ })).unwrap());
textarea name="text" rows="5" cols="80" placeholder="prose or ~/items and votes…" {}
p {
button type="submit" { "post" }
@@ -712,7 +696,7 @@ pub async fn home(
p class="muted" { "dark = time-ordered · light = vote-ranked" }
div class="thread-feed-toolbar" {
form method="POST" action="/ui" {
- input type="hidden" name=(UI_RPC_FIELD) value=(expand_public_new_thread_rpc_value());
+ input type="hidden" name=(UI_RPC_FIELD) value=(template_json_compact(&HtmlUiAction::ExpandPublicNewThreadForm).expect("static json"));
button type="submit" class="section-add-btn" { "+" }
}
}
@@ -1002,14 +986,15 @@ fn new_thread_form_for_room(nav: &ThreadNav, show: bool, compose_expanded: bool)
if !show {
return html! {};
}
- let rpc_open = set_room_new_thread_compose_expanded_rpc(nav, true);
- let rpc_close = set_room_new_thread_compose_expanded_rpc(nav, false);
// Single root for Idiomorph when morphing `#room-new-thread-ui-slot` (expanded has form + section).
html! {
div class="room-new-thread-slot-inner" {
@if compose_expanded {
form method="POST" action="/ui" {
- input type="hidden" name=(UI_RPC_FIELD) value=(rpc_close);
+ input type="hidden" name=(UI_RPC_FIELD) value=(template_json_compact(&HtmlUiAction::SetRoomNewThreadComposeExpanded {
+ room_wire: nav.room_wire.clone(),
+ expanded: false,
+ }).expect("static json"));
button type="submit" class="form-toggle" aria-expanded="true" {
"-"
}
@@ -1039,7 +1024,10 @@ fn new_thread_form_for_room(nav: &ThreadNav, show: bool, compose_expanded: bool)
}
} @else {
form method="POST" action="/ui" {
- input type="hidden" name=(UI_RPC_FIELD) value=(rpc_open);
+ input type="hidden" name=(UI_RPC_FIELD) value=(template_json_compact(&HtmlUiAction::SetRoomNewThreadComposeExpanded {
+ room_wire: nav.room_wire.clone(),
+ expanded: true,
+ }).expect("static json"));
button type="submit" class="form-toggle" aria-expanded="false" {
"+"
}
@@ -1049,10 +1037,6 @@ fn new_thread_form_for_room(nav: &ThreadNav, show: bool, compose_expanded: bool)
}
}
-pub(crate) fn expand_public_new_thread_rpc_value() -> String {
- template_json_compact(&HtmlUiAction::ExpandPublicNewThreadForm).expect("static json")
-}
-
pub(crate) fn login_to_post_hint_markup() -> Markup {
html! {
p class="muted" { "log in to post" }
diff --git a/server/src/html/forum/access.rs b/server/src/html/forum/access.rs
new file mode 100644
index 0000000000000000000000000000000000000000..f9f7139b63442a6ef3a927b77a72805f15feec3f
--- /dev/null
+++ b/server/src/html/forum/access.rs
@@ -0,0 +1,16 @@
+use crate::events::ThreadCapability;
+use crate::reducer::ReducerState;
+
+pub(crate) fn user_can_view_room(reduced: &ReducerState, room_id: &str, username: Option<&str>) -> bool {
+ if !reduced.rooms.contains(room_id) {
+ return false;
+ }
+ let Some(u) = username else {
+ return false;
+ };
+ reduced.user_has_cap(room_id, u, ThreadCapability::View)
+}
+
+pub(crate) fn user_can_post_room(reduced: &ReducerState, room_id: &str, username: &str) -> bool {
+ reduced.user_has_cap(room_id, username, ThreadCapability::Post)
+}
diff --git a/server/src/html/forum/ingest
… preview truncated; 19,729 characters omittedB — c_0e1a063d5849 (tommy-mor)
message
[cdeb4072] tree nixed
diff preview
diff --git a/server/src/html/mod.rs b/server/src/html/mod.rs
index 82c5993fabfeaf2ea8b9034bccaef37924100264..9c5af9654c7010d2cdb100e4cf63ba63e77c8c57 100644
--- a/server/src/html/mod.rs
+++ b/server/src/html/mod.rs
@@ -12,7 +12,6 @@ mod editor;
mod forum;
mod garden;
mod search;
-mod tree;
use breadcrumb_path::OntologyPath;
pub use auth::{auth_complete_page, auth_signed_in_fragment, choose_username_error_fragment, choose_username_page};
@@ -20,7 +19,6 @@ pub use editor::{editor_check, editor_page};
pub use forum::{index, thread_feed_html, thread_post_expand, thread_post_view, thread_view};
pub use garden::{garden_index, ontology_path};
pub use search::{search_page, search_results_fragment};
-pub use tree::{tree_path, tree_root, tree_select, tree_toggle};
// Embed CSS files at compile time
const THEME_DEFAULT_CSS: &str = include_str!("../../static/theme_default.css");
diff --git a/server/src/html/tree.rs b/server/src/html/tree.rs
deleted file mode 100644
index 6aed7db08682f088df3d52d0358b8dc954e9e1df..0000000000000000000000000000000000000000
--- a/server/src/html/tree.rs
+++ /dev/null
@@ -1,819 +0,0 @@
-use axum::{
- extract::{Path, State},
- http::{header, StatusCode},
- response::{Html, IntoResponse, Response},
- Form,
-};
-use axum::response::Redirect;
-use axum_extra::extract::Query;
-use base64::engine::general_purpose::URL_SAFE_NO_PAD;
-use base64::Engine as _;
-use maud::{html, Markup};
-use serde::{Deserialize, Serialize};
-use std::collections::BTreeSet;
-
-use crate::{
- canonical_path::canonicalize_item,
- path_types::{CanonicalItemUrl, RelativePath},
- scope_rank::ChildrenRankings,
- state::AppState,
-};
-
-// Convenience alias used throughout this module.
-type CanonSet = BTreeSet<CanonicalItemUrl>;
-
-use super::{layout, render_linkified_with_embeds};
-
-/// Query-state for the expandable tree UI.
-#[derive(Debug, Clone, Default, Deserialize)]
-pub struct TreeQuery {
- /// Opaque state blob (base64url postcard).
- #[serde(default)]
- pub s: Option<String>,
-}
-
-#[derive(Debug, Clone, Serialize, Deserialize)]
-struct TreeStateV1 {
- v: u8,
- #[serde(default)]
- open: Vec<String>,
- #[serde(default)]
- selected: Option<String>,
-}
-
-// Note: TreeStateV1/V2 intentionally use raw `String` / `Vec<String>` because
-// they are wire-format structs serialised with postcard. All semantic types
-// (`CanonicalItemUrl`, `RelativePath`) are used in the in-memory
-// `DecodedTreeState` and in every function that works with live data.
-
-#[derive(Debug, Clone, Serialize, Deserialize)]
-enum SelectedRefV2 {
- /// Index into the expanded open list.
- I(u32),
-}
-
-#[derive(Debug, Clone, Serialize, Deserialize)]
-struct TreeStateV2 {
- v: u8,
- /// Common prefix shared by open paths (and optionally selected), ending on a `/` boundary.
- #[serde(default)]
- base: String,
- /// Each entry is a relative path suffix (joined with `base`).
- #[serde(default)]
- open_suffixes: Vec<String>,
- #[serde(default)]
- selected: Option<SelectedRefV2>,
-}
-
-#[derive(Debug, Clone)]
-struct DecodedTreeState {
- open: CanonSet,
- selected: Option<CanonicalItemUrl>,
-}
-
-fn common_base_boundary(paths: &[String]) -> String {
- if paths.is_empty() {
- return String::new();
- }
- let mut prefix = paths[0].as_str();
- for p in &paths[1..] {
- let mut i = 0usize;
- let bytes_a = prefix.as_bytes();
- let bytes_b = p.as_bytes();
- let n = bytes_a.len().min(bytes_b.len());
- while i < n && bytes_a[i] == bytes_b[i] {
- i += 1;
- }
- prefix = &prefix[..i];
- if prefix.is_empty() {
- break;
- }
- }
- // Snap to last '/' boundary (include the slash).
- match prefix.rfind('/') {
- None => String::new(),
- Some(idx) => prefix[..=idx].to_string(),
- }
-}
-
-fn canon_root(root: &str) -> Option<CanonicalItemUrl> {
- CanonicalItemUrl::parse(root)
-}
-
-fn canon_to_relative(root: &CanonicalItemUrl, item: &str) -> Option<RelativePath> {
- // Only support ontology items under the same root.
- let root_str = root.as_str();
- let item_can = canonicalize_item(item);
- if item_can.is_empty() {
- return None;
- }
- // Root must be ontology (`https://slug.social/~/...`)
- root.tilde_tail()?;
- if item_can == root_str {
- return RelativePath::new("");
- }
- let prefix = if root_str.ends_with('/') {
- root_str.to_string()
- } else {
- format!("{}/", root_str)
- };
- if !item_can.starts_with(&prefix) {
- return None;
- }
- let suffix = &item_can[prefix.len()..];
- RelativePath::new(suffix)
-}
-
-fn relative_to_canon(root: &CanonicalItemUrl, rel: &RelativePath) -> Option<CanonicalItemUrl> {
- rel.join_under_ontology_root(root)
-}
-
-fn encode_state_blob_v2(
- root: &str,
- open: &CanonSet,
- selected: Option<&CanonicalItemUrl>,
-) -> String {
- let Some(root_can) = canon_root(root) else {
- return String::new();
- };
-
- // Convert to sorted relative paths (strings for wire encoding).
- let mut rels: Vec<String> = open
- .iter()
- .filter_map(|it| canon_to_relative(&root_can, it.as_str()).map(|r| r.0.clone()))
- .collect();
- rels.sort();
- rels.dedup();
-
- let sel_rel: Option<String> = selected
- .and_then(|s| canon_to_relative(&root_can, s.as_str()))
- .map(|r| r.0.clone());
-
- // In v2 we enforce: selected ∈ open. This allows selected to be encoded as an index only.
- if let Some(sr) = &sel_rel {
- rels.push(sr.clone());
- rels.sort();
- rels.dedup();
- }
-
- // base dedupe over open rels + selection (if present)
- let mut base_inputs = rels.clone();
- if let Some(sr) = &sel_rel {
- base_inputs.push(sr.clone());
- }
- let base = common_base_boundary(&base_inputs);
-
- let open_suffixes: Vec<String> = rels
- .iter()
- .map(|r| r.strip_prefix(&base).unwrap_or(r).to_string())
- .collect();
-
- let selected_ref: Option<SelectedRefV2> = sel_rel.and_then(|full| {
- rels.iter()
- .position(|r| r == &full)
- .map(|idx| SelectedRefV2::I(idx as u32))
- });
-
- let st = TreeStateV2 {
- v: 2,
- base,
- open_suffixes,
- selected: selected_ref,
- };
- let bytes = postcard::to_allocvec(&st).unwrap_or_default();
- URL_SAFE_NO_PAD.encode(bytes)
-}
-
-fn decode_state_blob_any(root: &str, s: &str) -> Option<DecodedTreeState> {
- let root_can = canon_root(root)?;
- let bytes = URL_SAFE_NO_PAD.decode(s).ok()?;
- // Try v2 first.
- if let Ok(st2) = postcard::from_bytes::<TreeStateV2>(&bytes) {
- if st2.v == 2 {
- let mut open: CanonSet = BTreeSet::new();
- for suf in st2.open_suffixes {
- let full_rel = format!("{}{}", st2.base, suf);
- if let Some(rp) = RelativePath::new(&full_rel) {
- if let Some(c) = relative_to_canon(&root_can, &rp) {
- open.insert(c);
- }
- }
- }
- let selected: Option<CanonicalItemUrl> = match st2.selected {
- None => None,
- Some(SelectedRefV2::I(i)) => {
- let idx = i as usize;
- // Index into the sorted open set (BTreeSet iteration is sorted).
- open.iter().nth(idx).cloned()
- }
- // v2 always encodes selected as an index; no string fallback
- };
- return Some(DecodedTreeState { open, selected });
- }
- }
- // Fallback v1 (stored canonical-ish strings).
- let st1: TreeStateV1 = postcard::from_bytes(&bytes).ok()?;
- if st1.v != 1 {
- return None;
- }
- let open: CanonSet = st1
- .open
- .into_iter()
- .filter_map(|s| CanonicalItemUrl::parse(&canonicalize_item(&s)))
- .collect();
- let selected = st1
- .selected
- .as_ref()
- .and_then(|s| CanonicalItemUrl::parse(&canonicalize_item(s)));
- Some(DecodedTreeState { open, selected })
-}
-
-fn baseline_state_blob() -> String {
- // Root doesn't affect empty state; V2 encodes open=[], selected=None.
- // We still build it via V2 encoder for forward-compat.
- encode_state_blob_v2("https://slug.social/~/", &CanonSet::new(), None)
-}
-
-fn href_for(root: &str, open: &CanonSet, selected: Option<&CanonicalItemUrl>) -> String {
- let blob = encode_state_blob_v2(root, open, selected);
- let base = format!("/tree/{}", root.trim_start_matches("https://slug.social/~/"))
- .trim_end_matches('/')
- .to_string();
- format!("{base}?s={blob}")
-}
-
-fn tree_root_from_path(path: Option<&str>) -> String {
- // Interpret /tree and /tree/*path as `~/...` under slug.social.
- // Empty path => "~/"
- match path {
- None => canonicalize_item("~/"),
- Some(p) if p.trim().is_empty() => canonicalize_item("~/"),
- Some(p) => canonicalize_item(&format!("~/{}", p.trim_start_matches('/'))),
- }
-}
-
-fn ranked_children_public(
- reduced: &crate::reducer::ReducerState,
- parent: &str,
-) -> Vec<CanonicalItemUrl> {
- // Reducer parent keys are derived from `item_parent_path`, which uses
- // item_children uses "https://slug.social/~" (no trailing slash) as the root
- // parent key. Use ontology_root() for the root case, or parse the given parent.
- let parent_can = if parent.trim_end_matches('/') == "https://slug.social/~" || parent == "https://slug.social/~/" {
- CanonicalItemUrl::ontology_root()
- } else {
- CanonicalItemUrl::parse(parent.trim_end_matches('/'))
- .unwrap_or_else(CanonicalItemUrl::ontology_root)
- };
- let rankings: ChildrenRankings =
- crate::scope_rank::build_children_rankings(reduced.public(), &parent_can);
- let mut out: Vec<CanonicalItemUrl> = Vec::new();
- let mut seen: std::collections::HashSet<CanonicalItemUrl> = std::collections::HashSet::new();
-
- for comp in rankings.component_rankings {
- for r in comp.ranked {
- seen.insert(r.item.clone());
- out.push(r.item);
- }
- }
- for it in rankings.unranked_items {
- seen.insert(it.clone());
- out.push(it);
- }
-
- // Also surface phantom intermediate nodes: keys of item_children that are
- // direct children of parent but were never explicitly ingested as items
- // (so they don't appear in any ranking). Example: ~/languages exists only as
- // a parent of ~/languages/rust etc., never ranked at the root level.
- let phantom_parent_prefix = format!("{}/", parent_can.as_str());
- for key in reduced.public().item_children.keys() {
- let key_str = key.as_str();
- if !key_str.starts_with(&phantom_parent_prefix) {
- continue;
- }
- // Must be a direct child: no further '/' after the prefix.
- let tail = &key_str[phantom_parent_prefix.len()..];
- if tail.contains('/') {
- continue;
- }
- if seen.contains(key) {
- continue;
- }
- seen.insert(key.clone());
- out.push(key.clone());
- }
-
- out
-}
-
-fn node_id(path: &str) -> String {
- // Stable DOM id derived from canonical path.
- let mut h: u64 = 1469598103934665603; // FNV-1a 64-bit offset basis
- for b in path.as_bytes() {
- h ^= *b as u64;
- h = h.wrapping_mul(1099511628211);
- }
- format!("node-{:016x}", h)
-}
-
-fn render_tree_node(
- reduced: &crate::reducer::ReducerState,
- path: &CanonicalItemUrl,
- root: &str,
- open: &CanonSet,
- selected: Option<&CanonicalItemUrl>,
-) -> Markup {
- let path_str = path.as_str();
- let id = node_id(path_str);
- let is_open = open.contains(path);
-
… preview truncated; 17,487 characters omittedHardlinks — judgments / attempts / prompt
judgments
attempts
Prompt text is loaded only by the download route.